[Radiance-general] new evalglare version available

[Randolph M. Fritz]

Jan, Rob,

I don't think nested functions are any version of standard C; I'm 
pretty sure they are a GNU compiler extension.  If it's possible, do 
you think you could engineer these out?  I'd look at it, but no-way do 
I have time to work on it.

it's probably best if C code compiles with the gcc "-ansi -pedantic" 
(c90) or "-std=c99 -pedantic" options.  That's not a complete check; 
some non-ISO usages are not caught, but it's better than simply letting 
something completely non-standard slip through.

Randolph

(Do we need to take this to the developer list?)

On 2012-02-17 16:34:39 +0000, Guglielmetti, Robert said:

> Hi Jan,
> 
> Exciting news!
> 
> I just tried compiling this on MacOS ang I get the following error:
> 
> rgugliel-14846s:evalglare rgugliel$ make evalglare
> gcc -c -g -DMSDOS  -DPICT_GLARE -DFLOAT=double -O3  -Wall  -o
> common/color.o common/color.c -I. -Igeometry
> gcc -c -g -DMSDOS  -DPICT_GLARE -DFLOAT=double -O3  -Wall  -o
> common/resolu.o common/resolu.c -I. -Igeometry
> common/resolu.c: In function Œstr2resolu¹:
> common/resolu.c:98: warning: implicit declaration of function Œatoi¹
> gcc -c -g -DMSDOS  -DPICT_GLARE -DFLOAT=double -O3  -Wall  -o
> common/header.o common/header.c -I. -Igeometry
> gcc -c -g -DMSDOS  -DPICT_GLARE -DFLOAT=double -O3  -Wall  -o
> common/image.o common/image.c -I. -Igeometry
> gcc -c -g -DMSDOS  -DPICT_GLARE -DFLOAT=double -O3  -Wall  -o
> common/fvect.o common/fvect.c -I. -Igeometry
> gcc -c -g -DMSDOS  -DPICT_GLARE -DFLOAT=double -O3  -Wall  -o
> common/badarg.o common/badarg.c -I. -Igeometry
> gcc -c -g -DMSDOS  -DPICT_GLARE -DFLOAT=double -O3  -Wall  -o
> common/words.o common/words.c -I. -Igeometry
> gcc -c -g -DMSDOS  -DPICT_GLARE -DFLOAT=double -O3  -Wall  -o
> common/fputword.o common/fputword.c -I. -Igeometry
> gcc -c -g -DMSDOS  -DPICT_GLARE -DFLOAT=double -O3  -Wall  -o
> common/expandarg.o common/expandarg.c -I. -Igeometry
> gcc -c -g -DMSDOS  -DPICT_GLARE -DFLOAT=double -O3  -Wall  -o
> common/wordfile.o common/wordfile.c -I. -Igeometry
> gcc -c -g -DMSDOS  -DPICT_GLARE -DFLOAT=double -O3  -Wall  -o
> common/bmalloc.o common/bmalloc.c -I. -Igeometry
> gcc -c -g -DMSDOS  -DPICT_GLARE -DFLOAT=double -O3  -Wall  -o
> common/mat4.o common/mat4.c -I. -Igeometry
> gcc -c -g -DMSDOS  -DPICT_GLARE -DFLOAT=double -O3  -Wall  -o pictool.o
> pictool.c -I. -Igeometry
> pictool.c: In function Œread_exposure¹:
> pictool.c:90: error: nested functions are disabled, use -fnested-functions
> to re-enable
> make: *** [pictool.o] Error 1
> 
> Then I tried the following, also with no luck:
> 
> rgugliel-14846s:evalglare rgugliel$ make evalglare -fnested-functions
> make: nested-functions: No such file or directory
> make: *** No rule to make target `nested-functions'.  Stop.
> rgugliel-14846s:evalglare rgugliel$ make -fnested-functions evalglare
> make: nested-functions: No such file or directory
> make: *** No rule to make target `nested-functions'.  Stop.
> rgugliel-14846s:evalglare rgugliel$
> 
> Ideas? I know you only vouch for Linux with the source and provide a
> pre-compiled Windows version, but it'd be good to get this working on
> MacOS once and for all, now that it's at version 1.0 status.
> 
> 
> Rob Guglielmetti  IESNA, LEED AP
> Commercial Buildings Research Group
> National Renewable Energy Laboratory
> 1617 Cole Blvd MS:RSF202
> Golden, CO 80401
> T. 303.275.4319
> F. 303.630.2055
> E. robert.guglielmetti at nrel.gov
> 
> 
> 
> 
> 
> On 2/17/12 6:59 AM, "Jan Wienold" 
> <jan.wienold at ise.fraunhofer.de> wrote:
> 
>> Hi All,
>> 
>> I want to announce a new evalglare version ready for download. (version
>> 1.0).
>> 
>> Following main changes are included (see also the short documentation
>> which is included in the package) :
>> 
>> -all current view types will be supported (except parallel view) - that
>> means also -vth !
>> -valid view is checked (many problems occurred, because often users
>> treat the image with programs like pcompos before putting into
>> evalglare. But then, the view got lost and a wrong view leads to totally
>> wrong results! Now this will be handled by the new evalglare )
>> -view options can be provided also per command line option
>> -disability glare is also calculated
>> -cut-out the "Guth" visual field
>> -extension of the DGP equation for low-brightness scenes (Ev<380lux) ,
>> based on new user assessments
>> 
>> The main routines for glare source detection and calculation of the
>> glare values are not changed.
>> 
>> Anyhow I strongly recommend to use from now on only the new version,
>> because the issue with non valid views can cause many troubles and wrong
>> values.
>> (and I guess many people use it and run into that problem and got wrong
>> values without knowing it!!).
>> 
>> You can download the new version here:
>> 
>> http://www.ise.fraunhofer.de/radiance
>> 
>> good luck and an always glare free environment... ,
>> 
>> Jan
>> 
>> --
>> Dr.-Ing. Jan Wienold
>> Head of Team Passive Systems and Daylighting
>> Fraunhofer-Institut für Solare Energiesysteme
>> Thermal Systems and Buildings
>> Heidenhofstr. 2, 79110 Freiburg, Germany
>> Phone: +49(0)761 4588 5133 Fax:+49(0)761 4588 9133
>> jan.wienold at ise.fraunhofer.de
>> http://www.ise.fraunhofer.de
>> 
>> In office:
>> Mo,Tue: 8:30-18:00
>> We,Thu: 8:30-16:00
>> Fr:  8:30-15:30
>> 
>> 
>> _______________________________________________
>> Radiance-general mailing list
>> Radiance-general at radiance-online.org
>> http://www.radiance-online.org/mailman/listinfo/radiance-general


-- 
Randolph M. Fritz