ViewVC Help
View File | Revision Log | Show Annotations | Download File | Root Listing
root/radiance/src/rt/raypcalls.c
(Generate patch)

Comparing src/rt/raypcalls.c (file contents):
Revision 2.3 by greg, Thu Jul 3 15:00:19 2003 UTC vs.
Revision 2.9 by greg, Mon Sep 20 16:26:58 2004 UTC

# Line 51 | Line 51 | static const char      RCSid[] = "$Id$";
51   *  Note the differences between this and the simpler ray_trace()
52   *  call.  In particular, the call may or may not return a value
53   *  in the passed ray structure.  Also, you need to call rayorigin()
54 < *  yourself, which is normally for you by ray_trace().  The
55 < *  great thing is that ray_pqueue() will trace rays faster in
54 > *  yourself, which is normally called for you by ray_trace().  The
55 > *  benefit is that ray_pqueue() will trace rays faster in
56   *  proportion to the number of CPUs you have available on your
57   *  system.  If the ray queue is full before the call, ray_pqueue()
58   *  will block until a result is ready so it can queue this one.
# Line 81 | Line 81 | static const char      RCSid[] = "$Id$";
81   *              ray_psend(&myRay);
82   *      }
83   *
84 < *  The ray_presult() and/or ray_pqueue() functions may then be
85 < *  called to read back the results.
84 > *  Note that it is a fatal error to call ra_psend() when
85 > *  ray_pnidle is zero.  The ray_presult() and/or ray_pqueue()
86 > *  functions may be called subsequently to read back the results.
87   *
88   *  When you are done, you may call ray_pdone(1) to close
89   *  all child processes and clean up memory used by Radiance.
# Line 99 | Line 100 | static const char      RCSid[] = "$Id$";
100   *  If you just want to reap children so that you can alter the
101   *  rendering parameters without reloading the scene, use the
102   *  ray_pclose(0) and ray_popen(nproc) calls to close
103 < *  then restart the child processes.
103 > *  then restart the child processes after the changes are made.
104   *
105   *  Note:  These routines are written to coordinate with the
106   *  definitions in raycalls.c, and in fact depend on them.
107   *  If you want to trace a ray and get a result synchronously,
108 < *  use the ray_trace() call to compute it in the parent process.
108 > *  use the ray_trace() call to compute it in the parent process
109 > *  This will not interfere with any subprocess calculations,
110 > *  but beware that a fatal error may end with a call to quit().
111   *
112   *  Note:  One of the advantages of using separate processes
113   *  is that it gives the calling program some immunity from
114   *  fatal rendering errors.  As discussed in raycalls.c,
115   *  Radiance tends to throw up its hands and exit at the
116   *  first sign of trouble, calling quit() to return control
117 < *  to the system.  Although you can avoid exit() with
117 > *  to the top level.  Although you can avoid exit() with
118   *  your own longjmp() in quit(), the cleanup afterwards
119   *  is always suspect.  Through the use of subprocesses,
120   *  we avoid this pitfall by closing the processes and
# Line 120 | Line 123 | static const char      RCSid[] = "$Id$";
123   *  of these calls, you can assume that the processes have
124   *  been cleaned up with a call to ray_close(), though you
125   *  will have to call ray_pdone() yourself if you want to
126 < *  free memory.  Obviously, you cannot continue rendering,
127 < *  but otherwise your process should not be compromised.
126 > *  free memory.  Obviously, you cannot continue rendering
127 > *  without risking further errors, but otherwise your
128 > *  process should not be compromised.
129   */
130  
131 < #include  "ray.h"
131 > #include <stdio.h>
132 > #include <sys/types.h>
133 > #include <sys/wait.h> /* XXX platform */
134  
135 + #include  "rtprocess.h"
136 + #include  "ray.h"
137 + #include  "ambient.h"
138   #include  "selcall.h"
139  
140   #ifndef RAYQLEN
# Line 160 | Line 169 | static int     r_recv_next;            /* next receive ray placement
169  
170   #define sendq_full()    (r_send_next >= RAYQLEN)
171  
172 + static int ray_pflush(void);
173 + static void ray_pchild(int      fd_in, int      fd_out);
174  
175 < void
176 < ray_pinit(otnm, nproc)          /* initialize ray-tracing processes */
177 < char    *otnm;
178 < int     nproc;
175 >
176 > extern void
177 > ray_pinit(              /* initialize ray-tracing processes */
178 >        char    *otnm,
179 >        int     nproc
180 > )
181   {
182          if (nobjects > 0)               /* close old calculation */
183                  ray_pdone(0);
# Line 185 | Line 198 | int    nproc;
198  
199  
200   static int
201 < ray_pflush()                    /* send queued rays to idle children */
201 > ray_pflush(void)                        /* send queued rays to idle children */
202   {
203          int     nc, n, nw, i, sfirst;
204  
205 <        if ((ray_pnidle <= 0 | r_send_next <= 0))
205 >        if ((ray_pnidle <= 0) | (r_send_next <= 0))
206                  return(0);              /* nothing we can send */
207          
208          sfirst = 0;                     /* divvy up labor */
# Line 219 | Line 232 | ray_pflush()                   /* send queued rays to idle children */
232   }
233  
234  
235 < void
236 < ray_psend(r)                    /* add a ray to our send queue */
237 < RAY     *r;
235 > extern void
236 > ray_psend(                      /* add a ray to our send queue */
237 >        RAY     *r
238 > )
239   {
240          if (r == NULL)
241                  return;
# Line 229 | Line 243 | RAY    *r;
243          if (sendq_full() && ray_pflush() <= 0)
244                  error(INTERNAL, "ray_pflush failed in ray_psend");
245  
246 <        copystruct(&r_queue[r_send_next], r);
246 >        r_queue[r_send_next] = *r;
247          r_send_next++;
248   }
249  
250  
251 < int
252 < ray_pqueue(r)                   /* queue a ray for computation */
253 < RAY     *r;
251 > extern int
252 > ray_pqueue(                     /* queue a ray for computation */
253 >        RAY     *r
254 > )
255   {
256          if (r == NULL)
257                  return(0);
# Line 244 | Line 259 | RAY    *r;
259          if (sendq_full()) {
260                  RAY     mySend;
261                  int     rval;
262 <                copystruct(&mySend, r);
262 >                mySend = *r;
263                                          /* wait for a result */
264                  rval = ray_presult(r, 0);
265                                          /* put new ray in queue */
266 <                copystruct(&r_queue[r_send_next], &mySend);
266 >                r_queue[r_send_next] = mySend;
267                  r_send_next++;
268                  return(rval);           /* done */
269          }
270                                          /* add ray to send queue */
271 <        copystruct(&r_queue[r_send_next], r);
271 >        r_queue[r_send_next] = *r;
272          r_send_next++;
273                                          /* check for returned ray... */
274          if (r_recv_first >= r_recv_next)
275                  return(0);
276                                          /* ...one is sitting in queue */
277 <        copystruct(r, &r_queue[r_recv_first]);
277 >        *r = r_queue[r_recv_first];
278          r_recv_first++;
279          return(1);
280   }
281  
282  
283 < int
284 < ray_presult(r, poll)            /* check for a completed ray */
285 < RAY     *r;
286 < int     poll;
283 > extern int
284 > ray_presult(            /* check for a completed ray */
285 >        RAY     *r,
286 >        int     poll
287 > )
288   {
289          static struct timeval   tpoll;  /* zero timeval struct */
290          static fd_set   readset, errset;
# Line 279 | Line 295 | int    poll;
295                  return(0);
296                                          /* check queued results first */
297          if (r_recv_first < r_recv_next) {
298 <                copystruct(r, &r_queue[r_recv_first]);
298 >                *r = r_queue[r_recv_first];
299                  r_recv_first++;
300                  return(1);
301          }
# Line 354 | Line 370 | getready:                              /* any children waiting for us? */
370                  rp->slights = NULL;
371          }
372                                          /* return first ray received */
373 <        copystruct(r, &r_queue[r_recv_first]);
373 >        *r = r_queue[r_recv_first];
374          r_recv_first++;
375          return(1);
376   }
377  
378  
379 < void
380 < ray_pdone(freall)               /* reap children and free data */
381 < int     freall;
379 > extern void
380 > ray_pdone(              /* reap children and free data */
381 >        int     freall
382 > )
383   {
384          ray_pclose(0);                  /* close child processes */
385  
# Line 375 | Line 392 | int    freall;
392  
393  
394   static void
395 < ray_pchild(fd_in, fd_out)       /* process rays (never returns) */
396 < int     fd_in;
397 < int     fd_out;
395 > ray_pchild(     /* process rays (never returns) */
396 >        int     fd_in,
397 >        int     fd_out
398 > )
399   {
400          int     n;
401          register int    i;
# Line 421 | Line 439 | int    fd_out;
439   }
440  
441  
442 < void
443 < ray_popen(nadd)                 /* open the specified # processes */
444 < int     nadd;
442 > extern void
443 > ray_popen(                      /* open the specified # processes */
444 >        int     nadd
445 > )
446   {
447                                          /* check if our table has room */
448          if (ray_pnprocs + nadd > MAX_NPROCS)
# Line 449 | Line 468 | int    nadd;
468                  if (r_proc[ray_pnprocs].pid < 0)
469                          error(SYSTEM, "cannot fork child process");
470                  close(p1[0]); close(p0[1]);
471 +                /*
472 +                 * Close write stream on exec to avoid multiprocessing deadlock.
473 +                 * No use in read stream without it, so set flag there as well.
474 +                 */
475 +                fcntl(p1[1], F_SETFD, FD_CLOEXEC);
476 +                fcntl(p0[0], F_SETFD, FD_CLOEXEC);
477                  r_proc[ray_pnprocs].fd_send = p1[1];
478                  r_proc[ray_pnprocs].fd_recv = p0[0];
479                  r_proc[ray_pnprocs].npending = 0;
# Line 458 | Line 483 | int    nadd;
483   }
484  
485  
486 < void
487 < ray_pclose(nsub)                /* close one or more child processes */
488 < int     nsub;
486 > extern void
487 > ray_pclose(             /* close one or more child processes */
488 >        int     nsub
489 > )
490   {
491          static int      inclose = 0;
492          RAY     res;
# Line 469 | Line 495 | int    nsub;
495                  return;
496          inclose++;
497                                          /* check argument */
498 <        if ((nsub <= 0 | nsub > ray_pnprocs))
498 >        if ((nsub <= 0) | (nsub > ray_pnprocs))
499                  nsub = ray_pnprocs;
500                                          /* clear our ray queue */
501          while (ray_presult(&res,0) > 0)
# Line 480 | Line 506 | int    nsub;
506                  ray_pnprocs--;
507                  close(r_proc[ray_pnprocs].fd_recv);
508                  close(r_proc[ray_pnprocs].fd_send);
509 <                while (wait(&status) != r_proc[ray_pnprocs].pid)
510 <                        ;
509 >                if (waitpid(r_proc[ray_pnprocs].pid, &status, 0) < 0)
510 >                        status = 127<<8;
511                  if (status) {
512                          sprintf(errmsg,
513                                  "rendering process %d exited with code %d",

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines