--- ray/src/util/rmatrix.c 2020/05/07 18:45:16 2.44 +++ ray/src/util/rmatrix.c 2023/11/28 00:39:56 2.62 @@ -1,5 +1,5 @@ #ifndef lint -static const char RCSid[] = "$Id: rmatrix.c,v 2.44 2020/05/07 18:45:16 greg Exp $"; +static const char RCSid[] = "$Id: rmatrix.c,v 2.62 2023/11/28 00:39:56 greg Exp $"; #endif /* * General matrix operations. @@ -12,28 +12,62 @@ static const char RCSid[] = "$Id: rmatrix.c,v 2.44 202 #include "resolu.h" #include "paths.h" #include "rmatrix.h" +#if !defined(_WIN32) && !defined(_WIN64) +#include +#endif -static char rmx_mismatch_warn[] = "WARNING: data type mismatch\n"; +static const char rmx_mismatch_warn[] = "WARNING: data type mismatch\n"; -/* Allocate a nr x nc matrix with n components */ +#define array_size(rm) (sizeof(double)*(rm)->nrows*(rm)->ncols*(rm)->ncomp) +#define mapped_size(rm) ((char *)(rm)->mtx + array_size(rm) - (char *)(rm)->mapped) + +/* Initialize a RMATRIX struct but don't allocate array space */ RMATRIX * -rmx_alloc(int nr, int nc, int n) +rmx_new(int nr, int nc, int n) { RMATRIX *dnew; - if ((nr <= 0) | (nc <= 0) | (n <= 0)) + if (n <= 0) return(NULL); - dnew = (RMATRIX *)malloc(sizeof(RMATRIX)-sizeof(dnew->mtx) + - sizeof(dnew->mtx[0])*(n*nr*nc)); - if (!dnew) - return(NULL); - dnew->nrows = nr; dnew->ncols = nc; dnew->ncomp = n; - dnew->dtype = DTdouble; - dnew->swapin = 0; - dnew->info = NULL; + + dnew = (RMATRIX *)calloc(1, sizeof(RMATRIX)); + if (dnew) { + dnew->dtype = DTdouble; + dnew->nrows = nr; + dnew->ncols = nc; + dnew->ncomp = n; + setcolor(dnew->cexp, 1.f, 1.f, 1.f); + memcpy(dnew->wlpart, WLPART, sizeof(dnew->wlpart)); + } return(dnew); } +/* Prepare a RMATRIX for writing (allocate array if needed) */ +int +rmx_prepare(RMATRIX *rm) +{ + if (!rm) return(0); + if (rm->mtx) + return(1); + if ((rm->nrows <= 0) | (rm->ncols <= 0) | (rm->ncomp <= 0)) + return(0); + rm->mtx = (double *)malloc(array_size(rm)); + return(rm->mtx != NULL); +} + +/* Call rmx_new() and rmx_prepare() */ +RMATRIX * +rmx_alloc(int nr, int nc, int n) +{ + RMATRIX *dnew = rmx_new(nr, nc, n); + + if (dnew && !rmx_prepare(dnew)) { + rmx_free(dnew); + dnew = NULL; + } + return(dnew); +} + /* Free a RMATRIX array */ void rmx_free(RMATRIX *rm) @@ -41,6 +75,12 @@ rmx_free(RMATRIX *rm) if (!rm) return; if (rm->info) free(rm->info); +#ifdef MAP_FILE + if (rm->mapped) + munmap(rm->mapped, mapped_size(rm)); + else +#endif + free(rm->mtx); free(rm); } @@ -48,8 +88,8 @@ rmx_free(RMATRIX *rm) int rmx_newtype(int dtyp1, int dtyp2) { - if ((dtyp1==DTxyze) | (dtyp1==DTrgbe) | - (dtyp2==DTxyze) | (dtyp2==DTrgbe) + if ((dtyp1==DTxyze) | (dtyp1==DTrgbe) | (dtyp1==DTspec) | + (dtyp2==DTxyze) | (dtyp2==DTrgbe) | (dtyp2==DTspec) && dtyp1 != dtyp2) return(0); if (dtyp1 < dtyp2) @@ -61,17 +101,21 @@ rmx_newtype(int dtyp1, int dtyp2) int rmx_addinfo(RMATRIX *rm, const char *info) { + int oldlen = 0; + if (!rm || !info || !*info) return(0); if (!rm->info) { rm->info = (char *)malloc(strlen(info)+1); if (rm->info) rm->info[0] = '\0'; - } else + } else { + oldlen = strlen(rm->info); rm->info = (char *)realloc(rm->info, - strlen(rm->info)+strlen(info)+1); + oldlen+strlen(info)+1); + } if (!rm->info) return(0); - strcat(rm->info, info); + strcpy(rm->info+oldlen, info); return(1); } @@ -82,10 +126,10 @@ get_dminfo(char *s, void *p) char fmt[MAXFMTLEN]; int i; - if (headidval(fmt, s)) + if (headidval(NULL, s)) return(0); - if (!strncmp(s, "NCOMP=", 6)) { - ip->ncomp = atoi(s+6); + if (isncomp(s)) { + ip->ncomp = ncompval(s); return(0); } if (!strncmp(s, "NROWS=", 6)) { @@ -101,20 +145,24 @@ get_dminfo(char *s, void *p) return(0); } if (isexpos(s)) { - double d = exposval(s); - scalecolor(ip->mtx, d); + float f = exposval(s); + scalecolor(ip->cexp, f); return(0); } if (iscolcor(s)) { COLOR ctmp; colcorval(ctmp, s); - multcolor(ip->mtx, ctmp); + multcolor(ip->cexp, ctmp); return(0); } + if (iswlsplit(s)) { + wlsplitval(ip->wlpart, s); + return(0); + } if (!formatval(fmt, s)) { rmx_addinfo(ip, s); return(0); - } + } /* else check format */ for (i = 1; i < DTend; i++) if (!strcmp(fmt, cm_fmt_id[i])) { ip->dtype = i; @@ -128,11 +176,15 @@ rmx_load_ascii(RMATRIX *rm, FILE *fp) { int i, j, k; + if (!rmx_prepare(rm)) + return(0); for (i = 0; i < rm->nrows; i++) - for (j = 0; j < rm->ncols; j++) + for (j = 0; j < rm->ncols; j++) { + double *dp = rmx_lval(rm,i,j); for (k = 0; k < rm->ncomp; k++) - if (fscanf(fp, "%lf", &rmx_lval(rm,i,j,k)) != 1) + if (fscanf(fp, "%lf", &dp[k]) != 1) return(0); + } return(1); } @@ -146,14 +198,17 @@ rmx_load_float(RMATRIX *rm, FILE *fp) fputs("Unsupported # components in rmx_load_float()\n", stderr); exit(1); } + if (!rmx_prepare(rm)) + return(0); for (i = 0; i < rm->nrows; i++) for (j = 0; j < rm->ncols; j++) { + double *dp = rmx_lval(rm,i,j); if (getbinary(val, sizeof(val[0]), rm->ncomp, fp) != rm->ncomp) return(0); if (rm->swapin) swap32((char *)val, rm->ncomp); for (k = rm->ncomp; k--; ) - rmx_lval(rm,i,j,k) = val[k]; + dp[k] = val[k]; } return(1); } @@ -162,18 +217,27 @@ static int rmx_load_double(RMATRIX *rm, FILE *fp) { int i; - - if ((char *)&rmx_lval(rm,1,0,0) - (char *)&rmx_lval(rm,0,0,0) != - sizeof(double)*rm->ncols*rm->ncomp) { - fputs("Code error in rmx_load_double()\n", stderr); - exit(1); +#ifdef MAP_FILE + long pos; /* map memory for file > 1MB if possible */ + if (!rm->swapin && array_size(rm) >= 1L<<20 && + (pos = ftell(fp)) >= 0 && !(pos % sizeof(double))) { + rm->mapped = mmap(NULL, array_size(rm)+pos, PROT_READ|PROT_WRITE, + MAP_PRIVATE, fileno(fp), 0); + if (rm->mapped != MAP_FAILED) { + rm->mtx = (double *)rm->mapped + pos/sizeof(double); + return(1); + } /* else fall back on reading into memory */ + rm->mapped = NULL; } +#endif + if (!rmx_prepare(rm)) + return(0); for (i = 0; i < rm->nrows; i++) { - if (getbinary(&rmx_lval(rm,i,0,0), sizeof(double)*rm->ncomp, + if (getbinary(rmx_lval(rm,i,0), sizeof(double)*rm->ncomp, rm->ncols, fp) != rm->ncols) return(0); if (rm->swapin) - swap64((char *)&rmx_lval(rm,i,0,0), rm->ncols*rm->ncomp); + swap64((char *)rmx_lval(rm,i,0), rm->ncols*rm->ncomp); } return(1); } @@ -186,122 +250,174 @@ rmx_load_rgbe(RMATRIX *rm, FILE *fp) if (!scan) return(0); + if (!rmx_prepare(rm)) { + free(scan); + return(0); + } for (i = 0; i < rm->nrows; i++) { + double *dp = rmx_lval(rm,i,0); if (freadscan(scan, rm->ncols, fp) < 0) { free(scan); return(0); } - for (j = rm->ncols; j--; ) { - rmx_lval(rm,i,j,0) = colval(scan[j],RED); - rmx_lval(rm,i,j,1) = colval(scan[j],GRN); - rmx_lval(rm,i,j,2) = colval(scan[j],BLU); + for (j = 0; j < rm->ncols; j++, dp += 3) { + dp[0] = colval(scan[j],RED); + dp[1] = colval(scan[j],GRN); + dp[2] = colval(scan[j],BLU); } } free(scan); return(1); } +static int +rmx_load_spec(RMATRIX *rm, FILE *fp) +{ + uby8 *scan; + SCOLOR scol; + int i, j, k; + + if (rm->ncomp < 3) + return(0); + scan = (uby8 *)malloc((rm->ncomp+1)*rm->ncols); + if (!scan) + return(0); + if (!rmx_prepare(rm)) { + free(scan); + return(0); + } + for (i = 0; i < rm->nrows; i++) { + double *dp = rmx_lval(rm,i,0); + if (freadscolrs(scan, rm->ncomp, rm->ncols, fp) < 0) { + free(scan); + return(0); + } + for (j = 0; j < rm->ncols; j++) { + scolr2scolor(scol, scan+j*(rm->ncomp+1), rm->ncomp); + for (k = 0; k < rm->ncomp; k++) + *dp++ = scol[k]; + } + } + free(scan); + return(1); +} + +/* Read matrix header from input stream (cannot be XML) */ +int +rmx_load_header(RMATRIX *rm, FILE *fp) +{ + if (!rm | !fp) + return(-1); + if (rm->info) { /* clear state */ + free(rm->info); + rm->info = NULL; + } + if (rm->mtx) { /* ...and data */ +#ifdef MAP_FILE + if (rm->mapped) { + munmap(rm->mapped, mapped_size(rm)); + rm->mapped = NULL; + } else +#endif + free(rm->mtx); + rm->mtx = NULL; + } + if (rm->nrows | rm->ncols | !rm->dtype) { + rm->nrows = rm->ncols = 0; + rm->ncomp = 3; + setcolor(rm->cexp, 1.f, 1.f, 1.f); + memcpy(rm->wlpart, WLPART, sizeof(rm->wlpart)); + } + SET_FILE_BINARY(fp); + rm->dtype = DTascii; /* assumed w/o FORMAT */ + if (getheader(fp, get_dminfo, rm) < 0) { + fputs("Unrecognized matrix format\n", stderr); + return(-1); + } + /* resolution string? */ + if ((rm->nrows <= 0) | (rm->ncols <= 0)) { + if (!fscnresolu(&rm->ncols, &rm->nrows, fp)) + return(-1); + if ((rm->dtype == DTrgbe) | (rm->dtype == DTxyze) && + rm->ncomp != 3) + return(-1); + } + return(rm->dtype); +} + +/* Allocate & load post-header data from stream given type set in rm->dtype */ +int +rmx_load_data(RMATRIX *rm, FILE *fp) +{ + switch (rm->dtype) { + case DTascii: + SET_FILE_TEXT(fp); + return(rmx_load_ascii(rm, fp)); + case DTfloat: + return(rmx_load_float(rm, fp)); + case DTdouble: + return(rmx_load_double(rm, fp)); + case DTrgbe: + case DTxyze: + return(rmx_load_rgbe(rm, fp)); + case DTspec: + return(rmx_load_spec(rm, fp)); + default: + fputs("Unsupported data type in rmx_loaddata()\n", stderr); + } + return(0); +} + /* Load matrix from supported file type */ RMATRIX * -rmx_load(const char *inspec) +rmx_load(const char *inspec, RMPref rmp) { - FILE *fp = stdin; - RMATRIX dinfo; + FILE *fp; RMATRIX *dnew; + int ok; - if (!inspec) { /* reading from stdin? */ - inspec = ""; - SET_FILE_BINARY(stdin); - } else if (inspec[0] == '!') { - if (!(fp = popen(inspec+1, "r"))) - return(NULL); - SET_FILE_BINARY(fp); - } else { + if (!inspec) + inspec = stdin_name; + else if (!*inspec) + return(NULL); + if (inspec == stdin_name) /* reading from stdin? */ + fp = stdin; + else if (inspec[0] == '!') + fp = popen(inspec+1, "r"); + else { const char *sp = inspec; /* check suffix */ while (*sp) ++sp; while (sp > inspec && sp[-1] != '.') --sp; if (!strcasecmp(sp, "XML")) { /* assume it's a BSDF */ - CMATRIX *cm = cm_loadBTDF((char *)inspec); + CMATRIX *cm = rmp==RMPtrans ? cm_loadBTDF(inspec) : + cm_loadBRDF(inspec, rmp==RMPreflB) ; if (!cm) return(NULL); dnew = rmx_from_cmatrix(cm); cm_free(cm); dnew->dtype = DTascii; - return(dnew); - } - /* else open it ourselves */ - if (!(fp = fopen(inspec, "rb"))) - return(NULL); + return(dnew); /* return here */ + } /* else open it ourselves */ + fp = fopen(inspec, "r"); } + if (!fp) + return(NULL); #ifdef getc_unlocked flockfile(fp); #endif - dinfo.nrows = dinfo.ncols = dinfo.ncomp = 0; - dinfo.dtype = DTascii; /* assumed w/o FORMAT */ - dinfo.swapin = 0; - dinfo.info = NULL; - dinfo.mtx[0] = dinfo.mtx[1] = dinfo.mtx[2] = 1.; - if (getheader(fp, get_dminfo, &dinfo) < 0) { - fclose(fp); + /* load header info */ + if (rmx_load_header(dnew = rmx_new(0,0,3), fp) < 0) { + fprintf(stderr, "Bad header in: %s\n", inspec); + if (inspec[0] == '!') pclose(fp); + else fclose(fp); + rmx_free(dnew); return(NULL); } - if ((dinfo.nrows <= 0) | (dinfo.ncols <= 0)) { - if (!fscnresolu(&dinfo.ncols, &dinfo.nrows, fp)) { - fclose(fp); - return(NULL); - } - if (dinfo.ncomp <= 0) - dinfo.ncomp = 3; - else if ((dinfo.dtype == DTrgbe) | (dinfo.dtype == DTxyze) && - dinfo.ncomp != 3) { - fclose(fp); - return(NULL); - } - } - dnew = rmx_alloc(dinfo.nrows, dinfo.ncols, dinfo.ncomp); - if (!dnew) { - fclose(fp); - return(NULL); - } - dnew->info = dinfo.info; - switch (dinfo.dtype) { - case DTascii: - SET_FILE_TEXT(fp); - if (!rmx_load_ascii(dnew, fp)) - goto loaderr; - dnew->dtype = DTascii; /* should leave double? */ - break; - case DTfloat: - dnew->swapin = dinfo.swapin; - if (!rmx_load_float(dnew, fp)) - goto loaderr; - dnew->dtype = DTfloat; - break; - case DTdouble: - dnew->swapin = dinfo.swapin; - if (!rmx_load_double(dnew, fp)) - goto loaderr; - dnew->dtype = DTdouble; - break; - case DTrgbe: - case DTxyze: - if (!rmx_load_rgbe(dnew, fp)) - goto loaderr; - dnew->dtype = dinfo.dtype; /* undo exposure? */ - if ((dinfo.mtx[0] != 1.) | (dinfo.mtx[1] != 1.) | - (dinfo.mtx[2] != 1.)) { - dinfo.mtx[0] = 1./dinfo.mtx[0]; - dinfo.mtx[1] = 1./dinfo.mtx[1]; - dinfo.mtx[2] = 1./dinfo.mtx[2]; - rmx_scale(dnew, dinfo.mtx); - } - break; - default: - goto loaderr; - } - if (fp != stdin) { + ok = rmx_load_data(dnew, fp); /* allocate & load data */ + + if (fp != stdin) { /* close input stream */ if (inspec[0] == '!') pclose(fp); else @@ -311,28 +427,46 @@ rmx_load(const char *inspec) else funlockfile(fp); #endif + if (!ok) { /* load failure? */ + fprintf(stderr, "Error loading data from: %s\n", inspec); + rmx_free(dnew); + return(NULL); + } + /* undo exposure? */ + if ((dnew->cexp[0] != 1.f) | + (dnew->cexp[1] != 1.f) | (dnew->cexp[2] != 1.f)) { + double cmlt[MAXCSAMP]; + int i; + cmlt[0] = 1./dnew->cexp[0]; + cmlt[1] = 1./dnew->cexp[1]; + cmlt[2] = 1./dnew->cexp[2]; + if (dnew->ncomp > MAXCSAMP) { + fprintf(stderr, "Excess spectral components in: %s\n", + inspec); + rmx_free(dnew); + return(NULL); + } + for (i = dnew->ncomp; i-- > 3; ) + cmlt[i] = cmlt[1]; + rmx_scale(dnew, cmlt); + setcolor(dnew->cexp, 1.f, 1.f, 1.f); + } return(dnew); -loaderr: /* should report error? */ - if (inspec[0] == '!') - pclose(fp); - else - fclose(fp); - rmx_free(dnew); - return(NULL); } static int rmx_write_ascii(const RMATRIX *rm, FILE *fp) { const char *fmt = (rm->dtype == DTfloat) ? " %.7e" : - (rm->dtype == DTrgbe) | (rm->dtype == DTxyze) ? " %.3e" : - " %.15e" ; + (rm->dtype == DTrgbe) | (rm->dtype == DTxyze) | + (rm->dtype == DTspec) ? " %.3e" : " %.15e" ; int i, j, k; for (i = 0; i < rm->nrows; i++) { for (j = 0; j < rm->ncols; j++) { + const double *dp = rmx_val(rm,i,j); for (k = 0; k < rm->ncomp; k++) - fprintf(fp, fmt, rmx_lval(rm,i,j,k)); + fprintf(fp, fmt, dp[k]); fputc('\t', fp); } fputc('\n', fp); @@ -352,9 +486,10 @@ rmx_write_float(const RMATRIX *rm, FILE *fp) } for (i = 0; i < rm->nrows; i++) for (j = 0; j < rm->ncols; j++) { + const double *dp = rmx_val(rm,i,j); for (k = rm->ncomp; k--; ) - val[k] = (float)rmx_lval(rm,i,j,k); - if (putbinary(val, sizeof(val[0]), rm->ncomp, fp) != rm->ncomp) + val[k] = (float)dp[k]; + if (putbinary(val, sizeof(float), rm->ncomp, fp) != rm->ncomp) return(0); } return(1); @@ -363,11 +498,11 @@ rmx_write_float(const RMATRIX *rm, FILE *fp) static int rmx_write_double(const RMATRIX *rm, FILE *fp) { - int i, j; + int i; for (i = 0; i < rm->nrows; i++) - for (j = 0; j < rm->ncols; j++) - if (putbinary(&rmx_lval(rm,i,j,0), sizeof(double), rm->ncomp, fp) != rm->ncomp) + if (putbinary(rmx_val(rm,i,0), sizeof(double)*rm->ncomp, + rm->ncols, fp) != rm->ncols) return(0); return(1); } @@ -381,10 +516,13 @@ rmx_write_rgbe(const RMATRIX *rm, FILE *fp) if (!scan) return(0); for (i = 0; i < rm->nrows; i++) { - for (j = rm->ncols; j--; ) - setcolr(scan[j], rmx_lval(rm,i,j,0), - rmx_lval(rm,i,j,1), - rmx_lval(rm,i,j,2) ); + for (j = rm->ncols; j--; ) { + const double *dp = rmx_val(rm,i,j); + if (rm->ncomp == 1) + setcolr(scan[j], dp[0], dp[0], dp[0]); + else + setcolr(scan[j], dp[0], dp[1], dp[2]); + } if (fwritecolrs(scan, rm->ncols, fp) < 0) { free(scan); return(0); @@ -394,14 +532,56 @@ rmx_write_rgbe(const RMATRIX *rm, FILE *fp) return(1); } +static int +rmx_write_spec(const RMATRIX *rm, FILE *fp) +{ + uby8 *scan = (uby8 *)malloc((rm->ncomp+1)*rm->ncols); + int ok = 1; + SCOLOR scol; + int i, j, k; + + if (!scan) + return(0); + for (i = 0; i < rm->nrows; i++) { + for (j = rm->ncols; j--; ) { + const double *dp = rmx_val(rm,i,j); + for (k = rm->ncomp; k--; ) + scol[k] = dp[k]; + scolor2scolr(scan+j*(rm->ncomp+1), scol, rm->ncomp); + } + if (fwritescolrs(scan, rm->ncomp, rm->ncols, fp) < 0) { + ok = 0; + break; + } + } + free(scan); + return(ok); +} + +/* Check if CIE XYZ primaries were specified */ +static int +findCIEprims(const char *info) +{ + RGBPRIMS prims; + + if (!info) + return(0); + info = strstr(info, PRIMARYSTR); + if (!info || !primsval(prims, info)) + return(0); + + return((prims[RED][CIEX] > .99) & (prims[RED][CIEY] < .01) && + (prims[GRN][CIEX] < .01) & (prims[GRN][CIEY] > .99) && + (prims[BLU][CIEX] < .01) & (prims[BLU][CIEY] < .01)); +} + /* Write matrix to file type indicated by dtype */ int rmx_write(const RMATRIX *rm, int dtype, FILE *fp) { - RMATRIX *mydm = NULL; int ok = 1; - if (!rm | !fp) + if (!rm | !fp || !rm->mtx) return(0); #ifdef getc_unlocked flockfile(fp); @@ -411,27 +591,32 @@ rmx_write(const RMATRIX *rm, int dtype, FILE *fp) fputs(rm->info, fp); if (dtype == DTfromHeader) dtype = rm->dtype; - else if ((dtype == DTrgbe) & (rm->dtype == DTxyze)) + else if (dtype == DTrgbe && (rm->dtype == DTxyze || + findCIEprims(rm->info))) dtype = DTxyze; else if ((dtype == DTxyze) & (rm->dtype == DTrgbe)) dtype = DTrgbe; + /* write exposure? */ + if (rm->ncomp == 3 && (rm->cexp[RED] != rm->cexp[GRN]) | + (rm->cexp[GRN] != rm->cexp[BLU])) + fputcolcor(rm->cexp, fp); + else if (rm->cexp[GRN] != 1.f) + fputexpos(rm->cexp[GRN], fp); if ((dtype != DTrgbe) & (dtype != DTxyze)) { - fprintf(fp, "NROWS=%d\n", rm->nrows); - fprintf(fp, "NCOLS=%d\n", rm->ncols); - fprintf(fp, "NCOMP=%d\n", rm->ncomp); - } else if (rm->ncomp != 3) { /* wrong # components? */ - double cmtx[3]; - if (rm->ncomp != 1) /* only convert grayscale */ - return(0); - cmtx[0] = cmtx[1] = cmtx[2] = 1; - mydm = rmx_transform(rm, 3, cmtx); - if (!mydm) - return(0); - rm = mydm; - } + if (dtype == DTspec) { + if (rm->ncomp < 3) + return(0); /* bad # components */ + fputwlsplit(rm->wlpart, fp); + } else { + fprintf(fp, "NROWS=%d\n", rm->nrows); + fprintf(fp, "NCOLS=%d\n", rm->ncols); + } + fputncomp(rm->ncomp, fp); + } else if ((rm->ncomp != 3) & (rm->ncomp != 1)) + return(0); /* wrong # components */ if ((dtype == DTfloat) | (dtype == DTdouble)) fputendian(fp); /* important to record */ - fputformat((char *)cm_fmt_id[dtype], fp); + fputformat(cm_fmt_id[dtype], fp); fputc('\n', fp); switch (dtype) { /* write data */ case DTascii: @@ -448,6 +633,10 @@ rmx_write(const RMATRIX *rm, int dtype, FILE *fp) fprtresolu(rm->ncols, rm->nrows, fp); ok = rmx_write_rgbe(rm, fp); break; + case DTspec: + fprtresolu(rm->ncols, rm->nrows, fp); + ok = rmx_write_spec(rm, fp); + break; default: return(0); } @@ -455,8 +644,7 @@ rmx_write(const RMATRIX *rm, int dtype, FILE *fp) #ifdef getc_unlocked funlockfile(fp); #endif - if (mydm) - rmx_free(mydm); + if (!ok) fputs("Error writing matrix\n", stderr); return(ok); } @@ -469,10 +657,12 @@ rmx_identity(const int dim, const int n) if (!rid) return(NULL); - memset(rid->mtx, 0, sizeof(rid->mtx[0])*n*dim*dim); - for (i = dim; i--; ) + memset(rid->mtx, 0, array_size(rid)); + for (i = dim; i--; ) { + double *dp = rmx_lval(rid,i,i); for (k = n; k--; ) - rmx_lval(rid,i,i,k) = 1; + dp[k] = 1.; + } return(rid); } @@ -489,8 +679,9 @@ rmx_copy(const RMATRIX *rm) return(NULL); rmx_addinfo(dnew, rm->info); dnew->dtype = rm->dtype; - memcpy(dnew->mtx, rm->mtx, - sizeof(rm->mtx[0])*rm->ncomp*rm->nrows*rm->ncols); + copycolor(dnew->cexp, rm->cexp); + memcpy(dnew->wlpart, rm->wlpart, sizeof(dnew->wlpart)); + memcpy(dnew->mtx, rm->mtx, array_size(dnew)); return(dnew); } @@ -499,7 +690,7 @@ RMATRIX * rmx_transpose(const RMATRIX *rm) { RMATRIX *dnew; - int i, j, k; + int i, j; if (!rm) return(0); @@ -519,10 +710,12 @@ rmx_transpose(const RMATRIX *rm) rmx_addinfo(dnew, "Transposed rows and columns\n"); } dnew->dtype = rm->dtype; - for (i = dnew->nrows; i--; ) - for (j = dnew->ncols; j--; ) - for (k = dnew->ncomp; k--; ) - rmx_lval(dnew,i,j,k) = rmx_lval(rm,j,i,k); + copycolor(dnew->cexp, rm->cexp); + memcpy(dnew->wlpart, rm->wlpart, sizeof(dnew->wlpart)); + for (j = dnew->ncols; j--; ) + for (i = dnew->nrows; i--; ) + memcpy(rmx_lval(dnew,i,j), rmx_val(rm,j,i), + sizeof(double)*dnew->ncomp); return(dnew); } @@ -546,10 +739,10 @@ rmx_multiply(const RMATRIX *m1, const RMATRIX *m2) for (i = mres->nrows; i--; ) for (j = mres->ncols; j--; ) for (k = mres->ncomp; k--; ) { - long double d = 0; + double d = 0; for (h = m1->ncols; h--; ) - d += rmx_lval(m1,i,h,k) * rmx_lval(m2,h,j,k); - rmx_lval(mres,i,j,k) = (double)d; + d += rmx_val(m1,i,h)[k] * rmx_val(m2,h,j)[k]; + rmx_lval(mres,i,j)[k] = d; } return(mres); } @@ -575,33 +768,33 @@ rmx_elemult(RMATRIX *m1, const RMATRIX *m2, int divide if (divide) { double d; if (m2->ncomp == 1) { - d = rmx_lval(m2,i,j,0); + d = rmx_val(m2,i,j)[0]; if (d == 0) { ++zeroDivides; for (k = m1->ncomp; k--; ) - rmx_lval(m1,i,j,k) = 0; + rmx_lval(m1,i,j)[k] = 0; } else { d = 1./d; for (k = m1->ncomp; k--; ) - rmx_lval(m1,i,j,k) *= d; + rmx_lval(m1,i,j)[k] *= d; } } else for (k = m1->ncomp; k--; ) { - d = rmx_lval(m2,i,j,k); + d = rmx_val(m2,i,j)[k]; if (d == 0) { ++zeroDivides; - rmx_lval(m1,i,j,k) = 0; + rmx_lval(m1,i,j)[k] = 0; } else - rmx_lval(m1,i,j,k) /= d; + rmx_lval(m1,i,j)[k] /= d; } } else { if (m2->ncomp == 1) { - const double d = rmx_lval(m2,i,j,0); + const double d = rmx_val(m2,i,j)[0]; for (k = m1->ncomp; k--; ) - rmx_lval(m1,i,j,k) *= d; + rmx_lval(m1,i,j)[k] *= d; } else for (k = m1->ncomp; k--; ) - rmx_lval(m1,i,j,k) *= rmx_lval(m2,i,j,k); + rmx_lval(m1,i,j)[k] *= rmx_val(m2,i,j)[k]; } if (zeroDivides) { rmx_addinfo(m1, "WARNING: zero divide(s) corrupted results\n"); @@ -636,9 +829,12 @@ rmx_sum(RMATRIX *msum, const RMATRIX *madd, const doub else rmx_addinfo(msum, rmx_mismatch_warn); for (i = msum->nrows; i--; ) - for (j = msum->ncols; j--; ) + for (j = msum->ncols; j--; ) { + const double *da = rmx_val(madd,i,j); + double *ds = rmx_lval(msum,i,j); for (k = msum->ncomp; k--; ) - rmx_lval(msum,i,j,k) += sf[k] * rmx_lval(madd,i,j,k); + ds[k] += sf[k] * da[k]; + } if (mysf) free(mysf); return(1); @@ -653,12 +849,14 @@ rmx_scale(RMATRIX *rm, const double sf[]) if (!rm | !sf) return(0); for (i = rm->nrows; i--; ) - for (j = rm->ncols; j--; ) + for (j = rm->ncols; j--; ) { + double *dp = rmx_lval(rm,i,j); for (k = rm->ncomp; k--; ) - rmx_lval(rm,i,j,k) *= sf[k]; - + dp[k] *= sf[k]; + } if (rm->info) rmx_addinfo(rm, "Applied scalar\n"); + /* XXX: should record as exposure for COLR and SCOLR types? */ return(1); } @@ -683,13 +881,15 @@ rmx_transform(const RMATRIX *msrc, int n, const double } dnew->dtype = msrc->dtype; for (i = dnew->nrows; i--; ) - for (j = dnew->ncols; j--; ) + for (j = dnew->ncols; j--; ) { + const double *ds = rmx_val(msrc,i,j); for (kd = dnew->ncomp; kd--; ) { double d = 0; for (ks = msrc->ncomp; ks--; ) - d += cmat[kd*msrc->ncomp + ks] * rmx_lval(msrc,i,j,ks); - rmx_lval(dnew,i,j,kd) = d; + d += cmat[kd*msrc->ncomp + ks] * ds[ks]; + rmx_lval(dnew,i,j)[kd] = d; } + } return(dnew); } @@ -709,9 +909,10 @@ rmx_from_cmatrix(const CMATRIX *cm) for (i = dnew->nrows; i--; ) for (j = dnew->ncols; j--; ) { const COLORV *cv = cm_lval(cm,i,j); - rmx_lval(dnew,i,j,0) = cv[0]; - rmx_lval(dnew,i,j,1) = cv[1]; - rmx_lval(dnew,i,j,2) = cv[2]; + double *dp = rmx_lval(dnew,i,j); + dp[0] = cv[0]; + dp[1] = cv[1]; + dp[2] = cv[2]; } return(dnew); } @@ -723,17 +924,30 @@ cm_from_rmatrix(const RMATRIX *rm) int i, j; CMATRIX *cnew; - if (!rm || rm->ncomp != 3) + if (!rm || !rm->mtx | (rm->ncomp == 2)) return(NULL); cnew = cm_alloc(rm->nrows, rm->ncols); if (!cnew) return(NULL); for (i = cnew->nrows; i--; ) for (j = cnew->ncols; j--; ) { - COLORV *cv = cm_lval(cnew,i,j); - cv[0] = (COLORV)rmx_lval(rm,i,j,0); - cv[1] = (COLORV)rmx_lval(rm,i,j,1); - cv[2] = (COLORV)rmx_lval(rm,i,j,2); + const double *dp = rmx_val(rm,i,j); + COLORV *cv = cm_lval(cnew,i,j); + switch (rm->ncomp) { + case 3: + setcolor(cv, dp[0], dp[1], dp[2]); + break; + case 1: + setcolor(cv, dp[0], dp[0], dp[0]); + break; + default: { + SCOLOR scol; + int k; + for (k = rm->ncomp; k--; ) + scol[k] = dp[k]; + scolor2color(cv, scol, rm->ncomp, rm->wlpart); + } break; + } } return(cnew); }