--- ray/src/util/rmatrix.c	2019/08/14 18:20:02	2.35
+++ ray/src/util/rmatrix.c	2022/03/11 01:11:13	2.56
@@ -1,38 +1,62 @@
 #ifndef lint
-static const char RCSid[] = "$Id: rmatrix.c,v 2.35 2019/08/14 18:20:02 greg Exp $";
+static const char RCSid[] = "$Id: rmatrix.c,v 2.56 2022/03/11 01:11:13 greg Exp $";
 #endif
 /*
  * General matrix operations.
  */
 
-#include <stdio.h>
 #include <stdlib.h>
-#include <string.h>
-#include <fcntl.h>
 #include <errno.h>
 #include "rtio.h"
 #include "platform.h"
 #include "resolu.h"
 #include "paths.h"
 #include "rmatrix.h"
+#if !defined(_WIN32) && !defined(_WIN64)
+#include <sys/mman.h>
+#endif
 
 static char	rmx_mismatch_warn[] = "WARNING: data type mismatch\n";
 
-/* Allocate a nr x nc matrix with n components */
+#define array_size(rm)	(sizeof(double)*(rm)->nrows*(rm)->ncols*(rm)->ncomp)
+#define mapped_size(rm)	((char *)(rm)->mtx + array_size(rm) - (char *)(rm)->mapped)
+
+/* Initialize a RMATRIX struct but don't allocate array space */
 RMATRIX *
+rmx_new(int nr, int nc, int n)
+{
+	RMATRIX	*dnew = (RMATRIX *)calloc(1, sizeof(RMATRIX));
+
+	if (dnew) {
+		dnew->dtype = DTdouble;
+		dnew->nrows = nr;
+		dnew->ncols = nc;
+		dnew->ncomp = n;
+	}
+	return(dnew);
+}
+
+/* Prepare a RMATRIX for writing (allocate array if needed) */
+int
+rmx_prepare(RMATRIX *rm)
+{
+	if (!rm) return(0);
+	if (rm->mtx)
+		return(1);
+	rm->mtx = (double *)malloc(array_size(rm));
+	return(rm->mtx != NULL);
+}
+
+/* Call rmx_new() and rmx_prepare() */
+RMATRIX	*
 rmx_alloc(int nr, int nc, int n)
 {
-	RMATRIX	*dnew;
+	RMATRIX	*dnew = rmx_new(nr, nc, n);
 
-	if ((nr <= 0) | (nc <= 0) | (n <= 0))
-		return(NULL);
-	dnew = (RMATRIX *)malloc(sizeof(RMATRIX)-sizeof(dnew->mtx) +
-					sizeof(dnew->mtx[0])*(n*nr*nc));
-	if (!dnew)
-		return(NULL);
-	dnew->nrows = nr; dnew->ncols = nc; dnew->ncomp = n;
-	dnew->dtype = DTdouble;
-	dnew->info = NULL;
+	if (dnew && !rmx_prepare(dnew)) {
+		rmx_free(dnew);
+		dnew = NULL;
+	}
 	return(dnew);
 }
 
@@ -43,6 +67,12 @@ rmx_free(RMATRIX *rm)
 	if (!rm) return;
 	if (rm->info)
 		free(rm->info);
+#ifdef MAP_FILE
+	if (rm->mapped)
+		munmap(rm->mapped, mapped_size(rm));
+	else
+#endif
+		free(rm->mtx);
 	free(rm);
 }
 
@@ -63,17 +93,21 @@ rmx_newtype(int dtyp1, int dtyp2)
 int
 rmx_addinfo(RMATRIX *rm, const char *info)
 {
+	int	oldlen = 0;
+
 	if (!rm || !info || !*info)
 		return(0);
 	if (!rm->info) {
 		rm->info = (char *)malloc(strlen(info)+1);
 		if (rm->info) rm->info[0] = '\0';
-	} else
+	} else {
+		oldlen = strlen(rm->info);
 		rm->info = (char *)realloc(rm->info,
-				strlen(rm->info)+strlen(info)+1);
+				oldlen+strlen(info)+1);
+	}
 	if (!rm->info)
 		return(0);
-	strcat(rm->info, info);
+	strcpy(rm->info+oldlen, info);
 	return(1);
 }
 
@@ -102,10 +136,21 @@ get_dminfo(char *s, void *p)
 		ip->swapin = (nativebigendian() != i);
 		return(0);
 	}
+	if (isexpos(s)) {
+		float	f = exposval(s);
+		scalecolor(ip->cexp, f);
+		return(0);
+	}
+	if (iscolcor(s)) {
+		COLOR	ctmp;
+		colcorval(ctmp, s);
+		multcolor(ip->cexp, ctmp);
+		return(0);
+	}
 	if (!formatval(fmt, s)) {
 		rmx_addinfo(ip, s);
 		return(0);
-	}
+	}			/* else check format */
 	for (i = 1; i < DTend; i++)
 		if (!strcmp(fmt, cm_fmt_id[i])) {
 			ip->dtype = i;
@@ -119,11 +164,15 @@ rmx_load_ascii(RMATRIX *rm, FILE *fp)
 {
 	int	i, j, k;
 
+	if (!rmx_prepare(rm))
+		return(0);
 	for (i = 0; i < rm->nrows; i++)
-	    for (j = 0; j < rm->ncols; j++)
+	    for (j = 0; j < rm->ncols; j++) {
+	    	double	*dp = rmx_lval(rm,i,j);
 	        for (k = 0; k < rm->ncomp; k++)
-		    if (fscanf(fp, "%lf", &rmx_lval(rm,i,j,k)) != 1)
+		    if (fscanf(fp, "%lf", &dp[k]) != 1)
 			return(0);
+	    }
 	return(1);
 }
 
@@ -137,14 +186,17 @@ rmx_load_float(RMATRIX *rm, FILE *fp)
 		fputs("Unsupported # components in rmx_load_float()\n", stderr);
 		exit(1);
 	}
+	if (!rmx_prepare(rm))
+		return(0);
 	for (i = 0; i < rm->nrows; i++)
 	    for (j = 0; j < rm->ncols; j++) {
+	    	double	*dp = rmx_lval(rm,i,j);
 		if (getbinary(val, sizeof(val[0]), rm->ncomp, fp) != rm->ncomp)
 		    return(0);
 		if (rm->swapin)
 		    swap32((char *)val, rm->ncomp);
 	        for (k = rm->ncomp; k--; )
-		     rmx_lval(rm,i,j,k) = val[k];
+		     dp[k] = val[k];
 	    }
 	return(1);
 }
@@ -152,15 +204,29 @@ rmx_load_float(RMATRIX *rm, FILE *fp)
 static int
 rmx_load_double(RMATRIX *rm, FILE *fp)
 {
-	int	i, j;
-
-	for (i = 0; i < rm->nrows; i++)
-	    for (j = 0; j < rm->ncols; j++) {
-		if (getbinary(&rmx_lval(rm,i,j,0), sizeof(double), rm->ncomp, fp) != rm->ncomp)
-		    return(0);
+	int	i;
+#ifdef MAP_FILE
+	long	pos;		/* map memory for file > 1MB if possible */
+	if (!rm->swapin && array_size(rm) >= 1L<<20 &&
+			(pos = ftell(fp)) >= 0 && !(pos % sizeof(double))) {
+		rm->mapped = mmap(NULL, array_size(rm)+pos, PROT_READ|PROT_WRITE,
+					MAP_PRIVATE, fileno(fp), 0);
+		if (rm->mapped != MAP_FAILED) {
+			rm->mtx = (double *)rm->mapped + pos/sizeof(double);
+			return(1);
+		}		/* else fall back on reading into memory */
+		rm->mapped = NULL;
+	}
+#endif
+	if (!rmx_prepare(rm))
+		return(0);
+	for (i = 0; i < rm->nrows; i++) {
+		if (getbinary(rmx_lval(rm,i,0), sizeof(double)*rm->ncomp,
+					rm->ncols, fp) != rm->ncols)
+			return(0);
 		if (rm->swapin)
-		    swap64((char *)&rmx_lval(rm,i,j,0), rm->ncomp);
-	    }
+			swap64((char *)rmx_lval(rm,i,0), rm->ncols*rm->ncomp);
+	}
 	return(1);
 }
 
@@ -172,15 +238,18 @@ rmx_load_rgbe(RMATRIX *rm, FILE *fp)
 
 	if (!scan)
 		return(0);
+	if (!rmx_prepare(rm))
+		return(0);
 	for (i = 0; i < rm->nrows; i++) {
+	    double	*dp = rmx_lval(rm,i,j);
 	    if (freadscan(scan, rm->ncols, fp) < 0) {
 		free(scan);
 		return(0);
 	    }
-	    for (j = rm->ncols; j--; ) {
-	        rmx_lval(rm,i,j,0) = colval(scan[j],RED);
-	        rmx_lval(rm,i,j,1) = colval(scan[j],GRN);
-	        rmx_lval(rm,i,j,2) = colval(scan[j],BLU);
+	    for (j = 0; j < rm->ncols; j++, dp += 3) {
+	        dp[0] = colval(scan[j],RED);
+	        dp[1] = colval(scan[j],GRN);
+	        dp[2] = colval(scan[j],BLU);
 	    }
 	}
 	free(scan);
@@ -189,19 +258,20 @@ rmx_load_rgbe(RMATRIX *rm, FILE *fp)
 
 /* Load matrix from supported file type */
 RMATRIX *
-rmx_load(const char *inspec)
+rmx_load(const char *inspec, RMPref rmp)
 {
-	FILE		*fp = stdin;
-	RMATRIX		dinfo;
+	FILE		*fp;
 	RMATRIX		*dnew;
 
-	if (!inspec) {				/* reading from stdin? */
-		inspec = "<stdin>";
-		SET_FILE_BINARY(stdin);
+	if (!inspec)
+		inspec = stdin_name;
+	else if (!*inspec)
+		return(NULL);
+	if (inspec == stdin_name) {		/* reading from stdin? */
+		fp = stdin;
 	} else if (inspec[0] == '!') {
 		if (!(fp = popen(inspec+1, "r")))
 			return(NULL);
-		SET_FILE_BINARY(stdin);
 	} else {
 		const char	*sp = inspec;	/* check suffix */
 		while (*sp)
@@ -209,7 +279,8 @@ rmx_load(const char *inspec)
 		while (sp > inspec && sp[-1] != '.')
 			--sp;
 		if (!strcasecmp(sp, "XML")) {	/* assume it's a BSDF */
-			CMATRIX	*cm = cm_loadBTDF((char *)inspec);
+			CMATRIX	*cm = rmp==RMPtrans ? cm_loadBTDF(inspec) :
+					cm_loadBRDF(inspec, rmp==RMPreflB) ;
 			if (!cm)
 				return(NULL);
 			dnew = rmx_from_cmatrix(cm);
@@ -218,54 +289,47 @@ rmx_load(const char *inspec)
 			return(dnew);
 		}
 						/* else open it ourselves */
-		if (!(fp = fopen(inspec, "rb")))
+		if (!(fp = fopen(inspec, "r")))
 			return(NULL);
 	}
+	SET_FILE_BINARY(fp);
 #ifdef getc_unlocked
 	flockfile(fp);
 #endif
-	dinfo.nrows = dinfo.ncols = dinfo.ncomp = 0;
-	dinfo.dtype = DTascii;			/* assumed w/o FORMAT */
-	dinfo.swapin = 0;
-	dinfo.info = NULL;
-	if (getheader(fp, get_dminfo, &dinfo) < 0) {
+	if (!(dnew = rmx_new(0,0,3))) {
 		fclose(fp);
 		return(NULL);
 	}
-	if ((dinfo.nrows <= 0) | (dinfo.ncols <= 0)) {
-		if (!fscnresolu(&dinfo.ncols, &dinfo.nrows, fp)) {
+	dnew->dtype = DTascii;			/* assumed w/o FORMAT */
+	dnew->cexp[0] = dnew->cexp[1] = dnew->cexp[2] = 1.f;
+	if (getheader(fp, get_dminfo, dnew) < 0) {
+		fclose(fp);
+		return(NULL);
+	}
+	if ((dnew->nrows <= 0) | (dnew->ncols <= 0)) {
+		if (!fscnresolu(&dnew->ncols, &dnew->nrows, fp)) {
 			fclose(fp);
 			return(NULL);
 		}
-		if (dinfo.ncomp <= 0)
-			dinfo.ncomp = 3;
-		else if ((dinfo.dtype == DTrgbe) | (dinfo.dtype == DTxyze) &&
-				dinfo.ncomp != 3) {
+		if ((dnew->dtype == DTrgbe) | (dnew->dtype == DTxyze) &&
+				dnew->ncomp != 3) {
 			fclose(fp);
 			return(NULL);
 		}
 	}
-	dnew = rmx_alloc(dinfo.nrows, dinfo.ncols, dinfo.ncomp);
-	if (!dnew) {
-		fclose(fp);
-		return(NULL);
-	}
-	dnew->info = dinfo.info;
-	switch (dinfo.dtype) {
+	switch (dnew->dtype) {
 	case DTascii:
-		SET_FILE_TEXT(stdin);
+		SET_FILE_TEXT(fp);
 		if (!rmx_load_ascii(dnew, fp))
 			goto loaderr;
 		dnew->dtype = DTascii;		/* should leave double? */
 		break;
 	case DTfloat:
-		dnew->swapin = dinfo.swapin;
 		if (!rmx_load_float(dnew, fp))
 			goto loaderr;
 		dnew->dtype = DTfloat;
 		break;
 	case DTdouble:
-		dnew->swapin = dinfo.swapin;
 		if (!rmx_load_double(dnew, fp))
 			goto loaderr;
 		dnew->dtype = DTdouble;
@@ -274,7 +338,16 @@ rmx_load(const char *inspec)
 	case DTxyze:
 		if (!rmx_load_rgbe(dnew, fp))
 			goto loaderr;
-		dnew->dtype = dinfo.dtype;
+						/* undo exposure? */
+		if ((dnew->cexp[0] != 1.f) | (dnew->cexp[1] != 1.f) |
+				(dnew->cexp[2] != 1.f)) {
+			double	cmlt[3];
+			cmlt[0] = 1./dnew->cexp[0];
+			cmlt[1] = 1./dnew->cexp[1];
+			cmlt[2] = 1./dnew->cexp[2];
+			rmx_scale(dnew, cmlt);
+		}
+		dnew->swapin = 0;
 		break;
 	default:
 		goto loaderr;
@@ -309,8 +382,9 @@ rmx_write_ascii(const RMATRIX *rm, FILE *fp)
 
 	for (i = 0; i < rm->nrows; i++) {
 	    for (j = 0; j < rm->ncols; j++) {
+		const double	*dp = rmx_lval(rm,i,j);
 	        for (k = 0; k < rm->ncomp; k++)
-		    fprintf(fp, fmt, rmx_lval(rm,i,j,k));
+		    fprintf(fp, fmt, dp[k]);
 		fputc('\t', fp);
 	    }
 	    fputc('\n', fp);
@@ -330,9 +404,10 @@ rmx_write_float(const RMATRIX *rm, FILE *fp)
 	}
 	for (i = 0; i < rm->nrows; i++)
 	    for (j = 0; j < rm->ncols; j++) {
+	    	const double	*dp = rmx_lval(rm,i,j);
 	        for (k = rm->ncomp; k--; )
-		    val[k] = (float)rmx_lval(rm,i,j,k);
-		if (putbinary(val, sizeof(val[0]), rm->ncomp, fp) != rm->ncomp)
+		    val[k] = (float)dp[k];
+		if (putbinary(val, sizeof(float), rm->ncomp, fp) != rm->ncomp)
 			return(0);
 	    }
 	return(1);
@@ -341,11 +416,11 @@ rmx_write_float(const RMATRIX *rm, FILE *fp)
 static int
 rmx_write_double(const RMATRIX *rm, FILE *fp)
 {
-	int	i, j;
+	int	i;
 
 	for (i = 0; i < rm->nrows; i++)
-	    for (j = 0; j < rm->ncols; j++)
-		if (putbinary(&rmx_lval(rm,i,j,0), sizeof(double), rm->ncomp, fp) != rm->ncomp)
+		if (putbinary(rmx_lval(rm,i,0), sizeof(double)*rm->ncomp,
+					rm->ncols, fp) != rm->ncols)
 			return(0);
 	return(1);
 }
@@ -359,10 +434,13 @@ rmx_write_rgbe(const RMATRIX *rm, FILE *fp)
 	if (!scan)
 		return(0);
 	for (i = 0; i < rm->nrows; i++) {
-	    for (j = rm->ncols; j--; )
-	        setcolr(scan[j],	rmx_lval(rm,i,j,0),
-					rmx_lval(rm,i,j,1),
-					rmx_lval(rm,i,j,2)	);
+	    for (j = rm->ncols; j--; ) {
+	    	const double	*dp = rmx_lval(rm,i,j);
+	    	if (rm->ncomp == 1)
+	    		setcolr(scan[j], dp[0], dp[0], dp[0]);
+	    	else
+	        	setcolr(scan[j], dp[0], dp[1], dp[2]);
+	    }
 	    if (fwritecolrs(scan, rm->ncols, fp) < 0) {
 		free(scan);
 		return(0);
@@ -372,14 +450,30 @@ rmx_write_rgbe(const RMATRIX *rm, FILE *fp)
 	return(1);
 }
 
+/* Check if CIE XYZ primaries were specified */
+static int
+findCIEprims(const char *info)
+{
+	RGBPRIMS	prims;
+
+	if (!info)
+		return(0);
+	info = strstr(info, PRIMARYSTR);
+	if (!info || !primsval(prims, info))
+		return(0);
+
+	return((prims[RED][CIEX] > .99) & (prims[RED][CIEY] < .01) &&
+			(prims[GRN][CIEX] < .01) & (prims[GRN][CIEY] > .99) &&
+			(prims[BLU][CIEX] < .01) & (prims[BLU][CIEY] < .01));
+}
+
 /* Write matrix to file type indicated by dtype */
 int
 rmx_write(const RMATRIX *rm, int dtype, FILE *fp)
 {
-	RMATRIX	*mydm = NULL;
 	int	ok = 1;
 
-	if (!rm | !fp)
+	if (!rm | !fp || !rm->mtx)
 		return(0);
 #ifdef getc_unlocked
 	flockfile(fp);
@@ -389,7 +483,8 @@ rmx_write(const RMATRIX *rm, int dtype, FILE *fp)
 		fputs(rm->info, fp);
 	if (dtype == DTfromHeader)
 		dtype = rm->dtype;
-	else if ((dtype == DTrgbe) & (rm->dtype == DTxyze))
+	else if (dtype == DTrgbe && (rm->dtype == DTxyze ||
+					findCIEprims(rm->info)))
 		dtype = DTxyze;
 	else if ((dtype == DTxyze) & (rm->dtype == DTrgbe))
 		dtype = DTrgbe;
@@ -397,19 +492,11 @@ rmx_write(const RMATRIX *rm, int dtype, FILE *fp)
 		fprintf(fp, "NROWS=%d\n", rm->nrows);
 		fprintf(fp, "NCOLS=%d\n", rm->ncols);
 		fprintf(fp, "NCOMP=%d\n", rm->ncomp);
-	} else if (rm->ncomp != 3) {		/* wrong # components? */
-		double	cmtx[3];
-		if (rm->ncomp != 1)		/* only convert grayscale */
-			return(0);
-		cmtx[0] = cmtx[1] = cmtx[2] = 1;
-		mydm = rmx_transform(rm, 3, cmtx);
-		if (!mydm)
-			return(0);
-		rm = mydm;
-	}
+	} else if ((rm->ncomp != 3) & (rm->ncomp != 1))
+		return(0);			/* wrong # components */
 	if ((dtype == DTfloat) | (dtype == DTdouble))
 		fputendian(fp);			/* important to record */
-	fputformat((char *)cm_fmt_id[dtype], fp);
+	fputformat(cm_fmt_id[dtype], fp);
 	fputc('\n', fp);
 	switch (dtype) {			/* write data */
 	case DTascii:
@@ -433,8 +520,6 @@ rmx_write(const RMATRIX *rm, int dtype, FILE *fp)
 #ifdef getc_unlocked
 	funlockfile(fp);
 #endif
-	if (mydm)
-		rmx_free(mydm);
 	return(ok);
 }
 
@@ -447,10 +532,12 @@ rmx_identity(const int dim, const int n)
 
 	if (!rid)
 		return(NULL);
-	memset(rid->mtx, 0, sizeof(rid->mtx[0])*n*dim*dim);
-	for (i = dim; i--; )
+	memset(rid->mtx, 0, array_size(rid));
+	for (i = dim; i--; ) {
+	    double	*dp = rmx_lval(rid,i,i);
 	    for (k = n; k--; )
-		rmx_lval(rid,i,i,k) = 1;
+		dp[k] = 1.;
+	}
 	return(rid);
 }
 
@@ -467,8 +554,7 @@ rmx_copy(const RMATRIX *rm)
 		return(NULL);
 	rmx_addinfo(dnew, rm->info);
 	dnew->dtype = rm->dtype;
-	memcpy(dnew->mtx, rm->mtx,
-		sizeof(rm->mtx[0])*rm->ncomp*rm->nrows*rm->ncols);
+	memcpy(dnew->mtx, rm->mtx, array_size(dnew));
 	return(dnew);
 }
 
@@ -477,7 +563,7 @@ RMATRIX *
 rmx_transpose(const RMATRIX *rm)
 {
 	RMATRIX	*dnew;
-	int	i, j, k;
+	int	i, j;
 
 	if (!rm)
 		return(0);
@@ -497,10 +583,10 @@ rmx_transpose(const RMATRIX *rm)
 		rmx_addinfo(dnew, "Transposed rows and columns\n");
 	}
 	dnew->dtype = rm->dtype;
-	for (i = dnew->nrows; i--; )
-	    for (j = dnew->ncols; j--; )
-		for (k = dnew->ncomp; k--; )
-			rmx_lval(dnew,i,j,k) = rmx_lval(rm,j,i,k);
+	for (j = dnew->ncols; j--; )
+	    for (i = dnew->nrows; i--; )
+	    	memcpy(rmx_lval(dnew,i,j), rmx_lval(rm,j,i),
+	    			sizeof(double)*dnew->ncomp);
 	return(dnew);
 }
 
@@ -524,10 +610,10 @@ rmx_multiply(const RMATRIX *m1, const RMATRIX *m2)
 	for (i = mres->nrows; i--; )
 	    for (j = mres->ncols; j--; )
 	        for (k = mres->ncomp; k--; ) {
-		    long double	d = 0;
+		    double	d = 0;
 		    for (h = m1->ncols; h--; )
-			d += rmx_lval(m1,i,h,k) * rmx_lval(m2,h,j,k);
-		    rmx_lval(mres,i,j,k) = (double)d;
+			d += rmx_lval(m1,i,h)[k] * rmx_lval(m2,h,j)[k];
+		    rmx_lval(mres,i,j)[k] = d;
 		}
 	return(mres);
 }
@@ -553,33 +639,33 @@ rmx_elemult(RMATRIX *m1, const RMATRIX *m2, int divide
 		if (divide) {
 		    double	d;
 		    if (m2->ncomp == 1) {
-			d = rmx_lval(m2,i,j,0);
+			d = rmx_lval(m2,i,j)[0];
 			if (d == 0) {
 			    ++zeroDivides;
 			    for (k = m1->ncomp; k--; )
-				rmx_lval(m1,i,j,k) = 0;
+				rmx_lval(m1,i,j)[k] = 0;
 			} else {
 			    d = 1./d;
 			    for (k = m1->ncomp; k--; )
-				rmx_lval(m1,i,j,k) *= d;
+				rmx_lval(m1,i,j)[k] *= d;
 			}
 		    } else
 		        for (k = m1->ncomp; k--; ) {
-			    d = rmx_lval(m2,i,j,k);
+			    d = rmx_lval(m2,i,j)[k];
 			    if (d == 0) {
 			        ++zeroDivides;
-				rmx_lval(m1,i,j,k) = 0;
+				rmx_lval(m1,i,j)[k] = 0;
 			    } else
-				rmx_lval(m1,i,j,k) /= d;
+				rmx_lval(m1,i,j)[k] /= d;
 			}
 		} else {
 		    if (m2->ncomp == 1) {
-			const double	d = rmx_lval(m2,i,j,0);
+			const double	d = rmx_lval(m2,i,j)[0];
 		        for (k = m1->ncomp; k--; )
-			    rmx_lval(m1,i,j,k) *= d;
+			    rmx_lval(m1,i,j)[k] *= d;
 		    } else
 		        for (k = m1->ncomp; k--; )
-			    rmx_lval(m1,i,j,k) *= rmx_lval(m2,i,j,k);
+			    rmx_lval(m1,i,j)[k] *= rmx_lval(m2,i,j)[k];
 		}
 	if (zeroDivides) {
 		rmx_addinfo(m1, "WARNING: zero divide(s) corrupted results\n");
@@ -614,9 +700,12 @@ rmx_sum(RMATRIX *msum, const RMATRIX *madd, const doub
 	else
 		rmx_addinfo(msum, rmx_mismatch_warn);
 	for (i = msum->nrows; i--; )
-	    for (j = msum->ncols; j--; )
+	    for (j = msum->ncols; j--; ) {
+	    	const double	*da = rmx_lval(madd,i,j);
+	    	double		*ds = rmx_lval(msum,i,j);
 		for (k = msum->ncomp; k--; )
-		     rmx_lval(msum,i,j,k) += sf[k] * rmx_lval(madd,i,j,k);
+		     ds[k] += sf[k] * da[k];
+	    }
 	if (mysf)
 		free(mysf);
 	return(1);
@@ -631,10 +720,11 @@ rmx_scale(RMATRIX *rm, const double sf[])
 	if (!rm | !sf)
 		return(0);
 	for (i = rm->nrows; i--; )
-	    for (j = rm->ncols; j--; )
+	    for (j = rm->ncols; j--; ) {
+	    	double	*dp = rmx_lval(rm,i,j);
 		for (k = rm->ncomp; k--; )
-		    rmx_lval(rm,i,j,k) *= sf[k];
-
+		    dp[k] *= sf[k];
+	    }
 	if (rm->info)
 		rmx_addinfo(rm, "Applied scalar\n");
 	return(1);
@@ -654,20 +744,22 @@ rmx_transform(const RMATRIX *msrc, int n, const double
 		return(NULL);
 	if (msrc->info) {
 		char	buf[128];
-		sprintf(buf, "Applied %dx%d matrix transform\n",
+		sprintf(buf, "Applied %dx%d component transform\n",
 				dnew->ncomp, msrc->ncomp);
 		rmx_addinfo(dnew, msrc->info);
 		rmx_addinfo(dnew, buf);
 	}
 	dnew->dtype = msrc->dtype;
 	for (i = dnew->nrows; i--; )
-	    for (j = dnew->ncols; j--; )
+	    for (j = dnew->ncols; j--; ) {
+		const double	*ds = rmx_lval(msrc,i,j);
 	        for (kd = dnew->ncomp; kd--; ) {
 		    double	d = 0;
 		    for (ks = msrc->ncomp; ks--; )
-		        d += cmat[kd*msrc->ncomp + ks] * rmx_lval(msrc,i,j,ks);
-		    rmx_lval(dnew,i,j,kd) = d;
+		        d += cmat[kd*msrc->ncomp + ks] * ds[ks];
+		    rmx_lval(dnew,i,j)[kd] = d;
 		}
+	    }
 	return(dnew);
 }
 
@@ -687,9 +779,10 @@ rmx_from_cmatrix(const CMATRIX *cm)
 	for (i = dnew->nrows; i--; )
 	    for (j = dnew->ncols; j--; ) {
 		const COLORV	*cv = cm_lval(cm,i,j);
-		rmx_lval(dnew,i,j,0) = cv[0];
-		rmx_lval(dnew,i,j,1) = cv[1];
-		rmx_lval(dnew,i,j,2) = cv[2];
+		double		*dp = rmx_lval(dnew,i,j);
+		dp[0] = cv[0];
+		dp[1] = cv[1];
+		dp[2] = cv[2];
 	    }
 	return(dnew);
 }
@@ -701,17 +794,19 @@ cm_from_rmatrix(const RMATRIX *rm)
 	int	i, j;
 	CMATRIX	*cnew;
 
-	if (!rm || rm->ncomp != 3)
+	if (!rm || !rm->mtx | ((rm->ncomp != 3) & (rm->ncomp != 1)))
 		return(NULL);
 	cnew = cm_alloc(rm->nrows, rm->ncols);
 	if (!cnew)
 		return(NULL);
 	for (i = cnew->nrows; i--; )
 	    for (j = cnew->ncols; j--; ) {
-		COLORV	*cv = cm_lval(cnew,i,j);
-		cv[0] = (COLORV)rmx_lval(rm,i,j,0);
-		cv[1] = (COLORV)rmx_lval(rm,i,j,1);
-		cv[2] = (COLORV)rmx_lval(rm,i,j,2);
+		const double	*dp = rmx_lval(rm,i,j);
+		COLORV		*cv = cm_lval(cnew,i,j);
+		if (rm->ncomp == 1)
+		    setcolor(cv, dp[0], dp[0], dp[0]);
+		else
+	    	    setcolor(cv, dp[0], dp[1], dp[2]);
 	    }
 	return(cnew);
 }