--- ray/src/util/radcompare.c 2018/10/15 22:21:45 2.5 +++ ray/src/util/radcompare.c 2018/10/19 23:56:15 2.14 @@ -1,5 +1,5 @@ #ifndef lint -static const char RCSid[] = "$Id: radcompare.c,v 2.5 2018/10/15 22:21:45 greg Exp $"; +static const char RCSid[] = "$Id: radcompare.c,v 2.14 2018/10/19 23:56:15 greg Exp $"; #endif /* * Compare Radiance files for significant differences @@ -33,6 +33,11 @@ double max_lim = 0.25; /* difference limit if non-neg int lin1cnt=0, lin2cnt=0; /* file line position */ +const char nsuffix[10][3] = { /* 1st, 2nd, 3rd, etc. */ + "th","st","nd","rd","th","th","th","th","th","th" + }; +#define num_sfx(n) nsuffix[(n)%10] + /* file types */ const char *file_type[] = { "Unrecognized", @@ -48,7 +53,7 @@ const char *file_type[] = { "BINARY_unknown", NULL /* terminator */ }; - + /* keep consistent with above */ enum {TYP_UNKNOWN, TYP_TEXT, TYP_ASCII, TYP_RGBE, TYP_XYZE, TYP_FLOAT, TYP_DOUBLE, TYP_RBFMESH, TYP_OCTREE, TYP_TMESH, TYP_BINARY}; @@ -69,6 +74,16 @@ LUTAB hdr2 = LU_SINIT(free,free); #define adv_linecnt(htp) (lin1cnt += (htp == &hdr1), \ lin2cnt += (htp == &hdr2)) +typedef struct { /* dynamic line buffer */ + char *str; + int len; + int siz; +} LINEBUF; + +#define init_line(bp) ((bp)->str = NULL, (bp)->siz = 0) + /* 100 MByte limit on line buffer */ +#define MAXBUF (100L<<20) + /* input files */ char *progname = NULL; const char stdin_name[] = ""; @@ -77,7 +92,7 @@ FILE *f1in=NULL, *f2in=NULL; /* running real differences */ double diff2sum = 0; -int nsum = 0; +long nsum = 0; /* Report usage and exit */ static void @@ -87,9 +102,49 @@ usage() fputs(progname, stderr); fputs(" [-h][-s|-w|-v][-rel min_test][-rms epsilon][-max epsilon] reference test\n", stderr); - exit(1); + exit(2); } +/* Read a text line, increasing buffer size as necessary */ +static int +read_line(LINEBUF *bp, FILE *fp) +{ + bp->len = 0; + if (!bp->str) { + bp->str = (char *)malloc(bp->siz = 512); + if (!bp->str) + goto memerr; + } + while (fgets(bp->str + bp->len, bp->siz - bp->len, fp)) { + bp->len += strlen(bp->str + bp->len); + if (bp->str[bp->len-1] == '\n') + break; /* found EOL */ + if (bp->len < bp->siz - 4) + continue; /* at EOF? */ + if (bp->siz >= MAXBUF) + break; /* don't go to extremes */ + if ((bp->siz += bp->siz/2) > MAXBUF) + bp->siz = MAXBUF; + bp->str = (char *)realloc(bp->str, bp->siz); + if (!bp->str) + goto memerr; + } + return(bp->len); +memerr: + fprintf(stderr, + "%s: out of memory in read_line() allocating %d byte buffer\n", + progname, bp->siz); + exit(2); +} + +/* Free line buffer */ +static void +free_line(LINEBUF *bp) +{ + if (bp->str) free(bp->str); + init_line(bp); +} + /* Get type ID from name (or 0 if not found) */ static int xlate_type(const char *nm) @@ -129,6 +184,22 @@ real_check(double r1, double r2) return(1); } +/* Compare two color values for equivalence */ +static int +color_check(COLOR c1, COLOR c2) +{ + int p; + + if (!real_check(colval(c1,RED)+colval(c1,GRN)+colval(c1,BLU)*(1./3.), + colval(c2,RED)+colval(c2,GRN)+colval(c2,BLU))*(1./3.)) + return(0); + + p = (colval(c1,GRN) > colval(c1,RED)) ? GRN : RED; + if (colval(c1,BLU) > colval(c1,p)) p = BLU; + + return(real_check(colval(c1,p), colval(c2,p))); +} + /* Compare two strings for equivalence */ static int equiv_string(char *s1, char *s2) @@ -223,14 +294,14 @@ setheadvar(char *val, void *p) val++; if (!*val) /* nothing set? */ return(0); - vln = strlen(val); /* eliminate space and newline at end */ - while (--vln > 0 && isspace(val[vln])) - ; - val[++vln] = '\0'; /* check if key to ignore */ for (n = 0; hdr_ignkey[n]; n++) if (!strcmp(key, hdr_ignkey[n])) return(0); + vln = strlen(val); /* eliminate space and newline at end */ + while (isspace(val[--vln])) + ; + val[++vln] = '\0'; if (!(tep = lu_find(htp, key))) return(-1); /* memory allocation error */ if (!tep->key) @@ -270,13 +341,13 @@ match_val(const LUENT *ep1, void *p2) /* Compare two sets of header variables */ static int -headers_match(LUTAB *hp1, LUTAB *hp2) +headers_match() { - int ne = lu_doall(hp1, match_val, hp2); + int ne = lu_doall(&hdr1, match_val, &hdr2); if (ne < 0) return(0); /* something didn't match! */ /* non-fatal if second header has extra */ - if (report >= REP_WARN && (ne = lu_doall(hp2, NULL, NULL) - ne)) + if (report >= REP_WARN && (ne = lu_doall(&hdr2, NULL, NULL) - ne)) printf("%s: warning - '%s' has %d extra header setting(s)\n", progname, f2name, ne); return(1); /* good match */ @@ -331,7 +402,7 @@ identify_type(const char *name, FILE *fin, LUTAB *htp) } if (getheader(fin, setheadvar, htp) < 0) { fputs(name, stderr); - fputs(": Unknown error reading header\n", stderr); + fputs(": unknown error reading header\n", stderr); return(-1); } adv_linecnt(htp); /* for trailing emtpy line */ @@ -350,7 +421,7 @@ identify_type(const char *name, FILE *fin, LUTAB *htp) badeof: if (report != REP_QUIET) { fputs(name, stdout); - fputs(": Unexpected end-of-file\n", stdout); + fputs(": unexpected end-of-file\n", stdout); } return(-1); } @@ -396,14 +467,14 @@ compare_binary() return(1); /* success! */ if (report != REP_QUIET) { fputs(f1name, stdout); - fputs(": Unexpected end-of-file\n", stdout); + fputs(": unexpected end-of-file\n", stdout); } return(0); } if (c2 == EOF) { if (report != REP_QUIET) { fputs(f2name, stdout); - fputs(": Unexpected end-of-file\n", stdout); + fputs(": unexpected end-of-file\n", stdout); } return(0); } @@ -424,56 +495,63 @@ compare_binary() static int compare_text() { - char l1buf[4096], l2buf[4096]; + LINEBUF l1buf, l2buf; if (report >= REP_VERBOSE) { fputs(progname, stdout); fputs(": comparing inputs as ASCII text\n", stdout); } - /* compare a line at a time */ - while (fgets(l1buf, sizeof(l1buf), f1in)) { + init_line(&l1buf); init_line(&l2buf); /* compare a line at a time */ + while (read_line(&l1buf, f1in)) { lin1cnt++; - if (!*sskip2(l1buf,0)) + if (!*sskip2(l1buf.str,0)) continue; /* ignore empty lines */ - while (fgets(l2buf, sizeof(l2buf), f2in)) { + + while (read_line(&l2buf, f2in)) { lin2cnt++; - if (*sskip2(l2buf,0)) + if (*sskip2(l2buf.str,0)) break; /* found other non-empty line */ } - if (feof(f2in)) { + if (!l2buf.len) { /* input 2 EOF? */ if (report != REP_QUIET) { fputs(f2name, stdout); - fputs(": Unexpected end-of-file\n", stdout); + fputs(": unexpected end-of-file\n", stdout); } + free_line(&l1buf); free_line(&l2buf); return(0); } /* compare non-empty lines */ - if (!equiv_string(l1buf, l2buf)) { + if (!equiv_string(l1buf.str, l2buf.str)) { if (report != REP_QUIET) { printf("%s: inputs '%s' and '%s' differ at line %d|%d\n", progname, f1name, f2name, lin1cnt, lin2cnt); - if (report >= REP_VERBOSE) { + if ( report >= REP_VERBOSE && + (l1buf.len < 256) & + (l2buf.len < 256) ) { fputs("------------- Mismatch -------------\n", stdout); printf("%s@%d:\t%s", f1name, - lin1cnt, l1buf); + lin1cnt, l1buf.str); printf("%s@%d:\t%s", f2name, - lin2cnt, l2buf); + lin2cnt, l2buf.str); } } + free_line(&l1buf); free_line(&l2buf); return(0); } } - /* check for EOF on input 2 */ - while (fgets(l2buf, sizeof(l2buf), f2in)) { - if (!*sskip2(l2buf,0)) + free_line(&l1buf); /* check for EOF on input 2 */ + while (read_line(&l2buf, f2in)) { + if (!*sskip2(l2buf.str,0)) continue; if (report != REP_QUIET) { fputs(f1name, stdout); - fputs(": Unexpected end-of-file\n", stdout); + fputs(": unexpected end-of-file\n", stdout); } + free_line(&l2buf); return(0); } + free_line(&l2buf); return(good_RMS()); /* final check for reals */ } @@ -485,6 +563,10 @@ compare_hdr() COLOR *scan1, *scan2; int x, y; + if (report >= REP_VERBOSE) { + fputs(progname, stdout); + fputs(": comparing inputs as HDR images\n", stdout); + } fgetsresolu(&rs1, f1in); fgetsresolu(&rs2, f2in); if (rs1.rt != rs2.rt) { @@ -511,19 +593,14 @@ compare_hdr() if ((freadscan(scan1, scanlen(&rs1), f1in) < 0) | (freadscan(scan2, scanlen(&rs2), f2in) < 0)) { if (report != REP_QUIET) - printf("%s: Unexpected end-of-file\n", + printf("%s: unexpected end-of-file\n", progname); free(scan1); free(scan2); return(0); } for (x = 0; x < scanlen(&rs1); x++) { - if (real_check(colval(scan1[x],RED), - colval(scan2[x],RED)) & - real_check(colval(scan1[x],GRN), - colval(scan2[x],GRN)) & - real_check(colval(scan1[x],BLU), - colval(scan2[x],BLU))) + if (color_check(scan1[x], scan2[x])) continue; if (report != REP_QUIET) { printf( @@ -550,10 +627,6 @@ compare_hdr() return(good_RMS()); /* final check of RMS */ } -const char nsuffix[10][3] = { /* 1st, 2nd, 3rd, etc. */ - "th","st","nd","rd","th","th","th","th","th","th" - }; - /* Compare two inputs that are known to be 32-bit floating-point data */ static int compare_float() @@ -561,6 +634,10 @@ compare_float() long nread = 0; float f1, f2; + if (report >= REP_VERBOSE) { + fputs(progname, stdout); + fputs(": comparing inputs as 32-bit IEEE floats\n", stdout); + } while (getbinary(&f1, sizeof(f1), 1, f1in)) { if (!getbinary(&f2, sizeof(f2), 1, f2in)) goto badeof; @@ -569,14 +646,14 @@ compare_float() continue; if (report != REP_QUIET) printf("%s: %ld%s float values differ\n", - progname, nread, nsuffix[nread%10]); + progname, nread, num_sfx(nread)); return(0); } if (!getbinary(&f2, sizeof(f2), 1, f2in)) return(good_RMS()); /* final check of RMS */ badeof: if (report != REP_QUIET) - printf("%s: Unexpected end-of-file\n", progname); + printf("%s: unexpected end-of-file\n", progname); return(0); } @@ -587,6 +664,10 @@ compare_double() long nread = 0; double f1, f2; + if (report >= REP_VERBOSE) { + fputs(progname, stdout); + fputs(": comparing inputs as 64-bit IEEE doubles\n", stdout); + } while (getbinary(&f1, sizeof(f1), 1, f1in)) { if (!getbinary(&f2, sizeof(f2), 1, f2in)) goto badeof; @@ -594,15 +675,15 @@ compare_double() if (real_check(f1, f2)) continue; if (report != REP_QUIET) - printf("%s: %ld%s float values differ\n", - progname, nread, nsuffix[nread%10]); + printf("%s: %ld%s double values differ\n", + progname, nread, num_sfx(nread)); return(0); } if (!getbinary(&f2, sizeof(f2), 1, f2in)) return(good_RMS()); /* final check of RMS */ badeof: if (report != REP_QUIET) - printf("%s: Unexpected end-of-file\n", progname); + printf("%s: unexpected end-of-file\n", progname); return(0); } @@ -649,35 +730,34 @@ main(int argc, char *argv[]) } break; } - if (a != argc-2) + if (a != argc-2) /* make sure of two inputs */ usage(); - if (!f1name) f1name = argv[a]; - if (!f2name) f2name = argv[a+1]; - - if (!strcmp(f1name, f2name)) { /* inputs are same? */ + if (!strcmp(argv[a], argv[a+1])) { /* inputs are same? */ if (report >= REP_WARN) printf("%s: warning - identical inputs given\n", progname); return(0); } + if (!f1name) f1name = argv[a]; + if (!f2name) f2name = argv[a+1]; /* open inputs */ SET_FILE_BINARY(stdin); /* in case we're using it */ if (!f1in && !(f1in = fopen(f1name, "rb"))) { fprintf(stderr, "%s: cannot open for reading\n", f1name); - return(1); + return(2); } if (!strcmp(f2name, "-")) { f2in = stdin; f2name = stdin_name; } else if (!(f2in = fopen(f2name, "rb"))) { fprintf(stderr, "%s: cannot open for reading\n", f2name); - return(1); + return(2); } /* load headers */ if ((typ1 = identify_type(f1name, f1in, &hdr1)) < 0) - return(1); + return(2); if ((typ2 = identify_type(f2name, f2in, &hdr2)) < 0) - return(1); + return(2); if (typ1 != typ2) { if (report != REP_QUIET) printf("%s: '%s' is %s and '%s' is %s\n", @@ -686,7 +766,7 @@ main(int argc, char *argv[]) return(1); } ign_header |= !has_header(typ1); /* check headers if indicated */ - if (!ign_header && !headers_match(&hdr1, &hdr2)) + if (!ign_header && !headers_match()) return(1); lu_done(&hdr1); lu_done(&hdr2); if (!ign_header & (report >= REP_WARN)) {