--- ray/src/util/glaresrc.c 1991/03/20 12:18:14 1.7 +++ ray/src/util/glaresrc.c 1991/04/12 10:28:36 1.12 @@ -49,6 +49,11 @@ analyze() /* analyze our scene */ memerr("view span brightness buffer"); for (v = vsize; v >= -vsize; v--) { close_sources(v); +#ifndef DEBUG + if (verbose) + fprintf(stderr, "%s: analyzing... %3ld%%\r", + progname, 100L*(vsize-v)/(2*vsize)); +#endif getviewspan(v, spanbr); left = hsize + 1; for (h = -hsize; h <= hsize; h++) { @@ -75,7 +80,6 @@ analyze() /* analyze our scene */ } free((char *)spanbr); close_allsrcs(); - absorb_specks(); } @@ -87,29 +91,29 @@ double br; register int i; if (h <= -hlim) { /* left region */ - d = (double)(h+hlim)/sampdens; - if (d <= -1.0+FTINY) + d = (double)(-h-hlim)/sampdens; + if (d >= 1.0-FTINY) return; tanb = d/sqrt(1.0-d*d); for (i = 0; i < nglardirs; i++) { d = indirect[i].lcos - tanb*indirect[i].lsin; if (d > 0.0) { indirect[i].sum += d * br; - indirect[i].n++; + indirect[i].n += d; } } return; } if (h >= hlim) { /* right region */ - d = (double)(h-hlim)/sampdens; - if (d >= 1.0-FTINY) + d = (double)(-h+hlim)/sampdens; + if (d <= -1.0+FTINY) return; tanb = d/sqrt(1.0-d*d); for (i = 0; i < nglardirs; i++) { d = indirect[i].rcos - tanb*indirect[i].rsin; if (d > 0.0) { indirect[i].sum += d * br; - indirect[i].n++; + indirect[i].n += d; } } return; @@ -119,7 +123,7 @@ double br; d = cos(h_theta(h) - indirect[i].theta); if (d > 0.0) { indirect[i].sum += d * br; - indirect[i].n++; + indirect[i].n += d; } } } @@ -127,6 +131,7 @@ double br; comp_thresh() /* compute glare threshold */ { + SPANERR sperr; int h, v; int nsamps; double brsum, br; @@ -136,13 +141,15 @@ comp_thresh() /* compute glare threshold */ progname); brsum = 0.0; nsamps = 0; - for (v = vsize; v >= -vsize; v -= TSAMPSTEP) + for (v = vsize; v >= -vsize; v -= TSAMPSTEP) { + setspanerr(&sperr, v); for (h = -hsize; h <= hsize; h += TSAMPSTEP) { - if ((br = getviewpix(h, v)) < 0.0) + if ((br = getviewpix(h, v, &sperr)) < 0.0) continue; brsum += br; nsamps++; } + } if (nsamps == 0) { fprintf(stderr, "%s: no viewable scene!\n", progname); exit(1); @@ -153,7 +160,9 @@ comp_thresh() /* compute glare threshold */ exit(1); } if (verbose) { +#ifdef DEBUG pict_stats(); +#endif fprintf(stderr, "%s: threshold set to %f cd/m2 from %d samples\n", progname, threshold, nsamps); @@ -281,10 +290,10 @@ register struct source *sp; for (ss = sp->first; ss != NULL; ss = ss->next) { sp->brt += ss->brsum; n += ss->r - ss->l; - if (compdir(dright, ss->r, ss->v) < 0) - compdir(dright, ss->r-2, ss->v); + if (compdir(dright, ss->r, ss->v, NULL) < 0) + compdir(dright, ss->r-2, ss->v, NULL); for (h = ss->r-1; h >= ss->l; h--) - if (compdir(dthis, h, ss->v) == 0) { + if (compdir(dthis, h, ss->v, NULL) == 0) { d = dist2(dthis, dright); fvsum(sp->dir, sp->dir, dthis, d); sp->dom += d; @@ -299,7 +308,7 @@ register struct source *sp; donelist = sp; if (verbose) fprintf(stderr, - "%s: found source at (%.3f,%.3f,%.3f), dw %.5f, br %.1f (%d samps)\n", + "%s: source at [%.3f,%.3f,%.3f], dw %.5f, br %.1f (%d samps)\n", progname, sp->dir[0], sp->dir[1], sp->dir[2], sp->dom, sp->brt, n); } @@ -333,10 +342,10 @@ absorb_specks() /* eliminate too-small sources */ fprintf(stderr, "%s: absorbing small sources...\n", progname); head.next = donelist; last = &head; - for (this = donelist; this != NULL; this = this->next) + for (this = head.next; this != NULL; this = this->next) if (TOOSMALL(this)) { last->next = this->next; - buddy = findbuddy(this, donelist); + buddy = findbuddy(this, head.next); if (buddy != NULL) mergesource(buddy, this); else @@ -352,15 +361,16 @@ absorb(s) /* absorb a source into indirect */ register struct source *s; { FVECT dir; - register int i, n; + double d; + register int i; for (i = 0; i < nglardirs; i++) { spinvector(dir, ourview.vdir, ourview.vup, indirect[i].theta); - n = DOT(dir,s->dir)*s->dom*(sampdens*sampdens) + 0.5; - if (n == 0) + d = DOT(dir,s->dir)*s->dom*(sampdens*sampdens); + if (d <= 0.0) continue; - indirect[i].sum += n * s->brt; - indirect[i].n += n; + indirect[i].sum += d * s->brt; + indirect[i].n += d; } for ( ; s->first != NULL; s->first = s->first->next) free((char *)s->first);