--- ray/src/util/genBSDF.pl	2011/11/21 20:07:50	2.28
+++ ray/src/util/genBSDF.pl	2012/03/06 04:41:31	2.33
@@ -1,5 +1,5 @@
 #!/usr/bin/perl -w
-# RCSid $Id: genBSDF.pl,v 2.28 2011/11/21 20:07:50 greg Exp $
+# RCSid $Id: genBSDF.pl,v 2.33 2012/03/06 04:41:31 greg Exp $
 #
 # Compute BSDF based on geometry and material description
 #
@@ -8,7 +8,7 @@
 use strict;
 use File::Temp qw/ :mktemp  /;
 sub userror {
-	print STDERR "Usage: genBSDF [-n Nproc][-c Nsamp][-t{3|4} Nlog2][-r \"ropts\"][-dim xmin xmax ymin ymax zmin zmax][{+|-}f][{+|-}b][{+|-}mgf][{+|-}geom] [input ..]\n";
+	print STDERR "Usage: genBSDF [-n Nproc][-c Nsamp][-t{3|4} Nlog2][-r \"ropts\"][-dim xmin xmax ymin ymax zmin zmax][{+|-}f][{+|-}b][{+|-}mgf][{+|-}geom units] [input ..]\n";
 	exit 1;
 }
 my $td = mkdtemp("/tmp/genBSDF.XXXXXX");
@@ -23,7 +23,7 @@ my $geout = 1;
 my $nproc = 1;
 my $doforw = 0;
 my $doback = 1;
-my $pctcull = 95;
+my $pctcull = 90;
 my $gunit = "Meter";
 my @dim;
 # Get options
@@ -45,6 +45,7 @@ while ($#ARGV >= 0) {
 	} elsif ("$ARGV[0]" =~ /^[-+]b/) {
 		$doback = ("$ARGV[0]" =~ /^\+/);
 	} elsif ("$ARGV[0]" eq "-t") {
+		# Use value < 0 for rttree_reduce bypass
 		$pctcull = $ARGV[1];
 		shift @ARGV;
 	} elsif ("$ARGV[0]" =~ /^-t[34]$/) {
@@ -321,6 +322,7 @@ sub bg_tree_rtcontrib {
 sub ttree_out {
 	my $forw = shift;
 	my $side = ("Back","Front")[$forw];
+	my $cmd;
 # Only output one transmitted distribution, preferring backwards
 if ( !$forw || !$doback ) {
 print
@@ -335,11 +337,18 @@ print
 			<ScatteringDataType>BTDF</ScatteringDataType>
 			<ScatteringData>
 ';
-system "rcalc -if3 -e 'Omega:PI/($ns*$ns)' " .
-	q{-e '$1=(0.265*$1+0.670*$2+0.065*$3)/Omega' -of } .
-	"$td/" . ($bmodnm,$fmodnm)[$forw] . "_???.flt " .
+$cmd = "rcalc -if3 -e 'Omega:PI/($ns*$ns)' " .
+	q{-e '$1=(0.265*$1+0.670*$2+0.065*$3)/Omega' };
+if ($pctcull >= 0) {
+	$cmd .= "-of $td/" . ($bmodnm,$fmodnm)[$forw] . "_???.flt " .
 	"| rttree_reduce -a -h -ff -t $pctcull -r $tensortree -g $ttlog2";
-die "Failure running rttree_reduce" if ( $? );
+	system "$cmd" || die "Failure running rttree_reduce";
+} else {
+	$cmd .= "$td/" . ($bmodnm,$fmodnm)[$forw] . "_???.flt";
+	print "{\n";
+	system "$cmd" || die "Failure running rcalc";
+	print "}\n";
+}
 print
 '			</ScatteringData>
 		</WavelengthDataBlock>
@@ -361,11 +370,18 @@ print
 			<ScatteringDataType>BRDF</ScatteringDataType>
 			<ScatteringData>
 ';
-system "rcalc -if3 -e 'Omega:PI/($ns*$ns)' " .
-	q{-e '$1=(0.265*$1+0.670*$2+0.065*$3)/Omega' -of } .
-	"$td/" . ($fmodnm,$bmodnm)[$forw] . "_???.flt " .
+$cmd = "rcalc -if3 -e 'Omega:PI/($ns*$ns)' " .
+	q{-e '$1=(0.265*$1+0.670*$2+0.065*$3)/Omega' };
+if ($pctcull >= 0) {
+	$cmd .= "-of $td/" . ($fmodnm,$bmodnm)[$forw] . "_???.flt " .
 	"| rttree_reduce -a -h -ff -t $pctcull -r $tensortree -g $ttlog2";
-die "Failure running rttree_reduce" if ( $? );
+	system "$cmd" || die "Failure running rttree_reduce";
+} else {
+	$cmd .= "$td/" . ($fmodnm,$bmodnm)[$forw] . "_???.flt";
+	print "{\n";
+	system "$cmd" || die "Failure running rcalc";
+	print "}\n";
+}
 print
 '			</ScatteringData>
 		</WavelengthDataBlock>
@@ -403,9 +419,9 @@ KprojOmega = PI * if(Kbin-.5,
 $kcal = '
 DEGREE : PI/180;
 abs(x) : if(x, x, -x);
-Acos(x) : 1/DEGREE * if(x-1, 0, if(-1-x, 0, acos(x)));
+Acos(x) : if(x-1, 0, if(-1-x, PI, acos(x))) / DEGREE;
 posangle(a) : if(-a, a + 2*PI, a);
-Atan2(y,x) : 1/DEGREE * posangle(atan2(y,x));
+Atan2(y,x) : posangle(atan2(y,x)) / DEGREE;
 kpola(r) : select(r, 5, 15, 25, 35, 45, 55, 65, 75, 90);
 knaz(r) : select(r, 1, 8, 16, 20, 24, 24, 24, 16, 12);
 kaccum(r) : if(r-.5, knaz(r) + kaccum(r-1), 0);
@@ -437,8 +453,7 @@ my $rtcmd = "rtcontrib $rtargs -h -ff -fo -n $nproc -c
 	"-o '$td/%s.flt' -m $fmodnm -m $bmodnm $octree";
 my $rccmd = "rcalc -e '$tcal' " .
 	"-e 'mod(n,d):n-floor(n/d)*d' -e 'Kbin=mod(recno-.999,$ndiv)' " .
-	q{-if3 -e 'oval=(0.265*$1+0.670*$2+0.065*$3)/KprojOmega' } .
-	q[-o '${  oval  },'];
+	q{-if3 -e '$1=(0.265*$1+0.670*$2+0.065*$3)/KprojOmega' };
 if ( $doforw ) {
 $cmd = "cnt $ndiv $ny $nx | rcalc -of -e '$tcal' " .
 	"-e 'xp=(\$3+rand(.12*recno+288))*(($dim[1]-$dim[0])/$nx)+$dim[0]' " .
@@ -464,8 +479,10 @@ $cmd = "cnt $ndiv $ny $nx | rcalc -of -e '$tcal' " .
 system "$cmd" || die "Failure running: $cmd\n";
 @tbarr = `$rccmd $td/$bmodnm.flt`;
 die "Failure running: $rccmd $td/$bmodnm.flt\n" if ( $? );
+chomp(@tbarr);
 @rbarr = `$rccmd $td/$fmodnm.flt`;
 die "Failure running: $rccmd $td/$fmodnm.flt\n" if ( $? );
+chomp(@rbarr);
 }
 # Output angle basis
 print
@@ -565,7 +582,7 @@ print
 # Output front transmission (transposed order)
 for (my $od = 0; $od < $ndiv; $od++) {
 	for (my $id = 0; $id < $ndiv; $id++) {
-		print $tfarr[$ndiv*$id + $od];
+		print $tfarr[$ndiv*$id + $od], ",\n";
 	}
 	print "\n";
 }
@@ -585,10 +602,10 @@ print
 			<ScatteringDataType>BRDF</ScatteringDataType>
 			<ScatteringData>
 ';
-# Output front reflection (reciprocity averaging)
+# Output front reflection (transposed order)
 for (my $od = 0; $od < $ndiv; $od++) {
 	for (my $id = 0; $id < $ndiv; $id++) {
-		print .5*($rfarr[$ndiv*$id + $od] + $rfarr[$ndiv*$od + $id]);
+		print $rfarr[$ndiv*$id + $od], ",\n";
 	}
 	print "\n";
 }
@@ -615,7 +632,7 @@ print
 # Output back transmission (transposed order)
 for (my $od = 0; $od < $ndiv; $od++) {
 	for (my $id = 0; $id < $ndiv; $id++) {
-		print $tbarr[$ndiv*$id + $od];
+		print $tbarr[$ndiv*$id + $od], ",\n";
 	}
 	print "\n";
 }
@@ -635,10 +652,10 @@ print
 			<ScatteringDataType>BRDF</ScatteringDataType>
 			<ScatteringData>
 ';
-# Output back reflection (reciprocity averaging)
+# Output back reflection (transposed order)
 for (my $od = 0; $od < $ndiv; $od++) {
 	for (my $id = 0; $id < $ndiv; $id++) {
-		print .5*($rbarr[$ndiv*$id + $od] + $rbarr[$ndiv*$od + $id]);
+		print $rbarr[$ndiv*$id + $od], ",\n";
 	}
 	print "\n";
 }