--- ray/src/util/cmatrix.c	2014/02/08 01:28:06	2.2
+++ ray/src/util/cmatrix.c	2021/01/15 18:31:38	2.31
@@ -1,5 +1,5 @@
 #ifndef lint
-static const char RCSid[] = "$Id: cmatrix.c,v 2.2 2014/02/08 01:28:06 greg Exp $";
+static const char RCSid[] = "$Id: cmatrix.c,v 2.31 2021/01/15 18:31:38 greg Exp $";
 #endif
 /*
  * Color matrix routines.
@@ -8,18 +8,20 @@ static const char RCSid[] = "$Id: cmatrix.c,v 2.2 2014
  */
 
 #include <ctype.h>
+#include "platform.h"
 #include "standard.h"
 #include "cmatrix.h"
 #include "platform.h"
+#include "paths.h"
 #include "resolu.h"
 
 const char	*cm_fmt_id[] = {
-			"unknown", "ascii", "float", "double",
-			COLRFMT, CIEFMT
+			"unknown", COLRFMT, CIEFMT,
+			"float", "ascii", "double"
 		};
 
 const int	cm_elem_size[] = {
-			0, 0, 3*sizeof(float), 3*sizeof(double), 4, 4
+			0, 4, 4, 3*sizeof(float), 0, 3*sizeof(double)
 		};
 
 /* Allocate a color coefficient matrix */
@@ -31,72 +33,200 @@ cm_alloc(int nrows, int ncols)
 	if ((nrows <= 0) | (ncols <= 0))
 		error(USER, "attempt to create empty matrix");
 	cm = (CMATRIX *)malloc(sizeof(CMATRIX) +
-				3*sizeof(COLORV)*(nrows*ncols - 1));
-	if (cm == NULL)
+				sizeof(COLOR)*((size_t)nrows*ncols - 1));
+	if (!cm)
 		error(SYSTEM, "out of memory in cm_alloc()");
 	cm->nrows = nrows;
 	cm->ncols = ncols;
 	return(cm);
 }
 
+static void
+adjacent_ra_sizes(size_t bounds[2], size_t target)
+{
+	bounds[0] = 0; bounds[1] = 2048;
+	while (bounds[1] < target) {
+		bounds[0] = bounds[1];
+		bounds[1] += bounds[1]>>1;
+	}
+}
+
 /* Resize color coefficient matrix */
 CMATRIX *
 cm_resize(CMATRIX *cm, int nrows)
 {
+	size_t	old_size, new_size, ra_bounds[2];
+
+	if (!cm)
+		return(NULL);
 	if (nrows == cm->nrows)
 		return(cm);
 	if (nrows <= 0) {
 		cm_free(cm);
 		return(NULL);
 	}
-	cm = (CMATRIX *)realloc(cm, sizeof(CMATRIX) +
-			3*sizeof(COLORV)*(nrows*cm->ncols - 1));
-	if (cm == NULL)
-		error(SYSTEM, "out of memory in cm_resize()");
+	old_size = sizeof(CMATRIX) + sizeof(COLOR)*((size_t)cm->nrows*cm->ncols - 1);
+	adjacent_ra_sizes(ra_bounds, old_size);
+	new_size = sizeof(CMATRIX) + sizeof(COLOR)*((size_t)nrows*cm->ncols - 1);
+	if (nrows < cm->nrows ? new_size <= ra_bounds[0] :
+				new_size > ra_bounds[1]) {
+		adjacent_ra_sizes(ra_bounds, new_size);
+		cm = (CMATRIX *)realloc(cm, ra_bounds[1]);
+		if (!cm)
+			error(SYSTEM, "out of memory in cm_resize()");
+	}
 	cm->nrows = nrows;
 	return(cm);
 }
 
+typedef struct {
+	int	dtype;		/* data type */
+	int	need2swap;	/* need byte swap? */
+	int	nrows, ncols;	/* matrix size */
+	COLOR	expos;		/* exposure value */
+	char	*err;		/* error message */
+} CMINFO;		/* header info record */
+
 static int
-getDT(char *s, void *p)
+get_cminfo(char *s, void *p)
 {
-	char	fmt[32];
+	CMINFO	*ip = (CMINFO *)p;
+	char	fmt[MAXFMTLEN];
 	int	i;
-	
+
+	if (!strncmp(s, "NCOMP=", 6) && atoi(s+6) != 3) {
+		ip->err = "unexpected # components (must be 3)";
+		return(-1);
+	}
+	if (!strncmp(s, "NROWS=", 6)) {
+		ip->nrows = atoi(s+6);
+		return(0);
+	}
+	if (!strncmp(s, "NCOLS=", 6)) {
+		ip->ncols = atoi(s+6);
+		return(0);
+	}
+	if ((i = isbigendian(s)) >= 0) {
+		ip->need2swap = (nativebigendian() != i);
+		return(0);
+	}
+	if (isexpos(s)) {
+		double	d = exposval(s);
+		scalecolor(ip->expos, d);
+		return(0);
+	}
+	if (iscolcor(s)) {
+		COLOR	ctmp;
+		colcorval(ctmp, s);
+		multcolor(ip->expos, ctmp);
+		return(0);
+	}
 	if (!formatval(fmt, s))
 		return(0);
 	for (i = 1; i < DTend; i++)
 		if (!strcmp(fmt, cm_fmt_id[i]))
-			*((int *)p) = i;
+			ip->dtype = i;
 	return(0);
 }
 
-/* Load header to obtain data type */
-int
-getDTfromHeader(FILE *fp)
+/* Load header to obtain/check data type and number of columns */
+char *
+cm_getheader(int *dt, int *nr, int *nc, int *swp, COLOR scale, FILE *fp)
 {
-	int	dt = DTfromHeader;
-	
-	if (getheader(fp, getDT, &dt) < 0)
-		error(SYSTEM, "header read error");
-	if (dt == DTfromHeader)
-		error(USER, "missing data format in header");
-	return(dt);
+	CMINFO	cmi;
+						/* read header */
+	cmi.dtype = DTfromHeader;
+	cmi.need2swap = 0;
+	cmi.expos[0] = cmi.expos[1] = cmi.expos[2] = 1.f;
+	cmi.nrows = cmi.ncols = 0;
+	cmi.err = "unexpected EOF in header";
+	if (getheader(fp, get_cminfo, &cmi) < 0)
+		return(cmi.err);
+	if (dt) {				/* get/check data type? */
+		if (cmi.dtype == DTfromHeader) {
+			if (*dt == DTfromHeader)
+				return("missing/unknown data format in header");
+		} else if (*dt == DTfromHeader)
+			*dt = cmi.dtype;
+		else if (*dt != cmi.dtype)
+			return("unexpected data format in header");
+	}
+	if (nr) {				/* get/check #rows? */
+		if (*nr <= 0)
+			*nr = cmi.nrows;
+		else if ((cmi.nrows > 0) & (*nr != cmi.nrows))
+			return("unexpected row count in header");
+	}
+	if (nc) {				/* get/check #columns? */
+		if (*nc <= 0)
+			*nc = cmi.ncols;
+		else if ((cmi.ncols > 0) & (*nc != cmi.ncols))
+			return("unexpected column count in header");
+	}
+	if (swp)				/* get/check swap? */
+		*swp = cmi.need2swap;
+	if (scale) {				/* transfer exposure comp. */
+		scale[0] = 1.f/cmi.expos[0];
+		scale[1] = 1.f/cmi.expos[1];
+		scale[2] = 1.f/cmi.expos[2];
+	}
+	return(NULL);
 }
 
-/* Allocate and load a matrix from the given file (or stdin if NULL) */
-CMATRIX *
-cm_load(const char *fname, int nrows, int ncols, int dtype)
+/* Allocate and load image data into matrix */
+static CMATRIX *
+cm_load_rgbe(FILE *fp, int nrows, int ncols, COLOR scale)
 {
-	FILE	*fp = stdin;
+	int	doscale;
 	CMATRIX	*cm;
+	COLORV	*mp;
+						/* header already loaded */
+	cm = cm_alloc(nrows, ncols);
+	if (!cm)
+		return(NULL);
+	doscale = (scale[0] < .99) | (scale[0] > 1.01) |
+			(scale[1] < .99) | (scale[1] > 1.01) |
+			(scale[2] < .99) | (scale[2] > 1.01) ;
+	mp = cm->cmem;
+	while (nrows--) {
+		if (freadscan((COLOR *)mp, ncols, fp) < 0) {
+			error(USER, "error reading color picture as matrix");
+			cm_free(cm);
+			return(NULL);
+		}
+		if (doscale) {
+			int	i = ncols;
+			while (i--) {
+				*mp++ *= scale[0];
+				*mp++ *= scale[1];
+				*mp++ *= scale[2];
+			}
+		} else
+			mp += 3*ncols;
+	}					/* caller closes stream */
+	return(cm);
+}
 
-	if (ncols <= 0)
-		error(USER, "Non-positive number of columns");
-	if (fname == NULL)
-		fname = "<stdin>";
-	else if ((fp = fopen(fname, "r")) == NULL) {
-		sprintf(errmsg, "cannot open file '%s'", fname);
+/* Allocate and load a matrix from the given input (or stdin if NULL) */
+CMATRIX *
+cm_load(const char *inspec, int nrows, int ncols, int dtype)
+{
+	const int	ROWINC = 2048;
+	FILE		*fp = stdin;
+	int		swap = 0;
+	COLOR		scale;
+	CMATRIX		*cm;
+
+	if (!inspec)
+		inspec = "<stdin>";
+	else if (inspec[0] == '!') {
+		fp = popen(inspec+1, "r");
+		if (!fp) {
+			sprintf(errmsg, "cannot start command '%s'", inspec);
+			error(SYSTEM, errmsg);
+		}
+	} else if (!(fp = fopen(inspec, "r"))) {
+		sprintf(errmsg, "cannot open file '%s'", inspec);
 		error(SYSTEM, errmsg);
 	}
 #ifdef getc_unlocked
@@ -104,36 +234,44 @@ cm_load(const char *fname, int nrows, int ncols, int d
 #endif
 	if (dtype != DTascii)
 		SET_FILE_BINARY(fp);		/* doesn't really work */
-	if (dtype == DTfromHeader)
-		dtype = getDTfromHeader(fp);
+	if (!dtype | !ncols) {			/* expecting header? */
+		char	*err = cm_getheader(&dtype, &nrows, &ncols, &swap, scale, fp);
+		if (err)
+			error(USER, err);
+	}
+	if (ncols <= 0 && !fscnresolu(&ncols, &nrows, fp))
+		error(USER, "unspecified number of columns");
 	switch (dtype) {
 	case DTascii:
 	case DTfloat:
 	case DTdouble:
 		break;
+	case DTrgbe:
+	case DTxyze:
+		cm = cm_load_rgbe(fp, nrows, ncols, scale);
+		goto cleanup;
 	default:
 		error(USER, "unexpected data type in cm_load()");
 	}
 	if (nrows <= 0) {			/* don't know length? */
 		int	guessrows = 147;	/* usually big enough */
-		if ((dtype != DTascii) & (fp != stdin)) {
+		if (cm_elem_size[dtype] && (fp != stdin) & (inspec[0] != '!')) {
 			long	startpos = ftell(fp);
 			if (fseek(fp, 0L, SEEK_END) == 0) {
+				long	rowsiz = (long)ncols*cm_elem_size[dtype];
 				long	endpos = ftell(fp);
-				long	elemsiz = 3*(dtype==DTfloat ?
-					    sizeof(float) : sizeof(double));
 
-				if ((endpos - startpos) % (ncols*elemsiz)) {
+				if ((endpos - startpos) % rowsiz) {
 					sprintf(errmsg,
 					"improper length for binary file '%s'",
-							fname);
+							inspec);
 					error(USER, errmsg);
 				}
-				guessrows = (endpos - startpos)/(ncols*elemsiz);
+				guessrows = (endpos - startpos)/rowsiz;
 				if (fseek(fp, startpos, SEEK_SET) < 0) {
 					sprintf(errmsg,
 						"fseek() error on file '%s'",
-							fname);
+							inspec);
 					error(SYSTEM, errmsg);
 				}
 				nrows = guessrows;	/* we're confident */
@@ -142,97 +280,116 @@ cm_load(const char *fname, int nrows, int ncols, int d
 		cm = cm_alloc(guessrows, ncols);
 	} else
 		cm = cm_alloc(nrows, ncols);
-	if (cm == NULL)					/* XXX never happens */
+	if (!cm)					/* XXX never happens */
 		return(NULL);
 	if (dtype == DTascii) {				/* read text file */
 		int	maxrow = (nrows > 0 ? nrows : 32000);
 		int	r, c;
 		for (r = 0; r < maxrow; r++) {
 		    if (r >= cm->nrows)			/* need more space? */
-			cm = cm_resize(cm, 2*cm->nrows);
+			cm = cm_resize(cm, cm->nrows+ROWINC);
 		    for (c = 0; c < ncols; c++) {
 		        COLORV	*cv = cm_lval(cm,r,c);
-			if (fscanf(fp, COLSPEC, cv, cv+1, cv+2) != 3)
+			if (fscanf(fp, COLSPEC, cv, cv+1, cv+2) != 3) {
 				if ((nrows <= 0) & (r > 0) & !c) {
 					cm = cm_resize(cm, maxrow=r);
 					break;
 				} else
 					goto EOFerror;
+			}
 		    }
 		}
 		while ((c = getc(fp)) != EOF)
 			if (!isspace(c)) {
 				sprintf(errmsg,
-				"unexpected data at end of ascii file %s",
-						fname);
+				"unexpected data at end of ascii input '%s'",
+						inspec);
 				error(WARNING, errmsg);
 				break;
 			}
 	} else {					/* read binary file */
 		if (sizeof(COLOR) == cm_elem_size[dtype]) {
-			int	nread = 0;
+			size_t	nread = 0;
 			do {				/* read all we can */
-				nread += fread(cm->cmem + 3*nread,
-						3*sizeof(COLORV),
-						cm->nrows*cm->ncols - nread,
+				nread += getbinary(cm->cmem + 3*nread,
+						sizeof(COLOR),
+						(size_t)cm->nrows*cm->ncols - nread,
 						fp);
 				if (nrows <= 0) {	/* unknown length */
-					if (nread == cm->nrows*cm->ncols)
+					if (nread == (size_t)cm->nrows*cm->ncols)
 							/* need more space? */
-						cm = cm_resize(cm, 2*cm->nrows);
+						cm = cm_resize(cm, cm->nrows+ROWINC);
 					else if (nread && !(nread % cm->ncols))
 							/* seem to be  done */
 						cm = cm_resize(cm, nread/cm->ncols);
 					else		/* ended mid-row */
 						goto EOFerror;
-				} else if (nread < cm->nrows*cm->ncols)
+				} else if (nread < (size_t)cm->nrows*cm->ncols)
 					goto EOFerror;
-			} while (nread < cm->nrows*cm->ncols);
+			} while (nread < (size_t)cm->nrows*cm->ncols);
 
+			if (swap) {
+				if (sizeof(COLORV) == 4)
+					swap32((char *)cm->cmem,
+							3*(size_t)cm->nrows*cm->ncols);
+				else /* sizeof(COLORV) == 8 */
+					swap64((char *)cm->cmem,
+							3*(size_t)cm->nrows*cm->ncols);
+			}
 		} else if (dtype == DTdouble) {
 			double	dc[3];			/* load from double */
 			COLORV	*cvp = cm->cmem;
-			int	n = nrows*ncols;
+			size_t	n = (size_t)nrows*ncols;
 
 			if (n <= 0)
 				goto not_handled;
 			while (n--) {
-				if (fread(dc, sizeof(double), 3, fp) != 3)
+				if (getbinary(dc, sizeof(double), 3, fp) != 3)
 					goto EOFerror;
+				if (swap) swap64((char *)dc, 3);
 				copycolor(cvp, dc);
 				cvp += 3;
 			}
 		} else /* dtype == DTfloat */ {
 			float	fc[3];			/* load from float */
 			COLORV	*cvp = cm->cmem;
-			int	n = nrows*ncols;
+			size_t	n = (size_t)nrows*ncols;
 
 			if (n <= 0)
 				goto not_handled;
 			while (n--) {
-				if (fread(fc, sizeof(float), 3, fp) != 3)
+				if (getbinary(fc, sizeof(float), 3, fp) != 3)
 					goto EOFerror;
+				if (swap) swap32((char *)fc, 3);
 				copycolor(cvp, fc);
 				cvp += 3;
 			}
 		}
 		if (fgetc(fp) != EOF) {
 				sprintf(errmsg,
-				"unexpected data at end of binary file %s",
-						fname);
+				"unexpected data at end of binary input '%s'",
+						inspec);
 				error(WARNING, errmsg);
 		}
 	}
-	if (fp != stdin)
-		fclose(fp);
+cleanup:
+	if (fp != stdin) {
+		if (inspec[0] != '!')
+			fclose(fp);
+		else if (pclose(fp)) {
+			sprintf(errmsg, "error running command '%s'", inspec);
+			error(WARNING, errmsg);
+		}
+	}
 #ifdef getc_unlocked
 	else
 		funlockfile(fp);
 #endif
 	return(cm);
 EOFerror:
-	sprintf(errmsg, "unexpected EOF reading %s", fname);
+	sprintf(errmsg, "unexpected EOF reading %s", inspec);
 	error(USER, errmsg);
+	return(NULL);
 not_handled:
 	error(INTERNAL, "unhandled data size or length in cm_load()");
 	return(NULL);	/* gratis return */
@@ -245,10 +402,12 @@ cm_column(const CMATRIX *cm, int c)
 	CMATRIX	*cvr;
 	int	dr;
 
+	if (!cm)
+		return(NULL);
 	if ((c < 0) | (c >= cm->ncols))
 		error(INTERNAL, "column requested outside matrix");
 	cvr = cm_alloc(cm->nrows, 1);
-	if (cvr == NULL)
+	if (!cvr)
 		return(NULL);
 	for (dr = 0; dr < cm->nrows; dr++) {
 		const COLORV	*sp = cm_lval(cm,dr,c);
@@ -260,27 +419,6 @@ cm_column(const CMATRIX *cm, int c)
 	return(cvr);
 }
 
-/* Scale a matrix by a single value */
-CMATRIX *
-cm_scale(const CMATRIX *cm1, const COLOR sca)
-{
-	CMATRIX	*cmr;
-	int	dr, dc;
-
-	cmr = cm_alloc(cm1->nrows, cm1->ncols);
-	if (cmr == NULL)
-		return(NULL);
-	for (dr = 0; dr < cmr->nrows; dr++)
-	    for (dc = 0; dc < cmr->ncols; dc++) {
-	        const COLORV	*sp = cm_lval(cm1,dr,dc);
-		COLORV		*dp = cm_lval(cmr,dr,dc);
-		dp[0] = sp[0] * sca[0];
-		dp[1] = sp[1] * sca[1];
-		dp[2] = sp[2] * sca[2];
-	    }
-	return(cmr);
-}
-
 /* Multiply two matrices (or a matrix and a vector) and allocate the result */
 CMATRIX *
 cm_multiply(const CMATRIX *cm1, const CMATRIX *cm2)
@@ -289,10 +427,12 @@ cm_multiply(const CMATRIX *cm1, const CMATRIX *cm2)
 	CMATRIX	*cmr;
 	int	dr, dc, i;
 
+	if (!cm1 | !cm2)
+		return(NULL);
 	if ((cm1->ncols <= 0) | (cm1->ncols != cm2->nrows))
 		error(INTERNAL, "matrix dimension mismatch in cm_multiply()");
 	cmr = cm_alloc(cm1->nrows, cm2->ncols);
-	if (cmr == NULL)
+	if (!cmr)
 		return(NULL);
 				/* optimization: check for zero rows & cols */
 	if (((cm1->nrows > 5) | (cm2->ncols > 5)) & (cm1->ncols > 5)) {
@@ -315,21 +455,24 @@ cm_multiply(const CMATRIX *cm1, const CMATRIX *cm2)
 	for (dr = 0; dr < cmr->nrows; dr++)
 	    for (dc = 0; dc < cmr->ncols; dc++) {
 		COLORV	*dp = cm_lval(cmr,dr,dc);
+		double	res[3];
 		dp[0] = dp[1] = dp[2] = 0;
-		if (rowcheck != NULL && !rowcheck[dr])
+		if (rowcheck && !rowcheck[dr])
 			continue;
-		if (colcheck != NULL && !colcheck[dc])
+		if (colcheck && !colcheck[dc])
 			continue;
+		res[0] = res[1] = res[2] = 0;
 		for (i = 0; i < cm1->ncols; i++) {
 		    const COLORV	*cp1 = cm_lval(cm1,dr,i);
 		    const COLORV	*cp2 = cm_lval(cm2,i,dc);
-		    dp[0] += cp1[0] * cp2[0];
-		    dp[1] += cp1[1] * cp2[1];
-		    dp[2] += cp1[2] * cp2[2];
+		    res[0] += (double)cp1[0] * cp2[0];
+		    res[1] += (double)cp1[1] * cp2[1];
+		    res[2] += (double)cp1[2] * cp2[2];
 		}
+		copycolor(dp, res);
 	    }
-	if (rowcheck != NULL) free(rowcheck);
-	if (colcheck != NULL) free(colcheck);
+	if (rowcheck) free(rowcheck);
+	if (colcheck) free(colcheck);
 	return(cmr);
 }
 
@@ -337,44 +480,48 @@ cm_multiply(const CMATRIX *cm1, const CMATRIX *cm2)
 int
 cm_write(const CMATRIX *cm, int dtype, FILE *fp)
 {
-	const COLORV	*mp = cm->cmem;
-	int		r, c;
+	static const char	tabEOL[2] = {'\t','\n'};
+	const COLORV		*mp;
+	int			r, c;
+	size_t			n, rv;
 
+	if (!cm)
+		return(0);
+	mp = cm->cmem;
 	switch (dtype) {
 	case DTascii:
-		for (r = 0; r < cm->nrows; r++) {
+		for (r = 0; r < cm->nrows; r++)
 			for (c = 0; c < cm->ncols; c++, mp += 3)
-				fprintf(fp, "\t%.6e %.6e %.6e",
-						mp[0], mp[1], mp[2]);
-			fputc('\n', fp);
-		}
+				fprintf(fp, "%.6e %.6e %.6e%c",
+						mp[0], mp[1], mp[2],
+						tabEOL[c >= cm->ncols-1]);
 		break;
 	case DTfloat:
 	case DTdouble:
 		if (sizeof(COLOR) == cm_elem_size[dtype]) {
-			r = cm->ncols*cm->nrows;
-			while (r > 0) {
-				c = fwrite(mp, sizeof(COLOR), r, fp);
-				if (c <= 0)
+			n = (size_t)cm->ncols*cm->nrows;
+			while (n > 0) {
+				rv = fwrite(mp, sizeof(COLOR), n, fp);
+				if (rv <= 0)
 					return(0);
-				mp += 3*c;
-				r -= c;
+				mp += 3*rv;
+				n -= rv;
 			}
 		} else if (dtype == DTdouble) {
 			double	dc[3];
-			r = cm->ncols*cm->nrows;
-			while (r--) {
+			n = (size_t)cm->ncols*cm->nrows;
+			while (n--) {
 				copycolor(dc, mp);
-				if (fwrite(dc, sizeof(double), 3, fp) != 3)
+				if (putbinary(dc, sizeof(double), 3, fp) != 3)
 					return(0);
 				mp += 3;
 			}
 		} else /* dtype == DTfloat */ {
 			float	fc[3];
-			r = cm->ncols*cm->nrows;
-			while (r--) {
+			n = (size_t)cm->ncols*cm->nrows;
+			while (n--) {
 				copycolor(fc, mp);
-				if (fwrite(fc, sizeof(float), 3, fp) != 3)
+				if (putbinary(fc, sizeof(float), 3, fp) != 3)
 					return(0);
 				mp += 3;
 			}