--- ray/src/rt/virtuals.c	1991/10/23 08:49:40	1.30
+++ ray/src/rt/virtuals.c	2003/04/23 00:52:34	2.9
@@ -1,18 +1,17 @@
-/* Copyright (c) 1991 Regents of the University of California */
-
 #ifndef lint
-static char SCCSid[] = "$SunId$ LBL";
+static const char	RCSid[] = "$Id: virtuals.c,v 2.9 2003/04/23 00:52:34 greg Exp $";
 #endif
-
 /*
  * Routines for simulating virtual light sources
  *	Thus far, we only support planar mirrors.
+ *
+ *  External symbols declared in source.h
  */
 
+#include "copyright.h"
+
 #include  "ray.h"
 
-#include  "octree.h"
-
 #include  "otypes.h"
 
 #include  "source.h"
@@ -23,12 +22,11 @@ static char SCCSid[] = "$SunId$ LBL";
 #define  STESTMAX	32		/* maximum seeks per sample */
 
 
-double  getdisk();
-
 static OBJECT  *vobject;		/* virtual source objects */
 static int  nvobjects = 0;		/* number of virtual source objects */
 
 
+void
 markvirtuals()			/* find and mark virtual sources */
 {
 	register OBJREC  *o;
@@ -41,7 +39,7 @@ markvirtuals()			/* find and mark virtual sources */
 		o = objptr(i);
 		if (!issurface(o->otype) || o->omod == OVOID)
 			continue;
-		if (!isvlight(objptr(o->omod)->otype))
+		if (!isvlight(vsmaterial(o)->otype))
 			continue;
 		if (sfun[o->otype].of == NULL ||
 				sfun[o->otype].of->getpleq == NULL) {
@@ -51,7 +49,7 @@ markvirtuals()			/* find and mark virtual sources */
 		if (nvobjects == 0)
 			vobject = (OBJECT *)malloc(sizeof(OBJECT));
 		else
-			vobject = (OBJECT *)realloc((char *)vobject,
+			vobject = (OBJECT *)realloc((void *)vobject,
 				(unsigned)(nvobjects+1)*sizeof(OBJECT));
 		if (vobject == NULL)
 			error(SYSTEM, "out of memory in addvirtuals");
@@ -66,11 +64,12 @@ markvirtuals()			/* find and mark virtual sources */
 	for (i = nsources; i-- > 0; )
 		addvirtuals(i, directrelay);
 					/* done with our object list */
-	free((char *)vobject);
+	free((void *)vobject);
 	nvobjects = 0;
 }
 
 
+void
 addvirtuals(sn, nr)		/* add virtuals associated with source */
 int  sn;
 int  nr;
@@ -88,6 +87,7 @@ int  nr;
 }
 
 
+void
 vproject(o, sn, n)		/* create projected source(s) if they exist */
 OBJREC  *o;
 int  sn;
@@ -101,7 +101,7 @@ int  n;
 	if (o == source[sn].so)	/* objects cannot project themselves */
 		return;
 				/* get virtual source material */
-	vsmat = sfun[objptr(o->omod)->otype].mf;
+	vsmat = sfun[vsmaterial(o)->otype].mf;
 				/* project virtual sources */
 	for (i = 0; i < vsmat->nproj; i++)
 		if ((*vsmat->vproj)(proj, o, &source[sn], i))
@@ -115,6 +115,23 @@ int  n;
 }
 
 
+OBJREC *
+vsmaterial(o)			/* get virtual source material pointer */
+OBJREC  *o;
+{
+	register int  i;
+	register OBJREC  *m;
+
+	i = o->omod;
+	m = objptr(i);
+	if (m->otype != MAT_ILLUM || m->oargs.nsargs < 1 ||
+			!strcmp(m->oargs.sarg[0], VOIDID) ||
+			(i = lastmod(objndx(m), m->oargs.sarg[0])) == OVOID)
+		return(m);		/* direct modifier */
+	return(objptr(i));		/* illum alternate */
+}
+
+
 int
 makevsrc(op, sn, pm)		/* make virtual source if reasonable */
 OBJREC  *op;
@@ -140,7 +157,7 @@ MAT4  pm;
 		normalize(nsloc);
 		VCOPY(ourspot.aim, ocent);
 		ourspot.siz = PI*maxrad2;
-		ourspot.flen = 0.;
+		ourspot.flen = -1.;
 		if (source[sn].sflags & SSPOT) {
 			multp3(theirspot.aim, source[sn].sl.s->aim, pm);
 						/* adjust for source size */
@@ -284,7 +301,6 @@ register int  sn;	/* target source number */
 	FVECT  offsdir;
 	SRCINDEX  si;
 	double  or, d;
-	int  infront;
 	int  stestlim, ssn;
 	int  nhit, nok;
 	register int  i, n;
@@ -297,7 +313,6 @@ register int  sn;	/* target source number */
 	if (source[sn].sflags & SDISTANT) {
 					/* 32. == heuristic constant */
 		n = 32.*or2/(thescene.cusize*thescene.cusize)*vspretest + .5;
-		infront = DOT(onorm, source[sn].sloc) > 0.;
 	} else {
 		for (i = 0; i < 3; i++)
 			offsdir[i] = source[sn].sloc[i] - oc[i];
@@ -306,7 +321,6 @@ register int  sn;	/* target source number */
 			n = 2.*PI * vspretest + .5;
 		else
 			n = 2.*PI * (1.-sqrt(1./(1.+or2/d)))*vspretest + .5;
-		infront = DOT(onorm, offsdir) > 0.;
 	}
 	if (n < MINSAMPLES) n = MINSAMPLES;
 #ifdef DEBUG
@@ -318,6 +332,7 @@ register int  sn;	/* target source number */
 	stestlim = n*STESTMAX;
 	ssn = 0;
 	nhit = nok = 0;
+	initsrcindex(&si);
 	while (n-- > 0) {
 					/* get sample point */
 		do {
@@ -331,34 +346,29 @@ register int  sn;	/* target source number */
 			for (i = 0; i < 3; i++)
 				offsdir[i] = or*(1. - 2.*offsdir[i]);
 			ssn++;
-			for (i = 0; i < 3; i++)
-				sr.rorg[i] = oc[i] + offsdir[i];
-			d = DOT(offsdir,onorm);
-			if (infront)
-				for (i = 0; i < 3; i++) {
-					sr.rorg[i] -= (d-.0001)*onorm[i];
-					sr.rdir[i] = -onorm[i];
-				}
-			else
-				for (i = 0; i < 3; i++) {
-					sr.rorg[i] -= (d+.0001)*onorm[i];
-					sr.rdir[i] = onorm[i];
-				}
+			d = 1. - DOT(offsdir, onorm);
+			for (i = 0; i < 3; i++) {
+				sr.rorg[i] = oc[i] + offsdir[i] + d*onorm[i];
+				sr.rdir[i] = -onorm[i];
+			}
+			sr.rmax = 0.0;
 			rayorigin(&sr, NULL, PRIMARY, 1.0);
 		} while (!(*ofun[o->otype].funp)(o, &sr));
 					/* check against source */
-		initsrcindex(&si);
-		si.sn = sn;
-		nopart(&si, &sr);
+		VCOPY(sr.rorg, sr.rop);	/* starting from intersection */
 		samplendx++;
-		if (!srcray(&sr, NULL, &si) || sr.rsrc != sn)
-			continue;
+		if (si.sp >= si.np-1 ||
+				!srcray(&sr, NULL, &si) || sr.rsrc != sn) {
+			si.sn = sn-1;		/* reset index to our source */
+			si.np = 0;
+			if (!srcray(&sr, NULL, &si) || sr.rsrc != sn)
+				continue;	/* can't get there from here */
+		}
 		sr.revf = srcvalue;
-		rayvalue(&sr);
+		rayvalue(&sr);			/* check sample validity */
 		if (bright(sr.rcol) <= FTINY)
 			continue;
-		nok++;
-					/* check against obstructions */
+		nok++;			/* got sample; check obstructions */
 		rayclear(&sr);
 		sr.revf = raytrace;
 		rayvalue(&sr);
@@ -385,6 +395,7 @@ register int  sn;	/* target source number */
 	
 
 #ifdef DEBUG
+void
 virtverb(sn, fp)	/* print verbose description of virtual source */
 register int  sn;
 FILE  *fp;