--- ray/src/rt/srcsupp.c 2003/02/25 02:47:23 2.10 +++ ray/src/rt/srcsupp.c 2008/12/06 01:08:53 2.17 @@ -1,5 +1,5 @@ #ifndef lint -static const char RCSid[] = "$Id: srcsupp.c,v 2.10 2003/02/25 02:47:23 greg Exp $"; +static const char RCSid[] = "$Id: srcsupp.c,v 2.17 2008/12/06 01:08:53 greg Exp $"; #endif /* * Support routines for source objects and materials @@ -19,7 +19,7 @@ static const char RCSid[] = "$Id: srcsupp.c,v 2.10 200 #include "face.h" -#define SRCINC 4 /* realloc increment for array */ +#define SRCINC 8 /* realloc increment for array */ SRCREC *source = NULL; /* our list of sources */ int nsources = 0; /* the number of sources */ @@ -54,13 +54,16 @@ newsource() /* allocate new source in our array */ if (nsources == 0) source = (SRCREC *)malloc(SRCINC*sizeof(SRCREC)); else if (nsources%SRCINC == 0) - source = (SRCREC *)realloc((char *)source, + source = (SRCREC *)realloc((void *)source, (unsigned)(nsources+SRCINC)*sizeof(SRCREC)); if (source == NULL) return(-1); source[nsources].sflags = 0; source[nsources].nhits = 1; - source[nsources].ntests = 2; /* initial hit probability = 1/2 */ + source[nsources].ntests = 2; /* initial hit probability = 50% */ +#if SHADCACHE + source[nsources].obscache = NULL; +#endif return(nsources++); } @@ -98,6 +101,8 @@ OBJREC *so; src->so = so; /* get the face */ f = getface(so); + if (f->area == 0.0) + objerror(so, USER, "zero source area"); /* find the center */ for (j = 0; j < 3; j++) { src->sloc[j] = 0.0; @@ -106,7 +111,7 @@ OBJREC *so; src->sloc[j] /= (double)f->nv; } if (!inface(src->sloc, f)) - objerror(so, USER, "cannot hit center"); + objerror(so, USER, "cannot hit source center"); src->sflags |= SFLAT; VCOPY(src->snorm, f->norm); src->ss2 = f->area; @@ -140,7 +145,7 @@ register OBJREC *so; src->so = so; if (so->oargs.nfargs != 4) objerror(so, USER, "bad arguments"); - src->sflags |= SDISTANT; + src->sflags |= (SDISTANT|SCIR); VCOPY(src->sloc, so->oargs.farg); if (normalize(src->sloc) == 0.0) objerror(so, USER, "zero direction"); @@ -168,14 +173,15 @@ register OBJREC *so; if (so->oargs.nfargs != 4) objerror(so, USER, "bad # arguments"); if (so->oargs.farg[3] <= FTINY) - objerror(so, USER, "illegal radius"); + objerror(so, USER, "illegal source radius"); + src->sflags |= SCIR; VCOPY(src->sloc, so->oargs.farg); src->srad = so->oargs.farg[3]; src->ss2 = PI * src->srad * src->srad; for (i = 0; i < 3; i++) src->ss[SU][i] = src->ss[SV][i] = src->ss[SW][i] = 0.0; for (i = 0; i < 3; i++) - src->ss[i][i] = .7236 * so->oargs.farg[3]; + src->ss[i][i] = 0.7236 * so->oargs.farg[3]; } @@ -190,10 +196,12 @@ OBJREC *so; src->so = so; /* get the ring */ co = getcone(so, 0); + if (CO_R1(co) <= FTINY) + objerror(so, USER, "illegal source radius"); VCOPY(src->sloc, CO_P0(co)); if (CO_R0(co) > 0.0) - objerror(so, USER, "cannot hit center"); - src->sflags |= SFLAT; + objerror(so, USER, "cannot hit source center"); + src->sflags |= (SFLAT|SCIR); VCOPY(src->snorm, co->ad); src->srad = CO_R1(co); src->ss2 = PI * src->srad * src->srad; @@ -213,6 +221,8 @@ OBJREC *so; src->so = so; /* get the cylinder */ co = getcone(so, 0); + if (CO_R0(co) <= FTINY) + objerror(so, USER, "illegal source radius"); if (CO_R0(co) > .2*co->al) /* heuristic constraint */ objerror(so, WARNING, "source aspect too small"); src->sflags |= SCYL; @@ -246,6 +256,8 @@ register OBJREC *m; return(ns); if ((ns = (SPOT *)malloc(sizeof(SPOT))) == NULL) return(NULL); + if (m->oargs.farg[3] <= FTINY) + objerror(m, USER, "zero angle"); ns->siz = 2.0*PI * (1.0 - cos(PI/180.0/2.0 * m->oargs.farg[3])); VCOPY(ns->aim, m->oargs.farg+4); if ((ns->flen = normalize(ns->aim)) == 0.0)