--- ray/src/rt/source.c	1990/12/13 21:49:23	1.25
+++ ray/src/rt/source.c	1990/12/28 20:37:08	1.29
@@ -237,26 +237,24 @@ register int  sn;		/* source number */
 						/* domega constant */
 		return(source[sn].ss2);
 
-	else {
 						/* check proximity */
-		if (source[sn].sflags & SPROX &&
-				d > source[sn].sl.prox)
-			return(0.0);
-
-		if (norm != NULL)
-			ddot /= d;
-		else
-			ddot = 1.0;
+	if (source[sn].sflags & SPROX &&
+			d > source[sn].sl.prox)
+		return(0.0);
+						/* compute dot product */
+	if (norm != NULL)
+		ddot /= d;
+	else
+		ddot = 1.0;
 						/* check angle */
-		if (source[sn].sflags & SSPOT) {
-			if (source[sn].sl.s->siz < 2.0*PI *
+	if (source[sn].sflags & SSPOT) {
+		if (source[sn].sl.s->siz < 2.0*PI *
 				(1.0 + DOT(source[sn].sl.s->aim,sr->rdir)))
-				return(0.0);
-			d += source[sn].sl.s->flen;
-		}
-						/* return domega */
-		return(ddot*source[sn].ss2/(d*d));
+			return(0.0);
+		d += source[sn].sl.s->flen;	/* adjust length */
 	}
+						/* compute domega */
+	return(ddot*source[sn].ss2/(d*d));
 }
 
 
@@ -288,8 +286,7 @@ register RAY  *r;
 		for (i = 0; i < 3; i++)
 			r->ron[i] = -r->rdir[i];
 		r->rod = 1.0;
-		r->rofs = 1.0; setident4(r->rofx);
-		r->robs = 1.0; setident4(r->robx);
+		r->rox = NULL;
 		return(1);
 	}
 	return(0);
@@ -316,7 +313,8 @@ char  *p;			/* data for f */
 	extern double  pow();
 	register int  sn;
 	int  nshadcheck, ncnts;
-	double  prob, ourthresh, hwt, test2, hit2;
+	int  nhits;
+	double  prob, ourthresh, hwt;
 	RAY  sr;
 			/* NOTE: srccnt and cntord global so no recursion */
 	if (nsources <= 0)
@@ -347,6 +345,7 @@ char  *p;			/* data for f */
 				"aiming failure for light source \"%s\"",
 					source[sn].so->oname);
 			error(WARNING, errmsg);
+			cntord[sn].brt = 0.0;
 			continue;
 		}
 						/* compute contribution */
@@ -371,19 +370,15 @@ char  *p;			/* data for f */
                                                 /* accumulate tail */
         for (sn = ncnts-1; sn > 0; sn--)
                 cntord[sn-1].brt += cntord[sn].brt;
-						/* start with prob=.5 */
-	hit2 = 0.5; test2 = 1.0;
 						/* test for shadows */
+	nhits = 0;
 	for (sn = 0; sn < ncnts; sn++) {
 						/* check threshold */
 		if ((sn+nshadcheck>=ncnts ? cntord[sn].brt :
-				cntord[sn].brt-cntord[sn+nshadcheck].brt) <
-				ourthresh*bright(r->rcol))
+				cntord[sn].brt-cntord[sn+nshadcheck].brt)
+				< ourthresh*bright(r->rcol))
 			break;
 						/* get statistics */
-		hwt = (double)source[cntord[sn].sno].nhits /
-				(double)source[cntord[sn].sno].ntests;
-		test2 += hwt;
 		source[cntord[sn].sno].ntests++;
 						/* test for hit */
 		rayorigin(&sr, r, SHADOW, 1.0);
@@ -402,11 +397,14 @@ char  *p;			/* data for f */
 		}
 						/* add contribution if hit */
 		addcolor(r->rcol, srccnt[cntord[sn].sno].val);
-		hit2 += hwt;
+		nhits++;
 		source[cntord[sn].sno].nhits++;
 	}
-					/* weighted hit rate */
-	hwt = hit2 / test2;
+					/* surface hit rate */
+	if (sn > 0)
+		hwt = (double)nhits / (double)sn;
+	else
+		hwt = 0.5;
 #ifdef DEBUG
 	sprintf(errmsg, "%d tested, %d untested, %f hit rate\n",
 			sn, ncnts-sn, hwt);