--- ray/src/rt/source.c	1989/06/13 10:57:52	1.12
+++ ray/src/rt/source.c	1990/12/13 21:49:23	1.25
@@ -1,4 +1,4 @@
-/* Copyright (c) 1986 Regents of the University of California */
+/* Copyright (c) 1990 Regents of the University of California */
 
 #ifndef lint
 static char SCCSid[] = "$SunId$ LBL";
@@ -32,7 +32,10 @@ extern double  shadcert;		/* shadow testing certainty 
 SRCREC  *source = NULL;			/* our list of sources */
 int  nsources = 0;			/* the number of sources */
 
+static CONTRIB  *srccnt;		/* source contributions in direct() */
+static CNTPTR  *cntord;			/* source ordering in direct() */
 
+
 marksources()			/* find and mark source objects */
 {
 	register OBJREC  *o, *m;
@@ -47,10 +50,7 @@ marksources()			/* find and mark source objects */
 
 		m = objptr(o->omod);
 
-		if (m->otype != MAT_LIGHT &&
-				m->otype != MAT_ILLUM &&
-				m->otype != MAT_GLOW &&
-				m->otype != MAT_SPOT)
+		if (!islight(m->otype))
 			continue;
 	
 		if (m->oargs.nfargs != (m->otype == MAT_GLOW ? 4 :
@@ -68,7 +68,7 @@ marksources()			/* find and mark source objects */
 			source = (SRCREC *)realloc((char *)source,
 					(unsigned)(nsources+1)*sizeof(SRCREC));
 		if (source == NULL)
-			error(SYSTEM, "out of memory in marksources");
+			goto memerr;
 
 		newsource(&source[nsources], o);
 
@@ -83,6 +83,17 @@ marksources()			/* find and mark source objects */
 		}
 		nsources++;
 	}
+	if (nsources <= 0) {
+		error(WARNING, "no light sources found");
+		return;
+	}
+	srccnt = (CONTRIB *)malloc(nsources*sizeof(CONTRIB));
+	cntord = (CNTPTR *)malloc(nsources*sizeof(CNTPTR));
+	if (srccnt != NULL && cntord != NULL)
+		return;
+	/* fall through */
+memerr:
+	error(SYSTEM, "out of memory in marksources");
 }
 
 
@@ -304,16 +315,12 @@ char  *p;			/* data for f */
 {
 	extern double  pow();
 	register int  sn;
-	register CONTRIB  *srccnt;
-	register CNTPTR  *cntord;
 	int  nshadcheck, ncnts;
 	double  prob, ourthresh, hwt, test2, hit2;
 	RAY  sr;
-
-	srccnt = (CONTRIB *)malloc(nsources*sizeof(CONTRIB));
-	cntord = (CNTPTR *)malloc(nsources*sizeof(CNTPTR));
-	if (srccnt == NULL || cntord == NULL)
-		error(SYSTEM, "out of memory in direct");
+			/* NOTE: srccnt and cntord global so no recursion */
+	if (nsources <= 0)
+		return;		/* no sources?! */
 						/* compute number to check */
 	nshadcheck = pow((double)nsources, shadcert) + .5;
 						/* modify threshold */
@@ -329,31 +336,38 @@ char  *p;			/* data for f */
 						/* compute coefficient */
 		(*f)(srccnt[sn].val, p, srccnt[sn].dir, srccnt[sn].dom);
 		cntord[sn].brt = bright(srccnt[sn].val);
-		if (cntord[sn].brt <= FTINY)
+		if (cntord[sn].brt <= 0.0)
 			continue;
 						/* compute intersection */
 		if (!( source[sn].sflags & SDISTANT ?
 				sourcehit(&sr) :
 				(*ofun[source[sn].so->otype].funp)
-				(source[sn].so, &sr) ))
+				(source[sn].so, &sr) )) {
+			sprintf(errmsg,
+				"aiming failure for light source \"%s\"",
+					source[sn].so->oname);
+			error(WARNING, errmsg);
 			continue;
+		}
 						/* compute contribution */
-		rayshade(&sr, sr.ro->omod);
+		raycont(&sr);
 		multcolor(srccnt[sn].val, sr.rcol);
 		cntord[sn].brt = bright(srccnt[sn].val);
 	}
 						/* sort contributions */
 	qsort(cntord, nsources, sizeof(CNTPTR), cntcmp);
-                                                /* find last */
-        sn = 0; ncnts = nsources;
-        while (sn < ncnts-1) {
-                register int  m;
-                m = (sn + ncnts) >> 1;
-                if (cntord[m].brt > 0.0)
-                        sn = m;
-                else
-                        ncnts = m;
-        }
+	{					/* find last */
+		register int  l, m;
+
+		sn = 0; ncnts = l = nsources;
+		while ((m = (sn + ncnts) >> 1) != l) {
+			if (cntord[m].brt > 0.0)
+				sn = m;
+			else
+				ncnts = m;
+			l = m;
+		}
+	}
                                                 /* accumulate tail */
         for (sn = ncnts-1; sn > 0; sn--)
                 cntord[sn-1].brt += cntord[sn].brt;
@@ -374,13 +388,11 @@ char  *p;			/* data for f */
 						/* test for hit */
 		rayorigin(&sr, r, SHADOW, 1.0);
 		VCOPY(sr.rdir, srccnt[cntord[sn].sno].dir);
+		sr.rsrc = cntord[sn].sno;
 		if (localhit(&sr, &thescene) &&
 				sr.ro != source[cntord[sn].sno].so) {
 						/* check for transmission */
-			if (sr.clipset != NULL && inset(sr.clipset,sr.ro->omod))
-				raytrans(&sr);		/* object is clipped */
-			else
-				rayshade(&sr, sr.ro->omod);
+			raycont(&sr);
 			if (bright(sr.rcol) <= FTINY)
 				continue;	/* missed! */
 			(*f)(srccnt[cntord[sn].sno].val, p,
@@ -407,9 +419,6 @@ char  *p;			/* data for f */
 		scalecolor(srccnt[cntord[sn].sno].val, prob);
 		addcolor(r->rcol, srccnt[cntord[sn].sno].val);
 	}
-		
-	free(srccnt);
-	free(cntord);
 }
 
 
@@ -429,9 +438,6 @@ m_light(m, r)			/* ray hit a light source */
 register OBJREC  *m;
 register RAY  *r;
 {
-						/* check for behind */
-	if (r->rod < 0.0)
-		return;
 						/* check for over-counting */
 	if (wrongsource(m, r) || badambient(m, r))
 		return;
@@ -445,6 +451,9 @@ register RAY  *r;
 
 						/* otherwise treat as source */
 	} else {
+						/* check for behind */
+		if (r->rod < 0.0)
+			return;
 						/* get distribution pattern */
 		raytexture(r, m->omod);
 						/* get source color */
@@ -453,8 +462,7 @@ register RAY  *r;
 				  m->oargs.farg[2]);
 						/* modify value */
 		multcolor(r->rcol, r->pcol);
+						/* assign distance */
+		r->rt = r->rot;
 	}
 }
-
-
-o_source() {}		/* intersection with a source is done elsewhere */