--- ray/src/rt/rv2.c	1990/01/19 00:00:29	1.17
+++ ray/src/rt/rv2.c	1990/10/14 11:04:56	1.21
@@ -63,13 +63,14 @@ char  *s;
 		}
 		fputs(progname, fp);
 		fprintview(&ourview, fp);
+		fputs(sskip(s), fp);
 		fputs("\n", fp);
 		fclose(fp);
 		return;
 	}
 	sprintf(buf, "view type (%c): ", ourview.type);
 	(*dev->comout)(buf);
-	(*dev->comin)(buf);
+	(*dev->comin)(buf, NULL);
 	if (buf[0] == CTRL(C)) return;
 	if (buf[0] && buf[0] != ourview.type) {
 		nv.type = buf[0];
@@ -79,7 +80,7 @@ char  *s;
 	sprintf(buf, "view point (%.6g %.6g %.6g): ",
 			ourview.vp[0], ourview.vp[1], ourview.vp[2]);
 	(*dev->comout)(buf);
-	(*dev->comin)(buf);
+	(*dev->comin)(buf, NULL);
 	if (buf[0] == CTRL(C)) return;
 	if (sscanf(buf, "%lf %lf %lf", &nv.vp[0], &nv.vp[1], &nv.vp[2]) == 3)
 		change++;
@@ -88,7 +89,7 @@ char  *s;
 	sprintf(buf, "view direction (%.6g %.6g %.6g): ",
 			ourview.vdir[0], ourview.vdir[1], ourview.vdir[2]);
 	(*dev->comout)(buf);
-	(*dev->comin)(buf);
+	(*dev->comin)(buf, NULL);
 	if (buf[0] == CTRL(C)) return;
 	if (sscanf(buf,"%lf %lf %lf",&nv.vdir[0],&nv.vdir[1],&nv.vdir[2]) == 3)
 		change++;
@@ -97,7 +98,7 @@ char  *s;
 	sprintf(buf, "view up (%.6g %.6g %.6g): ",
 			ourview.vup[0], ourview.vup[1], ourview.vup[2]);
 	(*dev->comout)(buf);
-	(*dev->comin)(buf);
+	(*dev->comin)(buf, NULL);
 	if (buf[0] == CTRL(C)) return;
 	if (sscanf(buf,"%lf %lf %lf",&nv.vup[0],&nv.vup[1],&nv.vup[2]) == 3)
 		change++;
@@ -106,7 +107,7 @@ char  *s;
 	sprintf(buf, "view horiz and vert size (%.6g %.6g): ",
 			ourview.horiz, ourview.vert);
 	(*dev->comout)(buf);
-	(*dev->comin)(buf);
+	(*dev->comin)(buf, NULL);
 	if (buf[0] == CTRL(C)) return;
 	if (sscanf(buf, "%lf %lf", &nv.horiz, &nv.vert) == 2)
 		change++;
@@ -116,7 +117,7 @@ char  *s;
 	sprintf(buf, "view shift and lift (%.6g %.6g): ",
 			ourview.hoff, ourview.voff);
 	(*dev->comout)(buf);
-	(*dev->comin)(buf);
+	(*dev->comin)(buf, NULL);
 	if (buf[0] == CTRL(C)) return;
 	if (sscanf(buf, "%lf %lf", &nv.hoff, &nv.voff) == 2)
 		change++;
@@ -150,7 +151,7 @@ char  *s;
 			newview(&nv);
 		return;
 	}
-	if (oldview.horiz == 0) {	/* no old view! */
+	if (oldview.type == 0) {	/* no old view! */
 		error(COMMAND, "no previous view");
 		return;
 	}
@@ -170,18 +171,12 @@ char  *s;
 
 	if (getinterest(s, 1, nv.vdir, &zfact) < 0)
 		return;
+	nv.type = ourview.type;
 	VCOPY(nv.vp, ourview.vp);
 	VCOPY(nv.vup, ourview.vup);
 	nv.hoff = ourview.hoff; nv.voff = ourview.voff;
-	if ((nv.type = ourview.type) == VT_PAR) {
-		nv.horiz = ourview.horiz / zfact;
-		nv.vert = ourview.vert / zfact;
-	} else {
-		nv.horiz = atan(tan(ourview.horiz*(PI/180./2.))/zfact) /
-				(PI/180./2.);
-		nv.vert = atan(tan(ourview.vert*(PI/180./2.))/zfact) /
-				(PI/180./2.);
-	}
+	nv.horiz = ourview.horiz; nv.vert = ourview.vert;
+	zoomview(&nv, zfact);
 	newview(&nv);
 }
 
@@ -211,6 +206,7 @@ char  *s;
 		error(COMMAND, "missing angle");
 		return;
 	}
+	nv.type = ourview.type;
 	VCOPY(nv.vp, ourview.vp);
 	VCOPY(nv.vup, ourview.vup);
 	nv.hoff = ourview.hoff; nv.voff = ourview.voff;
@@ -220,15 +216,8 @@ char  *s;
 		normalize(v1);
 		spinvector(nv.vdir, nv.vdir, v1, elev*(PI/180.));
 	}
-	if ((nv.type = ourview.type) == VT_PAR) {
-		nv.horiz = ourview.horiz / zfact;
-		nv.vert = ourview.vert / zfact;
-	} else {
-		nv.horiz = atan(tan(ourview.horiz*(PI/180./2.))/zfact) /
-				(PI/180./2.);
-		nv.vert = atan(tan(ourview.vert*(PI/180./2.))/zfact) /
-				(PI/180./2.);
-	}
+	nv.horiz = ourview.horiz; nv.vert = ourview.vert;
+	zoomview(&nv, zfact);
 	newview(&nv);
 }
 
@@ -282,7 +271,7 @@ char  *s;
 			if (*cp == '\0') {	/* interactive */
 				sprintf(buf, "exposure (%lf): ", exposure);
 				(*dev->comout)(buf);
-				(*dev->comin)(buf);
+				(*dev->comin)(buf, NULL);
 				for (cp = buf; isspace(*cp); cp++)
 					;
 				if (*cp == '\0')
@@ -335,7 +324,7 @@ register char  *s;
 	
 	if (s[0] == '\0') {
 		(*dev->comout)("aa ab ad ar as av dc dj dt lr lw sp st: ");
-		(*dev->comin)(buf);
+		(*dev->comin)(buf, NULL);
 		s = buf;
 	}
 	switch (s[0]) {
@@ -346,7 +335,7 @@ register char  *s;
 				sprintf(buf, "limit weight (%.6g): ",
 						minweight);
 				(*dev->comout)(buf);
-				(*dev->comin)(buf);
+				(*dev->comin)(buf, NULL);
 				if (sscanf(buf, "%lf", &d0) != 1)
 					break;
 			}
@@ -357,7 +346,7 @@ register char  *s;
 				sprintf(buf, "limit reflection (%d): ",
 						maxdepth);
 				(*dev->comout)(buf);
-				(*dev->comin)(buf);
+				(*dev->comin)(buf, NULL);
 				if (sscanf(buf, "%d", &i0) != 1)
 					break;
 			}
@@ -374,7 +363,7 @@ register char  *s;
 				sprintf(buf, "direct jitter (%.6g): ",
 						dstrsrc);
 				(*dev->comout)(buf);
-				(*dev->comin)(buf);
+				(*dev->comin)(buf, NULL);
 				if (sscanf(buf, "%lf", &d0) != 1)
 					break;
 			}
@@ -385,7 +374,7 @@ register char  *s;
 				sprintf(buf, "direct certainty (%.6g): ",
 						shadcert);
 				(*dev->comout)(buf);
-				(*dev->comin)(buf);
+				(*dev->comin)(buf, NULL);
 				if (sscanf(buf, "%lf", &d0) != 1)
 					break;
 			}
@@ -396,7 +385,7 @@ register char  *s;
 				sprintf(buf, "direct threshold (%.6g): ",
 						shadthresh);
 				(*dev->comout)(buf);
-				(*dev->comin)(buf);
+				(*dev->comin)(buf, NULL);
 				if (sscanf(buf, "%lf", &d0) != 1)
 					break;
 			}
@@ -416,7 +405,7 @@ register char  *s;
 						colval(ambval,GRN),
 						colval(ambval,BLU));
 				(*dev->comout)(buf);
-				(*dev->comin)(buf);
+				(*dev->comin)(buf, NULL);
 				if (sscanf(buf, "%lf %lf %lf",
 						&d0, &d1, &d2) != 3)
 					break;
@@ -428,7 +417,7 @@ register char  *s;
 				sprintf(buf, "ambient accuracy (%.6g): ",
 						ambacc);
 				(*dev->comout)(buf);
-				(*dev->comin)(buf);
+				(*dev->comin)(buf, NULL);
 				if (sscanf(buf, "%lf", &d0) != 1)
 					break;
 			}
@@ -439,7 +428,7 @@ register char  *s;
 				sprintf(buf, "ambient divisions (%d): ",
 						ambdiv);
 				(*dev->comout)(buf);
-				(*dev->comin)(buf);
+				(*dev->comin)(buf, NULL);
 				if (sscanf(buf, "%d", &i0) != 1)
 					break;
 			}
@@ -450,7 +439,7 @@ register char  *s;
 				sprintf(buf, "ambient super-samples (%d): ",
 						ambssamp);
 				(*dev->comout)(buf);
-				(*dev->comin)(buf);
+				(*dev->comin)(buf, NULL);
 				if (sscanf(buf, "%d", &i0) != 1)
 					break;
 			}
@@ -461,7 +450,7 @@ register char  *s;
 				sprintf(buf, "ambient bounces (%d): ",
 						ambounce);
 				(*dev->comout)(buf);
-				(*dev->comin)(buf);
+				(*dev->comin)(buf, NULL);
 				if (sscanf(buf, "%d", &i0) != 1)
 					break;
 			}
@@ -472,7 +461,7 @@ register char  *s;
 				sprintf(buf, "ambient resolution (%d): ",
 						ambres);
 				(*dev->comout)(buf);
-				(*dev->comin)(buf);
+				(*dev->comin)(buf, NULL);
 				if (sscanf(buf, "%d", &i0) != 1)
 					break;
 			}
@@ -489,7 +478,7 @@ register char  *s;
 			if (sscanf(s+2, "%d", &i0) != 1) {
 				sprintf(buf, "sample pixel (%d): ", psample);
 				(*dev->comout)(buf);
-				(*dev->comin)(buf);
+				(*dev->comin)(buf, NULL);
 				if (sscanf(buf, "%d", &i0) != 1)
 					break;
 			}
@@ -501,7 +490,7 @@ register char  *s;
 				sprintf(buf, "sample threshold (%.6g): ",
 						maxdiff);
 				(*dev->comout)(buf);
-				(*dev->comin)(buf);
+				(*dev->comin)(buf, NULL);
 				if (sscanf(buf, "%lf", &d0) != 1)
 					break;
 			}
@@ -540,9 +529,12 @@ char  *s;
 		if ((*dev->getcur)(&x, &y) == ABORT)
 			return;
 
-		viewray(thisray.rorg, thisray.rdir, &ourview,
-				(x+.5)/hresolu, (y+.5)/vresolu);
-		
+		if (viewray(thisray.rorg, thisray.rdir, &ourview,
+				(x+.5)/hresolu, (y+.5)/vresolu) < 0) {
+			error(COMMAND, "not on image");
+			return;
+		}
+
 	} else if (normalize(thisray.rdir) == 0.0) {
 		error(COMMAND, "zero ray direction");
 		return;
@@ -560,7 +552,7 @@ char  *s;
 				ofun[thisray.ro->otype].funame,
 				thisray.ro->oname);
 		(*dev->comout)(buf);
-		(*dev->comin)(buf);
+		(*dev->comin)(buf, NULL);
 		if (thisray.rot >= FHUGE)
 			(*dev->comout)("at infinity");
 		else {
@@ -568,14 +560,14 @@ char  *s;
 					thisray.rop[1], thisray.rop[2]);
 			(*dev->comout)(buf);
 		}
-		(*dev->comin)(buf);
+		(*dev->comin)(buf, NULL);
 		sprintf(buf, "with value (%.6g %.6g %.6g)",
 				colval(thisray.rcol,RED),
 				colval(thisray.rcol,GRN),
 				colval(thisray.rcol,BLU));
 		(*dev->comout)(buf);
 	}
-	(*dev->comin)(buf);
+	(*dev->comin)(buf, NULL);
 }