ViewVC Help
View File | Revision Log | Show Annotations | Download File | Root Listing
root/radiance/ray/src/rt/raypcalls.c
(Generate patch)

Comparing ray/src/rt/raypcalls.c (file contents):
Revision 2.4 by schorsch, Mon Jul 21 22:30:19 2003 UTC vs.
Revision 2.20 by greg, Tue Dec 2 23:28:34 2008 UTC

# Line 23 | Line 23 | static const char      RCSid[] = "$Id$";
23   *  The first step is opening one or more rendering processes
24   *  with a call to ray_pinit(oct, nproc).  Before calling fork(),
25   *  ray_pinit() loads the octree and data structures into the
26 < *  caller's memory.  This permits all sorts of queries that
27 < *  wouldn't be possible otherwise, without causing any real
26 > *  caller's memory, and ray_popen() synchronizes the ambient
27 > *  file, if any.  Shared memory permits all sorts of queries
28 > *  that wouldn't be possible otherwise, without causing any real
29   *  memory overhead, since all the static data are shared
30   *  between processes.  Rays are then traced using a simple
31   *  queuing mechanism, explained below.
32   *
33 < *  The ray queue holds as many rays as there are rendering
34 < *  processes.  Rays are queued and returned by a single
33 > *  The ray queue buffers RAYQLEN rays before sending to
34 > *  children, each of which may internally buffer RAYQLEN rays.
35 > *
36 > *  Rays are queued and returned by a single
37   *  ray_pqueue() call.  A ray_pqueue() return
38   *  value of 0 indicates that no rays are ready
39   *  and the queue is not yet full.  A return value of 1
# Line 43 | Line 46 | static const char      RCSid[] = "$Id$";
46   *      myRay.rorg = ( ray origin point )
47   *      myRay.rdir = ( normalized ray direction )
48   *      myRay.rmax = ( maximum length, or zero for no limit )
49 < *      rayorigin(&myRay, NULL, PRIMARY, 1.0);
49 > *      rayorigin(&myRay, PRIMARY, NULL, NULL);
50   *      myRay.rno = ( my personal ray identifier )
51   *      if (ray_pqueue(&myRay) == 1)
52   *              { do something with results }
# Line 51 | Line 54 | static const char      RCSid[] = "$Id$";
54   *  Note the differences between this and the simpler ray_trace()
55   *  call.  In particular, the call may or may not return a value
56   *  in the passed ray structure.  Also, you need to call rayorigin()
57 < *  yourself, which is normally for you by ray_trace().  The
58 < *  great thing is that ray_pqueue() will trace rays faster in
57 > *  yourself, which is normally called for you by ray_trace().  The
58 > *  benefit is that ray_pqueue() will trace rays faster in
59   *  proportion to the number of CPUs you have available on your
60   *  system.  If the ray queue is full before the call, ray_pqueue()
61   *  will block until a result is ready so it can queue this one.
# Line 81 | Line 84 | static const char      RCSid[] = "$Id$";
84   *              ray_psend(&myRay);
85   *      }
86   *
87 < *  The ray_presult() and/or ray_pqueue() functions may then be
88 < *  called to read back the results.
87 > *  Note that it is a fatal error to call ra_psend() when
88 > *  ray_pnidle is zero.  The ray_presult() and/or ray_pqueue()
89 > *  functions may be called subsequently to read back the results.
90   *
91   *  When you are done, you may call ray_pdone(1) to close
92   *  all child processes and clean up memory used by Radiance.
# Line 99 | Line 103 | static const char      RCSid[] = "$Id$";
103   *  If you just want to reap children so that you can alter the
104   *  rendering parameters without reloading the scene, use the
105   *  ray_pclose(0) and ray_popen(nproc) calls to close
106 < *  then restart the child processes.
106 > *  then restart the child processes after the changes are made.
107   *
108   *  Note:  These routines are written to coordinate with the
109   *  definitions in raycalls.c, and in fact depend on them.
110   *  If you want to trace a ray and get a result synchronously,
111   *  use the ray_trace() call to compute it in the parent process.
112 + *  This will not interfere with any subprocess calculations,
113 + *  but beware that a fatal error may end with a call to quit().
114   *
115   *  Note:  One of the advantages of using separate processes
116   *  is that it gives the calling program some immunity from
117   *  fatal rendering errors.  As discussed in raycalls.c,
118   *  Radiance tends to throw up its hands and exit at the
119   *  first sign of trouble, calling quit() to return control
120 < *  to the system.  Although you can avoid exit() with
120 > *  to the top level.  Although you can avoid exit() with
121   *  your own longjmp() in quit(), the cleanup afterwards
122   *  is always suspect.  Through the use of subprocesses,
123   *  we avoid this pitfall by closing the processes and
# Line 120 | Line 126 | static const char      RCSid[] = "$Id$";
126   *  of these calls, you can assume that the processes have
127   *  been cleaned up with a call to ray_close(), though you
128   *  will have to call ray_pdone() yourself if you want to
129 < *  free memory.  Obviously, you cannot continue rendering,
130 < *  but otherwise your process should not be compromised.
129 > *  free memory.  Obviously, you cannot continue rendering
130 > *  without risking further errors, but otherwise your
131 > *  process should not be compromised.
132   */
133  
134 + #include  "rtprocess.h"
135   #include  "ray.h"
136 <
136 > #include  "ambient.h"
137 > #include  <sys/types.h>
138 > #include  <sys/wait.h>
139   #include  "selcall.h"
140  
141   #ifndef RAYQLEN
142 < #define RAYQLEN         16              /* # rays to send at once */
142 > #define RAYQLEN         12              /* # rays to send at once */
143   #endif
144  
145   #ifndef MAX_RPROCS
# Line 160 | Line 170 | static int     r_recv_next;            /* next receive ray placement
170  
171   #define sendq_full()    (r_send_next >= RAYQLEN)
172  
173 + static int ray_pflush(void);
174 + static void ray_pchild(int fd_in, int fd_out);
175  
176 < void
177 < ray_pinit(otnm, nproc)          /* initialize ray-tracing processes */
178 < char    *otnm;
179 < int     nproc;
176 >
177 > extern void
178 > ray_pinit(              /* initialize ray-tracing processes */
179 >        char    *otnm,
180 >        int     nproc
181 > )
182   {
183          if (nobjects > 0)               /* close old calculation */
184                  ray_pdone(0);
185  
186          ray_init(otnm);                 /* load the shared scene */
187  
174 –        preload_objs();                 /* preload auxiliary data */
175 –
176 –                                        /* set shared memory boundary */
177 –        shm_boundary = (char *)malloc(16);
178 –        strcpy(shm_boundary, "SHM_BOUNDARY");
179 –
188          r_send_next = 0;                /* set up queue */
189          r_recv_first = r_recv_next = RAYQLEN;
190  
# Line 185 | Line 193 | int    nproc;
193  
194  
195   static int
196 < ray_pflush()                    /* send queued rays to idle children */
196 > ray_pflush(void)                        /* send queued rays to idle children */
197   {
198          int     nc, n, nw, i, sfirst;
199  
200 <        if ((ray_pnidle <= 0 | r_send_next <= 0))
200 >        if ((ray_pnidle <= 0) | (r_send_next <= 0))
201                  return(0);              /* nothing we can send */
202          
203          sfirst = 0;                     /* divvy up labor */
# Line 219 | Line 227 | ray_pflush()                   /* send queued rays to idle children */
227   }
228  
229  
230 < void
231 < ray_psend(r)                    /* add a ray to our send queue */
232 < RAY     *r;
230 > extern void
231 > ray_psend(                      /* add a ray to our send queue */
232 >        RAY     *r
233 > )
234   {
235          if (r == NULL)
236                  return;
# Line 229 | Line 238 | RAY    *r;
238          if (sendq_full() && ray_pflush() <= 0)
239                  error(INTERNAL, "ray_pflush failed in ray_psend");
240  
241 <        r_queue[r_send_next] = *r;
233 <        r_send_next++;
241 >        r_queue[r_send_next++] = *r;
242   }
243  
244  
245 < int
246 < ray_pqueue(r)                   /* queue a ray for computation */
247 < RAY     *r;
245 > extern int
246 > ray_pqueue(                     /* queue a ray for computation */
247 >        RAY     *r
248 > )
249   {
250          if (r == NULL)
251                  return(0);
252                                          /* check for full send queue */
253          if (sendq_full()) {
254 <                RAY     mySend;
246 <                int     rval;
247 <                mySend = *r;
254 >                RAY     mySend = *r;
255                                          /* wait for a result */
256 <                rval = ray_presult(r, 0);
256 >                if (ray_presult(r, 0) <= 0)
257 >                        return(-1);
258                                          /* put new ray in queue */
259 <                r_queue[r_send_next] = mySend;
260 <                r_send_next++;
261 <                return(rval);           /* done */
259 >                r_queue[r_send_next++] = mySend;
260 >                                /* XXX r_send_next may now be > RAYQLEN */
261 >                return(1);
262          }
263 <                                        /* add ray to send queue */
264 <        r_queue[r_send_next] = *r;
257 <        r_send_next++;
263 >                                        /* else add ray to send queue */
264 >        r_queue[r_send_next++] = *r;
265                                          /* check for returned ray... */
266          if (r_recv_first >= r_recv_next)
267                  return(0);
268                                          /* ...one is sitting in queue */
269 <        *r = r_queue[r_recv_first];
263 <        r_recv_first++;
269 >        *r = r_queue[r_recv_first++];
270          return(1);
271   }
272  
273  
274 < int
275 < ray_presult(r, poll)            /* check for a completed ray */
276 < RAY     *r;
277 < int     poll;
274 > extern int
275 > ray_presult(            /* check for a completed ray */
276 >        RAY     *r,
277 >        int     poll
278 > )
279   {
280          static struct timeval   tpoll;  /* zero timeval struct */
281          static fd_set   readset, errset;
# Line 279 | Line 286 | int    poll;
286                  return(0);
287                                          /* check queued results first */
288          if (r_recv_first < r_recv_next) {
289 <                *r = r_queue[r_recv_first];
283 <                r_recv_first++;
289 >                *r = r_queue[r_recv_first++];
290                  return(1);
291          }
292          n = ray_pnprocs - ray_pnidle;   /* pending before flush? */
# Line 294 | Line 300 | int    poll;
300                  n = ray_pnprocs - ray_pnidle;
301          if (n <= 0)                     /* return if nothing to await */
302                  return(0);
303 +        if (!poll && ray_pnprocs == 1)  /* one process -> skip select() */
304 +                FD_SET(r_proc[0].fd_recv, &readset);
305 +
306   getready:                               /* any children waiting for us? */
307          for (pn = ray_pnprocs; pn--; )
308                  if (FD_ISSET(r_proc[pn].fd_recv, &readset) ||
# Line 354 | Line 363 | getready:                              /* any children waiting for us? */
363                  rp->slights = NULL;
364          }
365                                          /* return first ray received */
366 <        *r = r_queue[r_recv_first];
358 <        r_recv_first++;
366 >        *r = r_queue[r_recv_first++];
367          return(1);
368   }
369  
370  
371 < void
372 < ray_pdone(freall)               /* reap children and free data */
373 < int     freall;
371 > extern void
372 > ray_pdone(              /* reap children and free data */
373 >        int     freall
374 > )
375   {
376          ray_pclose(0);                  /* close child processes */
377  
# Line 375 | Line 384 | int    freall;
384  
385  
386   static void
387 < ray_pchild(fd_in, fd_out)       /* process rays (never returns) */
388 < int     fd_in;
389 < int     fd_out;
387 > ray_pchild(     /* process rays (never returns) */
388 >        int     fd_in,
389 >        int     fd_out
390 > )
391   {
392          int     n;
393          register int    i;
394 +                                        /* flag child process for quit() */
395 +        ray_pnprocs = -1;
396                                          /* read each ray request set */
397          while ((n = read(fd_in, (char *)r_queue, sizeof(r_queue))) > 0) {
398                  int     n2;
399 <                if (n % sizeof(RAY))
399 >                if (n < sizeof(RAY))
400                          break;
389 –                n /= sizeof(RAY);
401                                          /* get smuggled set length */
402 <                n2 = r_queue[0].crtype - n;
402 >                n2 = sizeof(RAY)*r_queue[0].crtype - n;
403                  if (n2 < 0)
404                          error(INTERNAL, "buffer over-read in ray_pchild");
405                  if (n2 > 0) {           /* read the rest of the set */
406 <                        i = readbuf(fd_in, (char *)(r_queue+n),
407 <                                        sizeof(RAY)*n2);
397 <                        if (i != sizeof(RAY)*n2)
406 >                        i = readbuf(fd_in, (char *)r_queue + n, n2);
407 >                        if (i != n2)
408                                  break;
409                          n += n2;
410                  }
411 +                n /= sizeof(RAY);
412                                          /* evaluate rays */
413                  for (i = 0; i < n; i++) {
414                          r_queue[i].crtype = r_queue[i].rtype;
415                          r_queue[i].parent = NULL;
416                          r_queue[i].clipset = NULL;
417                          r_queue[i].slights = NULL;
407 –                        r_queue[i].revf = raytrace;
418                          samplendx++;
419                          rayclear(&r_queue[i]);
420                          rayvalue(&r_queue[i]);
# Line 421 | Line 431 | int    fd_out;
431   }
432  
433  
434 < void
435 < ray_popen(nadd)                 /* open the specified # processes */
436 < int     nadd;
434 > extern void
435 > ray_popen(                      /* open the specified # processes */
436 >        int     nadd
437 > )
438   {
439                                          /* check if our table has room */
440          if (ray_pnprocs + nadd > MAX_NPROCS)
441                  nadd = MAX_NPROCS - ray_pnprocs;
442          if (nadd <= 0)
443                  return;
444 <        fflush(stderr);                 /* clear pending output */
445 <        fflush(stdout);
444 >        ambsync();                      /* load any new ambient values */
445 >        if (shm_boundary == NULL) {     /* first child process? */
446 >                preload_objs();         /* preload auxiliary data */
447 >                                        /* set shared memory boundary */
448 >                shm_boundary = (char *)malloc(16);
449 >                strcpy(shm_boundary, "SHM_BOUNDARY");
450 >        }
451 >        fflush(NULL);                   /* clear pending output */
452          while (nadd--) {                /* fork each new process */
453                  int     p0[2], p1[2];
454                  if (pipe(p0) < 0 || pipe(p1) < 0)
# Line 449 | Line 466 | int    nadd;
466                  if (r_proc[ray_pnprocs].pid < 0)
467                          error(SYSTEM, "cannot fork child process");
468                  close(p1[0]); close(p0[1]);
469 +                /*
470 +                 * Close write stream on exec to avoid multiprocessing deadlock.
471 +                 * No use in read stream without it, so set flag there as well.
472 +                 */
473 +                fcntl(p1[1], F_SETFD, FD_CLOEXEC);
474 +                fcntl(p0[0], F_SETFD, FD_CLOEXEC);
475                  r_proc[ray_pnprocs].fd_send = p1[1];
476                  r_proc[ray_pnprocs].fd_recv = p0[0];
477                  r_proc[ray_pnprocs].npending = 0;
# Line 458 | Line 481 | int    nadd;
481   }
482  
483  
484 < void
485 < ray_pclose(nsub)                /* close one or more child processes */
486 < int     nsub;
484 > extern void
485 > ray_pclose(             /* close one or more child processes */
486 >        int     nsub
487 > )
488   {
489          static int      inclose = 0;
490          RAY     res;
# Line 469 | Line 493 | int    nsub;
493                  return;
494          inclose++;
495                                          /* check argument */
496 <        if ((nsub <= 0 | nsub > ray_pnprocs))
496 >        if ((nsub <= 0) | (nsub > ray_pnprocs))
497                  nsub = ray_pnprocs;
498                                          /* clear our ray queue */
499          while (ray_presult(&res,0) > 0)
# Line 480 | Line 504 | int    nsub;
504                  ray_pnprocs--;
505                  close(r_proc[ray_pnprocs].fd_recv);
506                  close(r_proc[ray_pnprocs].fd_send);
507 <                while (wait(&status) != r_proc[ray_pnprocs].pid)
508 <                        ;
507 >                if (waitpid(r_proc[ray_pnprocs].pid, &status, 0) < 0)
508 >                        status = 127<<8;
509                  if (status) {
510                          sprintf(errmsg,
511                                  "rendering process %d exited with code %d",
# Line 498 | Line 522 | void
522   quit(ec)                        /* make sure exit is called */
523   int     ec;
524   {
525 +        if (ray_pnprocs > 0)    /* close children if any */
526 +                ray_pclose(0);          
527          exit(ec);
528   }

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines