ViewVC Help

View File | Revision Log | Show Annotations | Download File | Root Listing

root/radiance/ray/src/rt/ambient.c

Comparing ray/src/rt/ambient.c (file contents):
Revision 2.33 by greg, Tue Oct 24 13:33:23 1995 UTC vs.
Revision 2.87 by greg, Fri May 9 16:40:01 2014 UTC

#	Line 1 | Line 1
1	–	/* Copyright (c) 1995 Regents of the University of California */
2	–
1		#ifndef lint
2	<	static char SCCSid[] = "$SunId$ LBL";
2	>	static const char       RCSid[] = "$Id$";
3		#endif
6	–
4		/*
5		*  ambient.c - routines dealing with ambient (inter-reflected) component.
6	+	*
7	+	*  Declarations of external symbols in ambient.h
8		*/
9
10	<	#include  "ray.h"
10	>	#include "copyright.h"
11
12	<	#include  "octree.h"
12	>	#include <string.h>
13
14	+	#include  "platform.h"
15	+	#include  "ray.h"
16		#include  "otypes.h"
17	<
17	>	#include  "resolu.h"
18		#include  "ambient.h"
18	–
19		#include  "random.h"
20
21		#ifndef  OCTSCALE
22		#define  OCTSCALE       1.0     /* ceil((valid rad.)/(cube size)) */
23		#endif
24	–	#ifndef  AMBVWT
25	–	#define  AMBVWT         250     /* relative ambient value weight (# calcs) */
26	–	#endif
24
28	–	typedef struct ambtree {
29	–	AMBVAL  *alist;         /* ambient value list */
30	–	struct ambtree  *kid;   /* 8 child nodes */
31	–	}  AMBTREE;                     /* ambient octree */
32	–
33	–	extern CUBE  thescene;          /* contains space boundaries */
34	–
25		extern char  *shm_boundary;     /* memory sharing boundary */
26
27	<	#define  MAXASET        511     /* maximum number of elements in ambient set */
27	>	#ifndef  MAXASET
28	>	#define  MAXASET        4095    /* maximum number of elements in ambient set */
29	>	#endif
30		OBJECT  ambset[MAXASET+1]={0};  /* ambient include/exclude set */
31
32		double  maxarad;                /* maximum ambient radius */
#	Line 46 | Line 38 | static FILE  *ambfp = NULL;    /* ambient file pointer */
38		static int  nunflshed = 0;      /* number of unflushed ambient values */
39
40		#ifndef SORT_THRESH
41	<	#ifdef BIGMEM
42	<	#define SORT_THRESH     ((9L<<20)/sizeof(AMBVAL))
41	>	#ifdef SMLMEM
42	>	#define SORT_THRESH     ((16L<<20)/sizeof(AMBVAL))
43		#else
44	<	#define SORT_THRESH     ((3L<<20)/sizeof(AMBVAL))
44	>	#define SORT_THRESH     ((64L<<20)/sizeof(AMBVAL))
45		#endif
46		#endif
47		#ifndef SORT_INTVL
48	<	#define SORT_INTVL      (SORT_THRESH*256)
48	>	#define SORT_INTVL      (SORT_THRESH<<1)
49		#endif
50		#ifndef MAX_SORT_INTVL
51	<	#define MAX_SORT_INTVL  (SORT_INTVL<<4)
51	>	#define MAX_SORT_INTVL  (SORT_INTVL<<6)
52		#endif
53
54	<	static COLOR  avsum = BLKCOLOR;         /* computed ambient value sum */
55	<	static unsigned int  nambvals = 0;      /* number of computed ambient values */
54	>
55	>	static double  avsum = 0.;              /* computed ambient value sum (log) */
56	>	static unsigned int  navsum = 0;        /* number of values in avsum */
57	>	static unsigned int  nambvals = 0;      /* total number of indirect values */
58	>	static unsigned int  nambshare = 0;     /* number of values from file */
59		static unsigned long  ambclock = 0;     /* ambient access clock */
60		static unsigned long  lastsort = 0;     /* time of last value sort */
61		static long  sortintvl = SORT_INTVL;    /* time until next sort */
62	+	static FILE  *ambinp = NULL;            /* auxiliary file for input */
63	+	static long  lastpos = -1;              /* last flush position */
64
65		#define MAXACLOCK       (1L<<30)        /* clock turnover value */
66		/*
67		* Track access times unless we are sharing ambient values
68		* through memory on a multiprocessor, when we want to avoid
69	<	* claiming our own memory (copy on write).
69	>	* claiming our own memory (copy on write).  Go ahead anyway
70	>	* if more than two thirds of our values are unshared.
71	>	* Compile with -Dtracktime=0 to turn this code off.
72		*/
73	<	#define tracktime       (shm_boundary == NULL || ambfp == NULL)
73	>	#ifndef tracktime
74	>	#define tracktime       (shm_boundary == NULL || nambvals > 3*nambshare)
75	>	#endif
76
77		#define  AMBFLUSH       (BUFSIZ/AMBVALSIZ)
78
79	<	#define  newambval()    (AMBVAL *)bmalloc(sizeof(AMBVAL))
79	>	#define  newambval()    (AMBVAL *)malloc(sizeof(AMBVAL))
80	>	#define  freeav(av)     free((void *)av);
81
82	<	extern long  ftell(), lseek();
83	<	static int  initambfile(), avsave(), avinsert(), sortambvals();
84	<	static AMBVAL  *avstore();
82	>	static void initambfile(int creat);
83	>	static void avsave(AMBVAL *av);
84	>	static AMBVAL *avstore(AMBVAL  *aval);
85	>	static AMBTREE *newambtree(void);
86	>	static void freeambtree(AMBTREE  *atp);
87	>
88	>	typedef void unloadtf_t(AMBVAL *);
89	>	static unloadtf_t avinsert;
90	>	static unloadtf_t av2list;
91	>	static unloadtf_t avfree;
92	>	static void unloadatree(AMBTREE  *at, unloadtf_t *f);
93	>
94	>	static int aposcmp(const void *avp1, const void *avp2);
95	>	static int avlmemi(AMBVAL *avaddr);
96	>	static void sortambvals(int always);
97	>
98		#ifdef  F_SETLKW
99	<	static  aflock();
99	>	static void aflock(int  typ);
100		#endif
101
102
103	<	setambres(ar)                           /* set ambient resolution */
104	<	int  ar;
103	>	void
104	>	setambres(                              /* set ambient resolution */
105	>	int  ar
106	>	)
107		{
108		ambres = ar < 0 ? 0 : ar;               /* may be done already */
109		/* set min & max radii */
110		if (ar <= 0) {
111		minarad = 0;
112	<	maxarad = thescene.cusize / 2.0;
112	>	maxarad = thescene.cusize*0.5;
113		} else {
114		minarad = thescene.cusize / ar;
115	<	maxarad = 64 * minarad;                 /* heuristic */
116	<	if (maxarad > thescene.cusize / 2.0)
117	<	maxarad = thescene.cusize / 2.0;
115	>	maxarad = 64.0 * minarad;               /* heuristic */
116	>	if (maxarad > thescene.cusize*0.5)
117	>	maxarad = thescene.cusize*0.5;
118		}
119		if (minarad <= FTINY)
120	<	minarad = 10*FTINY;
120	>	minarad = 10.0*FTINY;
121		if (maxarad <= minarad)
122	<	maxarad = 64 * minarad;
122	>	maxarad = 64.0 * minarad;
123		}
124
125
126	<	setambacc(newa)                         /* set ambient accuracy */
127	<	double  newa;
126	>	void
127	>	setambacc(                              /* set ambient accuracy */
128	>	double  newa
129	>	)
130		{
131	<	double  ambdiff;
132	<
133	<	if (newa < 0.0)
134	<	newa = 0.0;
135	<	ambdiff = fabs(newa - ambacc);
136	<	if (ambdiff >= .01 && (ambacc = newa) > FTINY && nambvals > 0)
137	<	sortambvals(1);                 /* rebuild tree */
131	>	static double   olda;           /* remember previous setting here */
132	>
133	>	newa *= (newa > 0);
134	>	if (fabs(newa - olda) >= .05*(newa + olda)) {
135	>	ambacc = newa;
136	>	if (nambvals > 0)
137	>	sortambvals(1);         /* rebuild tree */
138	>	}
139		}
140
141
142	<	setambient(afile)                       /* initialize calculation */
143	<	char  *afile;
142	>	void
143	>	setambient(void)                                /* initialize calculation */
144		{
145	<	long  headlen;
145	>	int     readonly = 0;
146	>	long    flen;
147		AMBVAL  amb;
148	+	/* make sure we're fresh */
149	+	ambdone();
150		/* init ambient limits */
151		setambres(ambres);
152		setambacc(ambacc);
153	<	if (afile == NULL)
153	>	if (ambfile == NULL || !ambfile[0])
154		return;
155		if (ambacc <= FTINY) {
156		sprintf(errmsg, "zero ambient accuracy so \"%s\" not opened",
157	<	afile);
157	>	ambfile);
158		error(WARNING, errmsg);
159		return;
160		}
161		/* open ambient file */
162	<	if ((ambfp = fopen(afile, "r+")) != NULL) {
163	<	initambfile(0);
164	<	headlen = ftell(ambfp);
162	>	if ((ambfp = fopen(ambfile, "r+")) == NULL)
163	>	readonly = (ambfp = fopen(ambfile, "r")) != NULL;
164	>	if (ambfp != NULL) {
165	>	initambfile(0);                 /* file exists */
166	>	lastpos = ftell(ambfp);
167		while (readambval(&amb, ambfp))
168		avinsert(avstore(&amb));
169	<	/* align */
170	<	fseek(ambfp, -((ftell(ambfp)-headlen)%AMBVALSIZ), 1);
171	<	} else if ((ambfp = fopen(afile, "w+")) != NULL)
172	<	initambfile(1);
173	<	else {
174	<	sprintf(errmsg, "cannot open ambient file \"%s\"", afile);
169	>	nambshare = nambvals;           /* share loaded values */
170	>	if (readonly) {
171	>	sprintf(errmsg,
172	>	"loaded %u values from read-only ambient file",
173	>	nambvals);
174	>	error(WARNING, errmsg);
175	>	fclose(ambfp);          /* close file so no writes */
176	>	ambfp = NULL;
177	>	return;                 /* avoid ambsync() */
178	>	}
179	>	/* align file pointer */
180	>	lastpos += (long)nambvals*AMBVALSIZ;
181	>	flen = lseek(fileno(ambfp), (off_t)0, SEEK_END);
182	>	if (flen != lastpos) {
183	>	sprintf(errmsg,
184	>	"ignoring last %ld values in ambient file (corrupted)",
185	>	(flen - lastpos)/AMBVALSIZ);
186	>	error(WARNING, errmsg);
187	>	fseek(ambfp, lastpos, SEEK_SET);
188	>	#ifndef _WIN32 /* XXX we need a replacement for that one */
189	>	ftruncate(fileno(ambfp), (off_t)lastpos);
190	>	#endif
191	>	}
192	>	} else if ((ambfp = fopen(ambfile, "w+")) != NULL) {
193	>	initambfile(1);                 /* else create new file */
194	>	fflush(ambfp);
195	>	lastpos = ftell(ambfp);
196	>	} else {
197	>	sprintf(errmsg, "cannot open ambient file \"%s\"", ambfile);
198		error(SYSTEM, errmsg);
199		}
200	<	nunflshed++;    /* lie */
201	<	ambsync();
200	>	#ifdef getc_unlocked
201	>	flockfile(ambfp);                       /* application-level lock */
202	>	#endif
203	>	#ifdef  F_SETLKW
204	>	aflock(F_UNLCK);                        /* release file */
205	>	#endif
206		}
207
208
209	<	ambnotify(obj)                  /* record new modifier */
210	<	OBJECT  obj;
209	>	void
210	>	ambdone(void)                   /* close ambient file and free memory */
211		{
212	+	if (ambfp != NULL) {            /* close ambient file */
213	+	ambsync();
214	+	fclose(ambfp);
215	+	ambfp = NULL;
216	+	if (ambinp != NULL) {
217	+	fclose(ambinp);
218	+	ambinp = NULL;
219	+	}
220	+	lastpos = -1;
221	+	}
222	+	/* free ambient tree */
223	+	unloadatree(&atrunk, &avfree);
224	+	/* reset state variables */
225	+	avsum = 0.;
226	+	navsum = 0;
227	+	nambvals = 0;
228	+	nambshare = 0;
229	+	ambclock = 0;
230	+	lastsort = 0;
231	+	sortintvl = SORT_INTVL;
232	+	}
233	+
234	+
235	+	void
236	+	ambnotify(                      /* record new modifier */
237	+	OBJECT  obj
238	+	)
239	+	{
240		static int  hitlimit = 0;
241	<	register OBJREC  *o = objptr(obj);
242	<	register char  **amblp;
241	>	OBJREC   *o;
242	>	char  **amblp;
243
244	+	if (obj == OVOID) {             /* starting over */
245	+	ambset[0] = 0;
246	+	hitlimit = 0;
247	+	return;
248	+	}
249	+	o = objptr(obj);
250		if (hitlimit || !ismodifier(o->otype))
251		return;
252		for (amblp = amblist; *amblp != NULL; amblp++)
#	Line 175 | Line 261 | OBJECT obj;
261		}
262		}
263
264	+	/************ THE FOLLOWING ROUTINES DIFFER BETWEEN NEW & OLD ***************/
265
266	<	ambient(acol, r)                /* compute ambient component for ray */
267	<	COLOR  acol;
268	<	register RAY  *r;
266	>	#ifdef NEWAMB
267	>
268	>	#define tfunc(lwr, x, upr)      (((x)-(lwr))/((upr)-(lwr)))
269	>
270	>	static int      plugaleak(RAY *r, AMBVAL *ap, FVECT anorm, double ang);
271	>	static double   sumambient(COLOR acol, RAY *r, FVECT rn, int al,
272	>	AMBTREE *at, FVECT c0, double s);
273	>	static int      makeambient(COLOR acol, RAY *r, FVECT rn, int al);
274	>	static void     extambient(COLOR cr, AMBVAL *ap, FVECT pv, FVECT nv,
275	>	FVECT uvw[3]);
276	>
277	>	void
278	>	multambient(            /* compute ambient component & multiply by coef. */
279	>	COLOR  aval,
280	>	RAY  *r,
281	>	FVECT  nrm
282	>	)
283		{
284		static int  rdepth = 0;                 /* ambient recursion */
285	<	double  d;
285	>	COLOR   acol;
286	>	int     ok;
287	>	double  d, l;
288
289		if (ambdiv <= 0)                        /* no ambient calculation */
290		goto dumbamb;
#	Line 194 | Line 297 | register RAY  *r;
297		goto dumbamb;
298
299		if (ambacc <= FTINY) {                  /* no ambient storage */
300	+	copycolor(acol, aval);
301		rdepth++;
302	+	ok = doambient(acol, r, r->rweight,
303	+	NULL, NULL, NULL, NULL, NULL);
304	+	rdepth--;
305	+	if (!ok)
306	+	goto dumbamb;
307	+	copycolor(aval, acol);
308	+	return;
309	+	}
310	+
311	+	if (tracktime)                          /* sort to minimize thrashing */
312	+	sortambvals(0);
313	+	/* interpolate ambient value */
314	+	setcolor(acol, 0.0, 0.0, 0.0);
315	+	d = sumambient(acol, r, nrm, rdepth,
316	+	&atrunk, thescene.cuorg, thescene.cusize);
317	+	if (d > FTINY) {
318	+	d = 1.0/d;
319	+	scalecolor(acol, d);
320	+	multcolor(aval, acol);
321	+	return;
322	+	}
323	+	rdepth++;                               /* need to cache new value */
324	+	ok = makeambient(acol, r, nrm, rdepth-1);
325	+	rdepth--;
326	+	if (ok) {
327	+	multcolor(aval, acol);          /* computed new value */
328	+	return;
329	+	}
330	+	dumbamb:                                        /* return global value */
331	+	if ((ambvwt <= 0) | (navsum == 0)) {
332	+	multcolor(aval, ambval);
333	+	return;
334	+	}
335	+	l = bright(ambval);                     /* average in computations */
336	+	if (l > FTINY) {
337	+	d = (log(l)*(double)ambvwt + avsum) /
338	+	(double)(ambvwt + navsum);
339	+	d = exp(d) / l;
340	+	scalecolor(aval, d);
341	+	multcolor(aval, ambval);        /* apply color of ambval */
342	+	} else {
343	+	d = exp( avsum / (double)navsum );
344	+	scalecolor(aval, d);            /* neutral color */
345	+	}
346	+	}
347	+
348	+
349	+	/* Plug a potential leak where ambient cache value is occluded */
350	+	static int
351	+	plugaleak(RAY *r, AMBVAL *ap, FVECT anorm, double ang)
352	+	{
353	+	const double    cost70sq = 0.1169778;   /* cos(70deg)^2 */
354	+	RAY             rtst;
355	+	FVECT           vdif;
356	+	double          normdot, ndotd, nadotd;
357	+	double          a, b, c, t[2];
358	+
359	+	ang += 2.*PI*(ang < 0);                 /* check direction flags */
360	+	if ( !(ap->corral>>(int)(ang*(16./PI)) & 1) )
361	+	return(0);
362	+	/*
363	+	* Generate test ray, targeting 20 degrees above sample point plane
364	+	* along surface normal from cache position.  This should be high
365	+	* enough to miss local geometry we don't really care about.
366	+	*/
367	+	VSUB(vdif, ap->pos, r->rop);
368	+	normdot = DOT(anorm, r->ron);
369	+	ndotd = DOT(vdif, r->ron);
370	+	nadotd = DOT(vdif, anorm);
371	+	a = normdot*normdot - cost70sq;
372	+	b = 2.0*(normdot*ndotd - nadotd*cost70sq);
373	+	c = ndotd*ndotd - DOT(vdif,vdif)*cost70sq;
374	+	if (quadratic(t, a, b, c) != 2)
375	+	return(1);                      /* should rarely happen */
376	+	if (t[1] <= FTINY)
377	+	return(0);                      /* should fail behind test */
378	+	rayorigin(&rtst, SHADOW, r, NULL);
379	+	VSUM(rtst.rdir, vdif, anorm, t[1]);     /* further dist. > plane */
380	+	rtst.rmax = normalize(rtst.rdir);       /* short ray test */
381	+	while (localhit(&rtst, &thescene)) {    /* check for occluder */
382	+	if (rtst.ro->omod != OVOID &&
383	+	(rtst.clipset == NULL ||
384	+	!inset(rtst.clipset, rtst.ro->omod)))
385	+	return(1);              /* plug light leak */
386	+	VCOPY(rtst.rorg, rtst.rop);     /* skip invisible surface */
387	+	rtst.rmax -= rtst.rot;
388	+	rayclear(&rtst);
389	+	}
390	+	return(0);                              /* seems we're OK */
391	+	}
392	+
393	+
394	+	static double
395	+	sumambient(             /* get interpolated ambient value */
396	+	COLOR  acol,
397	+	RAY  *r,
398	+	FVECT  rn,
399	+	int  al,
400	+	AMBTREE  *at,
401	+	FVECT  c0,
402	+	double  s
403	+	)
404	+	{                       /* initial limit is 10 degrees plus ambacc radians */
405	+	const double    minangle = 10.0 * PI/180.;
406	+	double          maxangle = minangle + ambacc;
407	+	double          wsum = 0.0;
408	+	FVECT           ck0;
409	+	int             i, j;
410	+	AMBVAL          *av;
411	+
412	+	if (at->kid != NULL) {          /* sum children first */
413	+	s *= 0.5;
414	+	for (i = 0; i < 8; i++) {
415	+	for (j = 0; j < 3; j++) {
416	+	ck0[j] = c0[j];
417	+	if (1<<j & i)
418	+	ck0[j] += s;
419	+	if (r->rop[j] < ck0[j] - OCTSCALE*s)
420	+	break;
421	+	if (r->rop[j] > ck0[j] + (1.0+OCTSCALE)*s)
422	+	break;
423	+	}
424	+	if (j == 3)
425	+	wsum += sumambient(acol, r, rn, al,
426	+	at->kid+i, ck0, s);
427	+	}
428	+	/* good enough? */
429	+	if (wsum >= 0.05 && s > minarad*10.0)
430	+	return(wsum);
431	+	}
432	+	/* adjust maximum angle */
433	+	if (at->alist != NULL && (at->alist->lvl <= al) & (r->rweight < 0.6))
434	+	maxangle = (maxangle - PI/2.)*pow(r->rweight,0.13) + PI/2.;
435	+	/* sum this node */
436	+	for (av = at->alist; av != NULL; av = av->next) {
437	+	double  u, v, d, delta_r2, delta_t2;
438	+	COLOR   ct;
439	+	FVECT   uvw[3];
440	+	/* record access */
441	+	if (tracktime)
442	+	av->latick = ambclock;
443	+	/*
444	+	*  Ambient level test
445	+	*/
446	+	if (av->lvl > al ||     /* list sorted, so this works */
447	+	(av->lvl == al) & (av->weight < 0.9*r->rweight))
448	+	break;
449	+	/*
450	+	*  Direction test using unperturbed normal
451	+	*/
452	+	decodedir(uvw[2], av->ndir);
453	+	d = DOT(uvw[2], r->ron);
454	+	if (d <= 0.0)           /* >= 90 degrees */
455	+	continue;
456	+	delta_r2 = 2.0 - 2.0*d; /* approx. radians^2 */
457	+	if (delta_r2 >= maxangle*maxangle)
458	+	continue;
459	+	/*
460	+	*  Modified ray behind test
461	+	*/
462	+	VSUB(ck0, r->rop, av->pos);
463	+	d = DOT(ck0, uvw[2]);
464	+	if (d < -minarad*ambacc-.001)
465	+	continue;
466	+	d /= av->rad[0];
467	+	delta_t2 = d*d;
468	+	if (delta_t2 >= ambacc*ambacc)
469	+	continue;
470	+	/*
471	+	*  Elliptical radii test based on Hessian
472	+	*/
473	+	decodedir(uvw[0], av->udir);
474	+	VCROSS(uvw[1], uvw[2], uvw[0]);
475	+	d = (u = DOT(ck0, uvw[0])) / av->rad[0];
476	+	delta_t2 += d*d;
477	+	d = (v = DOT(ck0, uvw[1])) / av->rad[1];
478	+	delta_t2 += d*d;
479	+	if (delta_t2 >= ambacc*ambacc)
480	+	continue;
481	+	/*
482	+	*  Test for potential light leak
483	+	*/
484	+	if (av->corral && plugaleak(r, av, uvw[2], atan2a(v,u)))
485	+	continue;
486	+	/*
487	+	*  Extrapolate value and compute final weight (hat function)
488	+	*/
489	+	extambient(ct, av, r->rop, rn, uvw);
490	+	d = tfunc(maxangle, sqrt(delta_r2), 0.0) *
491	+	tfunc(ambacc, sqrt(delta_t2), 0.0);
492	+	scalecolor(ct, d);
493	+	addcolor(acol, ct);
494	+	wsum += d;
495	+	}
496	+	return(wsum);
497	+	}
498	+
499	+
500	+	static int
501	+	makeambient(            /* make a new ambient value for storage */
502	+	COLOR  acol,
503	+	RAY  *r,
504	+	FVECT  rn,
505	+	int  al
506	+	)
507	+	{
508	+	AMBVAL  amb;
509	+	FVECT   uvw[3];
510	+	int     i;
511	+
512	+	amb.weight = 1.0;                       /* compute weight */
513	+	for (i = al; i-- > 0; )
514	+	amb.weight *= AVGREFL;
515	+	if (r->rweight < 0.1*amb.weight)        /* heuristic override */
516	+	amb.weight = 1.25*r->rweight;
517	+	setcolor(acol, AVGREFL, AVGREFL, AVGREFL);
518	+	/* compute ambient */
519	+	i = doambient(acol, r, amb.weight,
520	+	uvw, amb.rad, amb.gpos, amb.gdir, &amb.corral);
521	+	scalecolor(acol, 1./AVGREFL);           /* undo assumed reflectance */
522	+	if (i <= 0 || amb.rad[0] <= FTINY)      /* no Hessian or zero radius */
523	+	return(i);
524	+	/* store value */
525	+	VCOPY(amb.pos, r->rop);
526	+	amb.ndir = encodedir(r->ron);
527	+	amb.udir = encodedir(uvw[0]);
528	+	amb.lvl = al;
529	+	copycolor(amb.val, acol);
530	+	/* insert into tree */
531	+	avsave(&amb);                           /* and save to file */
532	+	if (rn != r->ron) {                     /* texture */
533	+	VCOPY(uvw[2], r->ron);
534	+	extambient(acol, &amb, r->rop, rn, uvw);
535	+	}
536	+	return(1);
537	+	}
538	+
539	+
540	+	static void
541	+	extambient(             /* extrapolate value at pv, nv */
542	+	COLOR  cr,
543	+	AMBVAL   *ap,
544	+	FVECT  pv,
545	+	FVECT  nv,
546	+	FVECT  uvw[3]
547	+	)
548	+	{
549	+	static FVECT    my_uvw[3];
550	+	FVECT           v1;
551	+	int             i;
552	+	double          d = 1.0;        /* zeroeth order */
553	+
554	+	if (uvw == NULL) {              /* need local coordinates? */
555	+	decodedir(my_uvw[2], ap->ndir);
556	+	decodedir(my_uvw[0], ap->udir);
557	+	VCROSS(my_uvw[1], my_uvw[2], my_uvw[0]);
558	+	uvw = my_uvw;
559	+	}
560	+	for (i = 3; i--; )              /* gradient due to translation */
561	+	d += (pv[i] - ap->pos[i]) *
562	+	(ap->gpos[0]*uvw[0][i] + ap->gpos[1]*uvw[1][i]);
563	+
564	+	VCROSS(v1, uvw[2], nv);         /* gradient due to rotation */
565	+	for (i = 3; i--; )
566	+	d += v1[i] * (ap->gdir[0]*uvw[0][i] + ap->gdir[1]*uvw[1][i]);
567	+
568	+	if (d <= 0.0) {
569	+	setcolor(cr, 0.0, 0.0, 0.0);
570	+	return;
571	+	}
572	+	copycolor(cr, ap->val);
573	+	scalecolor(cr, d);
574	+	}
575	+
576	+
577	+	static void
578	+	avinsert(                               /* insert ambient value in our tree */
579	+	AMBVAL *av
580	+	)
581	+	{
582	+	AMBTREE  *at;
583	+	AMBVAL  *ap;
584	+	AMBVAL  avh;
585	+	FVECT  ck0;
586	+	double  s;
587	+	int  branch;
588	+	int  i;
589	+
590	+	if (av->rad[0] <= FTINY)
591	+	error(CONSISTENCY, "zero ambient radius in avinsert");
592	+	at = &atrunk;
593	+	VCOPY(ck0, thescene.cuorg);
594	+	s = thescene.cusize;
595	+	while (s*(OCTSCALE/2) > av->rad[1]*ambacc) {
596	+	if (at->kid == NULL)
597	+	if ((at->kid = newambtree()) == NULL)
598	+	error(SYSTEM, "out of memory in avinsert");
599	+	s *= 0.5;
600	+	branch = 0;
601	+	for (i = 0; i < 3; i++)
602	+	if (av->pos[i] > ck0[i] + s) {
603	+	ck0[i] += s;
604	+	branch |= 1 << i;
605	+	}
606	+	at = at->kid + branch;
607	+	}
608	+	avh.next = at->alist;           /* order by increasing level */
609	+	for (ap = &avh; ap->next != NULL; ap = ap->next)
610	+	if ( ap->next->lvl > av->lvl ||
611	+	(ap->next->lvl == av->lvl) &
612	+	(ap->next->weight <= av->weight) )
613	+	break;
614	+	av->next = ap->next;
615	+	ap->next = (AMBVAL*)av;
616	+	at->alist = avh.next;
617	+	}
618	+
619	+
620	+	#else /* ! NEWAMB */
621	+
622	+	static double   sumambient(COLOR acol, RAY *r, FVECT rn, int al,
623	+	AMBTREE *at, FVECT c0, double s);
624	+	static double   makeambient(COLOR acol, RAY *r, FVECT rn, int al);
625	+	static void     extambient(COLOR cr, AMBVAL *ap, FVECT pv, FVECT nv);
626	+
627	+
628	+	void
629	+	multambient(            /* compute ambient component & multiply by coef. */
630	+	COLOR  aval,
631	+	RAY  *r,
632	+	FVECT  nrm
633	+	)
634	+	{
635	+	static int  rdepth = 0;                 /* ambient recursion */
636	+	COLOR   acol;
637	+	double  d, l;
638	+
639	+	if (ambdiv <= 0)                        /* no ambient calculation */
640	+	goto dumbamb;
641	+	/* check number of bounces */
642	+	if (rdepth >= ambounce)
643	+	goto dumbamb;
644	+	/* check ambient list */
645	+	if (ambincl != -1 && r->ro != NULL &&
646	+	ambincl != inset(ambset, r->ro->omod))
647	+	goto dumbamb;
648	+
649	+	if (ambacc <= FTINY) {                  /* no ambient storage */
650	+	copycolor(acol, aval);
651	+	rdepth++;
652		d = doambient(acol, r, r->rweight, NULL, NULL);
653		rdepth--;
654		if (d <= FTINY)
655		goto dumbamb;
656	+	copycolor(aval, acol);
657		return;
658		}
659	<	/* resort memory? */
660	<	sortambvals(0);
661	<	/* get ambient value */
659	>
660	>	if (tracktime)                          /* sort to minimize thrashing */
661	>	sortambvals(0);
662	>	/* interpolate ambient value */
663		setcolor(acol, 0.0, 0.0, 0.0);
664	<	d = sumambient(acol, r, rdepth,
664	>	d = sumambient(acol, r, nrm, rdepth,
665		&atrunk, thescene.cuorg, thescene.cusize);
666		if (d > FTINY) {
667	<	scalecolor(acol, 1.0/d);
667	>	d = 1.0/d;
668	>	scalecolor(acol, d);
669	>	multcolor(aval, acol);
670		return;
671		}
672		rdepth++;                               /* need to cache new value */
673	<	d = makeambient(acol, r, rdepth-1);
673	>	d = makeambient(acol, r, nrm, rdepth-1);
674		rdepth--;
675	<	if (d > FTINY)
675	>	if (d > FTINY) {
676	>	multcolor(aval, acol);          /* got new value */
677		return;
678	+	}
679		dumbamb:                                        /* return global value */
680	<	copycolor(acol, ambval);
681	<	#if  AMBVWT
222	<	if (nambvals == 0)
680	>	if ((ambvwt <= 0) | (navsum == 0)) {
681	>	multcolor(aval, ambval);
682		return;
683	<	scalecolor(acol, (double)AMBVWT);
684	<	addcolor(acol, avsum);                  /* average in computations */
685	<	d = 1.0/(AMBVWT+nambvals);
686	<	scalecolor(acol, d);
687	<	#endif
683	>	}
684	>	l = bright(ambval);                     /* average in computations */
685	>	if (l > FTINY) {
686	>	d = (log(l)*(double)ambvwt + avsum) /
687	>	(double)(ambvwt + navsum);
688	>	d = exp(d) / l;
689	>	scalecolor(aval, d);
690	>	multcolor(aval, ambval);        /* apply color of ambval */
691	>	} else {
692	>	d = exp( avsum / (double)navsum );
693	>	scalecolor(aval, d);            /* neutral color */
694	>	}
695		}
696
697
698	<	double
699	<	sumambient(acol, r, al, at, c0, s)      /* get interpolated ambient value */
700	<	COLOR  acol;
701	<	register RAY  *r;
702	<	int  al;
703	<	AMBTREE  *at;
704	<	FVECT  c0;
705	<	double  s;
698	>	static double
699	>	sumambient(     /* get interpolated ambient value */
700	>	COLOR  acol,
701	>	RAY  *r,
702	>	FVECT  rn,
703	>	int  al,
704	>	AMBTREE  *at,
705	>	FVECT  c0,
706	>	double  s
707	>	)
708		{
709		double  d, e1, e2, wt, wsum;
710		COLOR  ct;
711		FVECT  ck0;
712		int  i;
713	<	register int  j;
714	<	register AMBVAL  *av;
713	>	int  j;
714	>	AMBVAL   *av;
715
716		wsum = 0.0;
717		/* do this node */
718		for (av = at->alist; av != NULL; av = av->next) {
719	+	double  rn_dot = -2.0;
720		if (tracktime)
721	<	av->latick = ambclock++;
721	>	av->latick = ambclock;
722		/*
723		*  Ambient level test.
724		*/
725	<	if (av->lvl > al)       /* list sorted, so this works */
725	>	if (av->lvl > al ||     /* list sorted, so this works */
726	>	(av->lvl == al) & (av->weight < 0.9*r->rweight))
727		break;
258	–	if (av->weight < r->rweight-FTINY)
259	–	continue;
728		/*
729		*  Ambient radius test.
730		*/
731	<	d = av->pos[0] - r->rop[0];
732	<	e1 = d * d;
265	<	d = av->pos[1] - r->rop[1];
266	<	e1 += d * d;
267	<	d = av->pos[2] - r->rop[2];
268	<	e1 += d * d;
269	<	e1 /= av->rad * av->rad;
731	>	VSUB(ck0, av->pos, r->rop);
732	>	e1 = DOT(ck0, ck0) / (av->rad * av->rad);
733		if (e1 > ambacc*ambacc*1.21)
734		continue;
735		/*
736	<	*  Normal direction test.
736	>	*  Direction test using closest normal.
737		*/
738	<	e2 = (1.0 - DOT(av->dir, r->ron)) * r->rweight;
739	<	if (e2 < 0.0) e2 = 0.0;
740	<	if (e1 + e2 > ambacc*ambacc*1.21)
738	>	d = DOT(av->dir, r->ron);
739	>	if (rn != r->ron) {
740	>	rn_dot = DOT(av->dir, rn);
741	>	if (rn_dot > 1.0-FTINY)
742	>	rn_dot = 1.0-FTINY;
743	>	if (rn_dot >= d-FTINY) {
744	>	d = rn_dot;
745	>	rn_dot = -2.0;
746	>	}
747	>	}
748	>	e2 = (1.0 - d) * r->rweight;
749	>	if (e2 < 0.0)
750	>	e2 = 0.0;
751	>	else if (e1 + e2 > ambacc*ambacc*1.21)
752		continue;
753		/*
754		*  Ray behind test.
#	Line 288 | Line 762 | double s;
762		/*
763		*  Jittering final test reduces image artifacts.
764		*/
765	<	wt = sqrt(e1) + sqrt(e2);
765	>	e1 = sqrt(e1);
766	>	e2 = sqrt(e2);
767	>	wt = e1 + e2;
768		if (wt > ambacc*(.9+.2*urand(9015+samplendx)))
769		continue;
770	+	/*
771	+	*  Recompute directional error using perturbed normal
772	+	*/
773	+	if (rn_dot > 0.0) {
774	+	e2 = sqrt((1.0 - rn_dot)*r->rweight);
775	+	wt = e1 + e2;
776	+	}
777		if (wt <= 1e-3)
778		wt = 1e3;
779		else
780		wt = 1.0 / wt;
781		wsum += wt;
782	<	extambient(ct, av, r->rop, r->ron);
782	>	extambient(ct, av, r->rop, rn);
783		scalecolor(ct, wt);
784		addcolor(acol, ct);
785		}
#	Line 315 | Line 798 | double s;
798		break;
799		}
800		if (j == 3)
801	<	wsum += sumambient(acol, r, al, at->kid+i, ck0, s);
801	>	wsum += sumambient(acol, r, rn, al,
802	>	at->kid+i, ck0, s);
803		}
804		return(wsum);
805		}
806
807
808	<	double
809	<	makeambient(acol, r, al)        /* make a new ambient value */
810	<	COLOR  acol;
811	<	register RAY  *r;
812	<	int  al;
808	>	static double
809	>	makeambient(            /* make a new ambient value for storage */
810	>	COLOR  acol,
811	>	RAY  *r,
812	>	FVECT  rn,
813	>	int  al
814	>	)
815		{
816		AMBVAL  amb;
817		FVECT   gp, gd;
818	<	/* compute weight */
819	<	amb.weight = pow(AVGREFL, (double)al);
820	<	if (r->rweight < 0.1*amb.weight)        /* heuristic */
821	<	amb.weight = r->rweight;
818	>	int     i;
819	>
820	>	amb.weight = 1.0;                       /* compute weight */
821	>	for (i = al; i-- > 0; )
822	>	amb.weight *= AVGREFL;
823	>	if (r->rweight < 0.1*amb.weight)        /* heuristic override */
824	>	amb.weight = 1.25*r->rweight;
825	>	setcolor(acol, AVGREFL, AVGREFL, AVGREFL);
826		/* compute ambient */
827		amb.rad = doambient(acol, r, amb.weight, gp, gd);
828	<	if (amb.rad <= FTINY)
828	>	if (amb.rad <= FTINY) {
829	>	setcolor(acol, 0.0, 0.0, 0.0);
830		return(0.0);
831	<	/* store it */
831	>	}
832	>	scalecolor(acol, 1./AVGREFL);           /* undo assumed reflectance */
833	>	/* store value */
834		VCOPY(amb.pos, r->rop);
835		VCOPY(amb.dir, r->ron);
836		amb.lvl = al;
#	Line 346 | Line 839 | int  al;
839		VCOPY(amb.gdir, gd);
840		/* insert into tree */
841		avsave(&amb);                           /* and save to file */
842	+	if (rn != r->ron)
843	+	extambient(acol, &amb, r->rop, rn);     /* texture */
844		return(amb.rad);
845		}
846
847
848	<	extambient(cr, ap, pv, nv)              /* extrapolate value at pv, nv */
849	<	COLOR  cr;
850	<	register AMBVAL  *ap;
851	<	FVECT  pv, nv;
848	>	static void
849	>	extambient(             /* extrapolate value at pv, nv */
850	>	COLOR  cr,
851	>	AMBVAL   *ap,
852	>	FVECT  pv,
853	>	FVECT  nv
854	>	)
855		{
856	<	FVECT  v1, v2;
857	<	register int  i;
856	>	FVECT  v1;
857	>	int  i;
858		double  d;
859
860		d = 1.0;                        /* zeroeth order */
#	Line 364 | Line 862 | FVECT  pv, nv;
862		for (i = 0; i < 3; i++)
863		d += ap->gpos[i]*(pv[i]-ap->pos[i]);
864		/* gradient due to rotation */
865	<	VCOPY(v1, ap->dir);
866	<	fcross(v2, v1, nv);
369	<	d += DOT(ap->gdir, v2);
865	>	VCROSS(v1, ap->dir, nv);
866	>	d += DOT(ap->gdir, v1);
867		if (d <= 0.0) {
868		setcolor(cr, 0.0, 0.0, 0.0);
869		return;
#	Line 376 | Line 873 | FVECT  pv, nv;
873		}
874
875
876	<	static
877	<	initambfile(creat)              /* initialize ambient file */
878	<	int  creat;
876	>	static void
877	>	avinsert(                               /* insert ambient value in our tree */
878	>	AMBVAL *av
879	>	)
880		{
881	<	extern char  *progname, *octname, VersionID[];
881	>	AMBTREE  *at;
882	>	AMBVAL  *ap;
883	>	AMBVAL  avh;
884	>	FVECT  ck0;
885	>	double  s;
886	>	int  branch;
887	>	int  i;
888
889	+	if (av->rad <= FTINY)
890	+	error(CONSISTENCY, "zero ambient radius in avinsert");
891	+	at = &atrunk;
892	+	VCOPY(ck0, thescene.cuorg);
893	+	s = thescene.cusize;
894	+	while (s*(OCTSCALE/2) > av->rad*ambacc) {
895	+	if (at->kid == NULL)
896	+	if ((at->kid = newambtree()) == NULL)
897	+	error(SYSTEM, "out of memory in avinsert");
898	+	s *= 0.5;
899	+	branch = 0;
900	+	for (i = 0; i < 3; i++)
901	+	if (av->pos[i] > ck0[i] + s) {
902	+	ck0[i] += s;
903	+	branch |= 1 << i;
904	+	}
905	+	at = at->kid + branch;
906	+	}
907	+	avh.next = at->alist;           /* order by increasing level */
908	+	for (ap = &avh; ap->next != NULL; ap = ap->next)
909	+	if ( ap->next->lvl > av->lvl ||
910	+	(ap->next->lvl == av->lvl) &
911	+	(ap->next->weight <= av->weight) )
912	+	break;
913	+	av->next = ap->next;
914	+	ap->next = (AMBVAL*)av;
915	+	at->alist = avh.next;
916	+	}
917	+
918	+	#endif  /* ! NEWAMB */
919	+
920	+	/************* FOLLOWING ROUTINES SAME FOR NEW & OLD METHODS ***************/
921	+
922	+	static void
923	+	initambfile(            /* initialize ambient file */
924	+	int  cre8
925	+	)
926	+	{
927	+	extern char  *progname, *octname;
928	+	static char  *mybuf = NULL;
929	+
930		#ifdef  F_SETLKW
931	<	aflock(creat ? F_WRLCK : F_RDLCK);
931	>	aflock(cre8 ? F_WRLCK : F_RDLCK);
932		#endif
933	<	#ifdef MSDOS
934	<	setmode(fileno(ambfp), O_BINARY);
935	<	#endif
936	<	setbuf(ambfp, bmalloc(BUFSIZ+8));
937	<	if (creat) {                    /* new file */
933	>	SET_FILE_BINARY(ambfp);
934	>	if (mybuf == NULL)
935	>	mybuf = (char *)bmalloc(BUFSIZ+8);
936	>	setbuf(ambfp, mybuf);
937	>	if (cre8) {                     /* new file */
938		newheader("RADIANCE", ambfp);
939	<	fprintf(ambfp, "%s -av %g %g %g -ab %d -aa %g ",
939	>	fprintf(ambfp, "%s -av %g %g %g -aw %d -ab %d -aa %g ",
940		progname, colval(ambval,RED),
941		colval(ambval,GRN), colval(ambval,BLU),
942	<	ambounce, ambacc);
943	<	fprintf(ambfp, "-ad %d -as %d -ar %d %s\n",
944	<	ambdiv, ambssamp, ambres,
945	<	octname==NULL ? "" : octname);
942	>	ambvwt, ambounce, ambacc);
943	>	fprintf(ambfp, "-ad %d -as %d -ar %d ",
944	>	ambdiv, ambssamp, ambres);
945	>	if (octname != NULL)
946	>	fputs(octname, ambfp);
947	>	fputc('\n', ambfp);
948		fprintf(ambfp, "SOFTWARE= %s\n", VersionID);
949	+	fputnow(ambfp);
950		fputformat(AMBFMT, ambfp);
951	<	putc('\n', ambfp);
951	>	fputc('\n', ambfp);
952		putambmagic(ambfp);
953		} else if (checkheader(ambfp, AMBFMT, NULL) < 0 || !hasambmagic(ambfp))
954		error(USER, "bad ambient file");
955		}
956
957
958	<	static
959	<	avsave(av)                              /* insert and save an ambient value */
960	<	AMBVAL  *av;
958	>	static void
959	>	avsave(                         /* insert and save an ambient value */
960	>	AMBVAL  *av
961	>	)
962		{
963		avinsert(avstore(av));
964		if (ambfp == NULL)
#	Line 421 | Line 970 | AMBVAL *av;
970		goto writerr;
971		return;
972		writerr:
973	<	error(SYSTEM, "error writing ambient file");
973	>	error(SYSTEM, "error writing to ambient file");
974		}
975
976
977		static AMBVAL *
978	<	avstore(aval)                           /* allocate memory and store aval */
979	<	register AMBVAL  *aval;
978	>	avstore(                                /* allocate memory and store aval */
979	>	AMBVAL  *aval
980	>	)
981		{
982	<	register AMBVAL  *av;
982	>	AMBVAL  *av;
983	>	double  d;
984
985		if ((av = newambval()) == NULL)
986		error(SYSTEM, "out of memory in avstore");
987	<	copystruct(av, aval);
987	>	*av = *aval;
988		av->latick = ambclock;
989		av->next = NULL;
439	–	addcolor(avsum, av->val);       /* add to sum for averaging */
990		nambvals++;
991	+	d = bright(av->val);
992	+	if (d > FTINY) {                /* add to log sum for averaging */
993	+	avsum += log(d);
994	+	navsum++;
995	+	}
996		return(av);
997		}
998
#	Line 447 | Line 1002 | register AMBVAL  *aval;
1002		static AMBTREE  *atfreelist = NULL;     /* free ambient tree structures */
1003
1004
1005	<	static
1006	<	AMBTREE *
452	<	newambtree()                            /* allocate 8 ambient tree structs */
1005	>	static AMBTREE *
1006	>	newambtree(void)                                /* allocate 8 ambient tree structs */
1007		{
1008	<	register AMBTREE  *atp, *upperlim;
1008	>	AMBTREE  *atp, *upperlim;
1009
1010		if (atfreelist == NULL) {       /* get more nodes */
1011	<	atfreelist = (AMBTREE *)bmalloc(ATALLOCSZ*8*sizeof(AMBTREE));
1011	>	atfreelist = (AMBTREE *)malloc(ATALLOCSZ*8*sizeof(AMBTREE));
1012		if (atfreelist == NULL)
1013		return(NULL);
1014		/* link new free list */
#	Line 465 | Line 1019 | newambtree()                           /* allocate 8 ambient tree structs */
1019		}
1020		atp = atfreelist;
1021		atfreelist = atp->kid;
1022	<	bzero((char *)atp, 8*sizeof(AMBTREE));
1022	>	memset((char *)atp, '\0', 8*sizeof(AMBTREE));
1023		return(atp);
1024		}
1025
1026
1027	<	static
1028	<	freeambtree(atp)                        /* free 8 ambient tree structs */
1029	<	AMBTREE  *atp;
1027	>	static void
1028	>	freeambtree(                    /* free 8 ambient tree structs */
1029	>	AMBTREE  *atp
1030	>	)
1031		{
1032		atp->kid = atfreelist;
1033		atfreelist = atp;
1034		}
1035
1036
1037	<	static
1038	<	avinsert(av)                            /* insert ambient value in our tree */
1039	<	register AMBVAL  *av;
1037	>	static void
1038	>	unloadatree(                    /* unload an ambient value tree */
1039	>	AMBTREE  *at,
1040	>	unloadtf_t *f
1041	>	)
1042		{
1043	<	register AMBTREE  *at;
1044	<	register AMBVAL  *ap;
488	<	AMBVAL  avh;
489	<	FVECT  ck0;
490	<	double  s;
491	<	int  branch;
492	<	register int  i;
493	<
494	<	if (av->rad <= FTINY)
495	<	error(CONSISTENCY, "zero ambient radius in avinsert");
496	<	at = &atrunk;
497	<	VCOPY(ck0, thescene.cuorg);
498	<	s = thescene.cusize;
499	<	while (s*(OCTSCALE/2) > av->rad*ambacc) {
500	<	if (at->kid == NULL)
501	<	if ((at->kid = newambtree()) == NULL)
502	<	error(SYSTEM, "out of memory in avinsert");
503	<	s *= 0.5;
504	<	branch = 0;
505	<	for (i = 0; i < 3; i++)
506	<	if (av->pos[i] > ck0[i] + s) {
507	<	ck0[i] += s;
508	<	branch |= 1 << i;
509	<	}
510	<	at = at->kid + branch;
511	<	}
512	<	avh.next = at->alist;           /* order by increasing level */
513	<	for (ap = &avh; ap->next != NULL; ap = ap->next)
514	<	if (ap->next->lvl >= av->lvl)
515	<	break;
516	<	av->next = ap->next;
517	<	ap->next = av;
518	<	at->alist = avh.next;
519	<	}
520	<
521	<
522	<	static
523	<	unloadatree(at, f)                      /* unload an ambient value tree */
524	<	register AMBTREE  *at;
525	<	int     (*f)();
526	<	{
527	<	register AMBVAL  *av;
528	<	register int  i;
1043	>	AMBVAL  *av;
1044	>	int  i;
1045		/* transfer values at this node */
1046		for (av = at->alist; av != NULL; av = at->alist) {
1047		at->alist = av->next;
#	Line 540 | Line 1056 | int    (*f)();
1056		}
1057
1058
1059	<	static AMBVAL   **avlist1, **avlist2;   /* ambient value lists for sorting */
1059	>	static struct avl {
1060	>	AMBVAL  *p;
1061	>	unsigned long   t;
1062	>	}       *avlist1;                       /* ambient value list with ticks */
1063	>	static AMBVAL   **avlist2;              /* memory positions for sorting */
1064		static int      i_avlist;               /* index for lists */
1065
1066	+	static int alatcmp(const void *av1, const void *av2);
1067
1068	<	static
1069	<	av2list(av)
549	<	AMBVAL  *av;
1068	>	static void
1069	>	avfree(AMBVAL *av)
1070		{
1071	+	free(av);
1072	+	}
1073	+
1074	+	static void
1075	+	av2list(
1076	+	AMBVAL *av
1077	+	)
1078	+	{
1079		#ifdef DEBUG
1080		if (i_avlist >= nambvals)
1081		error(CONSISTENCY, "too many ambient values in av2list1");
1082		#endif
1083	<	avlist1[i_avlist] = avlist2[i_avlist] = av;
1084	<	i_avlist++;
1083	>	avlist1[i_avlist].p = avlist2[i_avlist] = (AMBVAL*)av;
1084	>	avlist1[i_avlist++].t = av->latick;
1085		}
1086
1087
1088		static int
1089	<	alatcmp(avp1, avp2)                     /* compare ambient values for MRA */
1090	<	AMBVAL  **avp1, **avp2;
1089	>	alatcmp(                        /* compare ambient values for MRA */
1090	>	const void *av1,
1091	>	const void *av2
1092	>	)
1093		{
1094	<	return((**avp2).latick - (**avp1).latick);
1094	>	long  lc = ((struct avl *)av2)->t - ((struct avl *)av1)->t;
1095	>	return(lc<0 ? -1 : lc>0 ? 1 : 0);
1096		}
1097
1098
1099	+	/* GW NOTE 2002/10/3:
1100	+	* I used to compare AMBVAL pointers, but found that this was the
1101	+	* cause of a serious consistency error with gcc, since the optimizer
1102	+	* uses some dangerous trick in pointer subtraction that
1103	+	* assumes pointers differ by exact struct size increments.
1104	+	*/
1105		static int
1106	<	aposcmp(avp1, avp2)                     /* compare ambient value positions */
1107	<	AMBVAL  **avp1, **avp2;
1106	>	aposcmp(                        /* compare ambient value positions */
1107	>	const void      *avp1,
1108	>	const void      *avp2
1109	>	)
1110		{
1111	<	return(*avp1 - *avp2);
1111	>	long    diff = *(char * const *)avp1 - *(char * const *)avp2;
1112	>	if (diff < 0)
1113	>	return(-1);
1114	>	return(diff > 0);
1115		}
1116
1117
576	–	#ifdef DEBUG
1118		static int
1119	<	avlmemi(avaddr)                         /* find list position from address */
1120	<	AMBVAL  *avaddr;
1119	>	avlmemi(                                /* find list position from address */
1120	>	AMBVAL  *avaddr
1121	>	)
1122		{
1123	<	register AMBVAL  **avlpp;
1123	>	AMBVAL  **avlpp;
1124
1125		avlpp = (AMBVAL **)bsearch((char *)&avaddr, (char *)avlist2,
1126	<	nambvals, sizeof(AMBVAL *), aposcmp);
1126	>	nambvals, sizeof(AMBVAL *), &aposcmp);
1127		if (avlpp == NULL)
1128		error(CONSISTENCY, "address not found in avlmemi");
1129		return(avlpp - avlist2);
1130		}
589	–	#else
590	–	#define avlmemi(avaddr) ((AMBVAL **)bsearch((char *)&avaddr,(char *)avlist2, \
591	–	nambvals,sizeof(AMBVAL *),aposcmp) - avlist2)
592	–	#endif
1131
1132
1133	<	static
1134	<	sortambvals(always)                     /* resort ambient values */
1135	<	int     always;
1133	>	static void
1134	>	sortambvals(                    /* resort ambient values */
1135	>	int     always
1136	>	)
1137		{
1138		AMBTREE  oldatrunk;
1139		AMBVAL  tav, *tap, *pnext;
1140	<	register int    i, j;
1140	>	int     i, j;
1141		/* see if it's time yet */
1142	<	if (!always && (ambclock < lastsort+sortintvl ||
1142	>	if (!always && (ambclock++ < lastsort+sortintvl ||
1143		nambvals < SORT_THRESH))
1144		return;
1145		/*
#	Line 619 | Line 1158 | int    always;
1158		* tree will be rebuilt with the new accuracy parameter.
1159		*/
1160		if (tracktime) {                /* allocate pointer arrays to sort */
622	–	avlist1 = (AMBVAL **)malloc(nambvals*sizeof(AMBVAL *));
1161		avlist2 = (AMBVAL **)malloc(nambvals*sizeof(AMBVAL *));
1162	<	} else
1163	<	avlist1 = avlist2 = NULL;
1164	<	if (avlist2 == NULL) {          /* no time tracking -- rebuild tree? */
1165	<	if (avlist1 != NULL)
1166	<	free((char *)avlist1);
1162	>	avlist1 = (struct avl *)malloc(nambvals*sizeof(struct avl));
1163	>	} else {
1164	>	avlist2 = NULL;
1165	>	avlist1 = NULL;
1166	>	}
1167	>	if (avlist1 == NULL) {          /* no time tracking -- rebuild tree? */
1168	>	if (avlist2 != NULL)
1169	>	free((void *)avlist2);
1170		if (always) {           /* rebuild without sorting */
1171	<	copystruct(&oldatrunk, &atrunk);
1171	>	oldatrunk = atrunk;
1172		atrunk.alist = NULL;
1173		atrunk.kid = NULL;
1174	<	unloadatree(&oldatrunk, avinsert);
1174	>	unloadatree(&oldatrunk, &avinsert);
1175		}
1176		} else {                        /* sort memory by last access time */
1177		/*
#	Line 647 | Line 1188 | int    always;
1188		eputs(errmsg);
1189		#endif
1190		i_avlist = 0;
1191	<	unloadatree(&atrunk, av2list);  /* empty current tree */
1191	>	unloadatree(&atrunk, &av2list); /* empty current tree */
1192		#ifdef DEBUG
1193		if (i_avlist < nambvals)
1194		error(CONSISTENCY, "missing ambient values in sortambvals");
1195		#endif
1196	<	qsort((char *)avlist1, nambvals, sizeof(AMBVAL *), alatcmp);
1197	<	qsort((char *)avlist2, nambvals, sizeof(AMBVAL *), aposcmp);
1196	>	qsort((char *)avlist1, nambvals, sizeof(struct avl), &alatcmp);
1197	>	qsort((char *)avlist2, nambvals, sizeof(AMBVAL *), &aposcmp);
1198		for (i = 0; i < nambvals; i++) {
1199	<	if (avlist1[i] == NULL)
1199	>	if (avlist1[i].p == NULL)
1200		continue;
1201		tap = avlist2[i];
1202	<	copystruct(&tav, tap);
1203	<	for (j = i; (pnext = avlist1[j]) != tap;
1202	>	tav = *tap;
1203	>	for (j = i; (pnext = avlist1[j].p) != tap;
1204		j = avlmemi(pnext)) {
1205	<	copystruct(avlist2[j], pnext);
1205	>	*(avlist2[j]) = *pnext;
1206		avinsert(avlist2[j]);
1207	<	avlist1[j] = NULL;
1207	>	avlist1[j].p = NULL;
1208		}
1209	<	copystruct(avlist2[j], &tav);
1209	>	*(avlist2[j]) = tav;
1210		avinsert(avlist2[j]);
1211	<	avlist1[j] = NULL;
1211	>	avlist1[j].p = NULL;
1212		}
1213	<	free((char *)avlist1);
1214	<	free((char *)avlist2);
1213	>	free((void *)avlist1);
1214	>	free((void *)avlist2);
1215		/* compute new sort interval */
1216		sortintvl = ambclock - lastsort;
1217		if (sortintvl >= MAX_SORT_INTVL/2)
#	Line 689 | Line 1230 | int    always;
1230
1231		#ifdef  F_SETLKW
1232
1233	<	static
1234	<	aflock(typ)                     /* lock/unlock ambient file */
1235	<	int  typ;
1233	>	static void
1234	>	aflock(                 /* lock/unlock ambient file */
1235	>	int  typ
1236	>	)
1237		{
1238		static struct flock  fls;       /* static so initialized to zeroes */
1239
1240	+	if (typ == fls.l_type)          /* already called? */
1241	+	return;
1242		fls.l_type = typ;
1243		if (fcntl(fileno(ambfp), F_SETLKW, &fls) < 0)
1244		error(SYSTEM, "cannot (un)lock ambient file");
#	Line 702 | Line 1246 | int  typ;
1246
1247
1248		int
1249	<	ambsync()                       /* synchronize ambient file */
1249	>	ambsync(void)                   /* synchronize ambient file */
1250		{
707	–	static FILE  *ambinp = NULL;
708	–	static long  lastpos = -1;
1251		long  flen;
1252		AMBVAL  avs;
1253	<	register int  n;
1253	>	int  n;
1254
1255	<	if (nunflshed == 0)
1255	>	if (ambfp == NULL)      /* no ambient file? */
1256		return(0);
1257	<	if (lastpos < 0)        /* initializing (locked in initambfile) */
1258	<	goto syncend;
717	<	/* gain exclusive access */
718	<	aflock(F_WRLCK);
1257	>	/* gain appropriate access */
1258	>	aflock(nunflshed ? F_WRLCK : F_RDLCK);
1259		/* see if file has grown */
1260	<	if ((flen = lseek(fileno(ambfp), 0L, 2)) < 0)
1260	>	if ((flen = lseek(fileno(ambfp), (off_t)0, SEEK_END)) < 0)
1261		goto seekerr;
1262	<	if (n = flen - lastpos) {               /* file has grown */
1262	>	if ((n = flen - lastpos) > 0) {         /* file has grown */
1263		if (ambinp == NULL) {           /* use duplicate filedes */
1264		ambinp = fdopen(dup(fileno(ambfp)), "r");
1265		if (ambinp == NULL)
1266		error(SYSTEM, "fdopen failed in ambsync");
1267		}
1268	<	if (fseek(ambinp, lastpos, 0) < 0)
1268	>	if (fseek(ambinp, lastpos, SEEK_SET) < 0)
1269		goto seekerr;
1270		while (n >= AMBVALSIZ) {        /* load contributed values */
1271	<	readambval(&avs, ambinp);
1271	>	if (!readambval(&avs, ambinp)) {
1272	>	sprintf(errmsg,
1273	>	"ambient file \"%s\" corrupted near character %ld",
1274	>	ambfile, flen - n);
1275	>	error(WARNING, errmsg);
1276	>	break;
1277	>	}
1278		avinsert(avstore(&avs));
1279		n -= AMBVALSIZ;
1280		}
1281	+	lastpos = flen - n;
1282		/*** seek always as safety measure
1283		if (n) ***/                     /* alignment */
1284	<	if (lseek(fileno(ambfp), flen-n, 0) < 0)
1284	>	if (lseek(fileno(ambfp), (off_t)lastpos, SEEK_SET) < 0)
1285		goto seekerr;
1286		}
740	–	#ifdef  DEBUG
741	–	if (ambfp->_ptr - ambfp->_base != nunflshed*AMBVALSIZ) {
742	–	sprintf(errmsg, "ambient file buffer at %d rather than %d",
743	–	ambfp->_ptr - ambfp->_base,
744	–	nunflshed*AMBVALSIZ);
745	–	error(CONSISTENCY, errmsg);
746	–	}
747	–	#endif
748	–	syncend:
1287		n = fflush(ambfp);                      /* calls write() at last */
1288	<	if ((lastpos = lseek(fileno(ambfp), 0L, 1)) < 0)
1288	>	if (n != EOF)
1289	>	lastpos += (long)nunflshed*AMBVALSIZ;
1290	>	else if ((lastpos = lseek(fileno(ambfp), (off_t)0, SEEK_CUR)) < 0)
1291		goto seekerr;
1292	+
1293		aflock(F_UNLCK);                        /* release file */
1294		nunflshed = 0;
1295		return(n);
1296		seekerr:
1297		error(SYSTEM, "seek failed in ambsync");
1298	+	return -1; /* pro forma return */
1299		}
1300
1301	<	#else
1301	>	#else   /* ! F_SETLKW */
1302
1303		int
1304	<	ambsync()                       /* flush ambient file */
1304	>	ambsync(void)                   /* flush ambient file */
1305		{
1306	<	if (nunflshed == 0)
1306	>	if (ambfp == NULL)
1307		return(0);
1308		nunflshed = 0;
1309		return(fflush(ambfp));
1310		}
1311
1312	<	#endif
1312	>	#endif  /* ! F_SETLKW */

Diff Legend

–	Removed lines
+	Added lines
<	Changed lines
>	Changed lines