--- ray/src/px/macbethcal.c 1995/10/17 10:24:21 2.5 +++ ray/src/px/macbethcal.c 1997/01/31 15:56:17 2.13 @@ -1,4 +1,4 @@ -/* Copyright (c) 1995 Regents of the University of California */ +/* Copyright (c) 1997 Regents of the University of California */ #ifndef lint static char SCCSid[] = "$SunId$ LBL"; @@ -77,27 +77,37 @@ COLOR mbRGB[24]; /* MacBeth RGB values */ #define NMBNEU 6 /* Number of MacBeth neutral colors */ short mbneu[NMBNEU] = {Black,Neutral35,Neutral5,Neutral65,Neutral8,White}; -#define NMBMOD 17 /* Number of MacBeth unsaturated colors */ -short mbmod[NMBMOD] = { - DarkSkin,LightSkin,BlueSky,Foliage,BlueFlower,BluishGreen, - Orange,PurplishBlue,ModerateRed,Purple,YellowGreen, - Black,Neutral35,Neutral5,Neutral65,Neutral8,White - }; +#define NEUFLGS (1L< 2 && !strcmp(argv[1], "-d")) { /* debug output */ - if ((debugfp = fopen(argv[2], "w")) == NULL) { - perror(argv[2]); - exit(1); - } + for (i = 1; i < argc && argv[i][0] == '-'; i++) + switch (argv[i][1]) { + case 'd': /* debug output */ + i++; + if (badarg(argc-i, argv+i, "s")) + goto userr; + if ((debugfp = fopen(argv[i], "w")) == NULL) { + perror(argv[i]); + exit(1); + } #ifdef MSDOS - setmode(fileno(debugfp), O_BINARY); + setmode(fileno(debugfp), O_BINARY); #endif - newheader("RADIANCE", debugfp); - printargs(argc, argv, debugfp); - argv += 2; - argc -= 2; - } - if (argc != 3 && argc != 11) - goto userr; - if (strcmp(argv[1], "-") && freopen(argv[1], "r", stdin) == NULL) { - perror(argv[1]); + newheader("RADIANCE", debugfp); /* start */ + printargs(argc, argv, debugfp); /* header */ + break; + case 'p': /* picture position */ + if (badarg(argc-i-1, argv+i+1, "iiiiiiii")) + goto userr; + bounds[0][0] = atoi(argv[++i]); + bounds[0][1] = atoi(argv[++i]); + bounds[1][0] = atoi(argv[++i]); + bounds[1][1] = atoi(argv[++i]); + bounds[2][0] = atoi(argv[++i]); + bounds[2][1] = atoi(argv[++i]); + bounds[3][0] = atoi(argv[++i]); + bounds[3][1] = atoi(argv[++i]); + scanning = 2; + break; + case 'c': /* color input */ + scanning = 0; + break; + default: + goto userr; + } + /* open files */ + if (i < argc && freopen(argv[i], "r", stdin) == NULL) { + perror(argv[i]); exit(1); } - if (strcmp(argv[2], "-") && freopen(argv[2], "w", stdout) == NULL) { - perror(argv[2]); + if (i+1 < argc && freopen(argv[i+1], "w", stdout) == NULL) { + perror(argv[i+1]); exit(1); } + if (scanning) { /* load input picture header */ #ifdef MSDOS - setmode(fileno(stdin), O_BINARY); + setmode(fileno(stdin), O_BINARY); #endif - if (checkheader(stdin, COLRFMT, NULL) < 0 || - fgetresolu(&xmax, &ymax, stdin) < 0) { - fprintf(stderr, "%s: bad input picture\n", progname); - exit(1); - } - /* get chart boundaries */ - if (argc == 11) { - for (i = 0; i < 4; i++) { - if (!isint(argv[2*i+3]) | !isint(argv[2*i+4])) - goto userr; - bounds[i][0] = atoi(argv[2*i+3]); - bounds[i][1] = atoi(argv[2*i+4]); + if (checkheader(stdin, COLRFMT, NULL) < 0 || + fgetresolu(&xmax, &ymax, stdin) < 0) { + fprintf(stderr, "%s: bad input picture\n", progname); + exit(1); } - } else { + } else { /* else set default xmax and ymax */ + xmax = 512; + ymax = 2*512/3; + } + if (scanning != 2) { /* use default boundaries */ bounds[0][0] = bounds[2][0] = .029*xmax + .5; bounds[0][1] = bounds[1][1] = .956*ymax + .5; bounds[1][0] = bounds[3][0] = .971*xmax + .5; bounds[2][1] = bounds[3][1] = .056*ymax + .5; } init(); /* initialize */ - getcolors(); /* get picture colors */ + if (scanning) /* get picture colors */ + getpicture(); + else + getcolors(); compute(); /* compute color mapping */ /* print comment */ - printf("{ Color correction file computed by %s }\n", progname); - printf("{ from scanned MacBetch color chart %s }\n", argv[1]); + printf("{\n\tColor correction file computed by:\n\t\t"); + printargs(argc, argv, stdout); + printf("\n\tUsage: pcomb -f %s uncorrected.pic > corrected.pic\n", + i+1 < argc ? argv[i+1] : "{this_file}"); + if (!scanning) + printf("\t Or: pcond [options] -f %s orig.pic > output.pic\n", + i+1 < argc ? argv[i+1] : "{this_file}"); + printf("}\n"); putmapping(); /* put out color mapping */ - putdebug(); /* put out debug picture */ + if (debugfp != NULL) /* put out debug picture */ + if (scanning) + picdebug(); + else + clrdebug(); exit(0); userr: - fprintf(stderr, "Usage: %s [-d dbg.pic] input.pic output.cal [xul yul xur yur xll yll xlr ylr]\n", + fprintf(stderr, +"Usage: %s [-d dbg.pic][-p xul yul xur yur xll yll xlr ylr] input.pic [output.cal]\n", progname); + fprintf(stderr, " or: %s [-d dbg.pic] -c [xyY.dat [output.cal]]\n", + progname); exit(1); } @@ -176,6 +220,7 @@ userr: init() /* initialize */ { double quad[4][2]; + register int i; /* make coordinate transformation */ quad[0][0] = bounds[0][0]; quad[0][1] = bounds[0][1]; @@ -190,12 +235,16 @@ init() /* initialize */ fprintf(stderr, "%s: bad chart boundaries\n", progname); exit(1); } + /* map MacBeth colors to RGB space */ + for (i = 0; i < 24; i++) + xyY2RGB(mbRGB[i], mbxyY[i]); } int -chartndx(x, y) /* find color number for position */ +chartndx(x, y, np) /* find color number for position */ int x, y; +int *np; { double ipos[3], cpos[3]; int ix, iy; @@ -208,25 +257,30 @@ int x, y; cpos[0] /= cpos[2]; cpos[1] /= cpos[2]; if (cpos[0] < 0. || cpos[0] >= 6. || cpos[1] < 0. || cpos[1] >= 4.) - return(-1); + return(RG_BORD); ix = cpos[0]; iy = cpos[1]; fx = cpos[0] - ix; fy = cpos[1] - iy; - if (fx < .35 || fx >= .65 || fy < .35 || fy >= .65) - return(-1); - return(iy*6 + ix); + *np = iy*6 + ix; + if (fx >= 0.35 && fx < 0.65 && fy >= 0.35 && fy < 0.65) + return(RG_CENT); + if (fx < 0.05 || fx >= 0.95 || fy < 0.05 || fy >= 0.95) + return(RG_BORD); + if (fx >= 0.5) /* right side is corrected */ + return(RG_CORR); + return(RG_ORIG); /* left side is original */ } -getcolors() /* load in picture colors */ +getpicture() /* load in picture colors */ { COLR *scanln; COLOR pval; int ccount[24]; double d; - int y; - register int x, i; + int y, i; + register int x; scanln = (COLR *)malloc(xmax*sizeof(COLR)); if (scanln == NULL) { @@ -234,7 +288,7 @@ getcolors() /* load in picture colors */ exit(1); } for (i = 0; i < 24; i++) { - setcolor(picRGB[i], 0., 0., 0.); + setcolor(inpRGB[i], 0., 0., 0.); ccount[i] = 0; } for (y = ymax-1; y >= 0; y--) { @@ -243,74 +297,144 @@ getcolors() /* load in picture colors */ progname); exit(1); } - for (x = 0; x < xmax; x++) { - i = chartndx(x, y); - if (i >= 0) { + for (x = 0; x < xmax; x++) + if (chartndx(x, y, &i) == RG_CENT) { colr_color(pval, scanln[x]); - addcolor(picRGB[i], pval); + addcolor(inpRGB[i], pval); ccount[i]++; } + } + for (i = 0; i < 24; i++) { /* compute averages */ + if (ccount[i] == 0) + continue; + d = 1./ccount[i]; + scalecolor(inpRGB[i], d); + inpflags |= 1L< 24 || + fgetval(stdin, 'f', &xyYin[0]) != 1 || + fgetval(stdin, 'f', &xyYin[1]) != 1 || + fgetval(stdin, 'f', &xyYin[2]) != 1 || + xyYin[0] < 0. | xyYin[1] < 0. || + xyYin[0] + xyYin[1] > 1.) { + fprintf(stderr, "%s: bad color input data\n", + progname); + exit(1); } + if (n == 0) { /* calibration white */ + xyY2RGB(whiteclr, xyYin); + gotwhite++; + } else { /* standard color */ + n--; + xyY2RGB(inpRGB[n], xyYin); + inpflags |= 1L< NMBMOD) { - fprintf(stderr, "%s: inconsistent code!\n", progname); + if (n < 3) { + fprintf(stderr, "%s: too few colors to match!\n", progname); exit(1); } if (n == 3) @@ -412,33 +546,56 @@ int n; } +int cvtcolor(cout, cin) /* convert color according to our mapping */ COLOR cout, cin; { - double r, g, b; + COLOR ctmp; + int clipped; - bresp(cout, cin); - r = colval(cout,0)*solmat[0][0] + colval(cout,1)*solmat[0][1] - + colval(cout,2)*solmat[0][2]; - if (r < 0) r = 0; - g = colval(cout,0)*solmat[1][0] + colval(cout,1)*solmat[1][1] - + colval(cout,2)*solmat[1][2]; - if (g < 0) g = 0; - b = colval(cout,0)*solmat[2][0] + colval(cout,1)*solmat[2][1] - + colval(cout,2)*solmat[2][2]; - if (b < 0) b = 0; - setcolor(cout, r, g, b); + if (scanning) { + bresp(ctmp, cin); + clipped = cresp(cout, ctmp); + } else { + clipped = cresp(ctmp, cin); + bresp(cout, ctmp); + } + return(clipped); } -putdebug() /* put out debugging picture */ +int +cresp(cout, cin) /* transform color according to matrix */ +COLOR cout, cin; { + colortrans(cout, solmat, cin); + return(clipgamut(cout, bright(cout), CGAMUT, colmin, colmax)); +} + + +xyY2RGB(rgbout, xyYin) /* convert xyY to RGB */ +COLOR rgbout; +register float xyYin[3]; +{ + COLOR ctmp; + double d; + + d = xyYin[2] / xyYin[1]; + ctmp[0] = xyYin[0] * d; + ctmp[1] = xyYin[2]; + ctmp[2] = (1. - xyYin[0] - xyYin[1]) * d; + /* allow negative values */ + colortrans(rgbout, xyz2rgbmat, ctmp); +} + + +picdebug() /* put out debugging picture */ +{ + static COLOR blkcol = BLKCOLOR; COLOR *scan; - int y; - register int x, i; + int y, i; + register int x, rg; - if (debugfp == NULL) - return; if (fseek(stdin, 0L, 0) == EOF) { fprintf(stderr, "%s: cannot seek on input picture\n", progname); exit(1); @@ -455,6 +612,7 @@ putdebug() /* put out debugging picture */ fputformat(COLRFMT, debugfp); putc('\n', debugfp); fprtresolu(xmax, ymax, debugfp); + /* write debug picture */ for (y = ymax-1; y >= 0; y--) { if (freadscan(scan, xmax, stdin) < 0) { fprintf(stderr, "%s: error rereading input picture\n", @@ -462,11 +620,18 @@ putdebug() /* put out debugging picture */ exit(1); } for (x = 0; x < xmax; x++) { - i = chartndx(x, y); - if (i < 0) + rg = chartndx(x, y, &i); + if (rg == RG_CENT) { + if (!(1L<= 0; y--) { + for (x = 0; x < xmax; x++) { + rg = chartndx(x, y, &i); + if (rg == RG_CENT) { + if (!(1L<