--- ray/src/ot/oconv.c	2003/02/22 02:07:26	2.12
+++ ray/src/ot/oconv.c	2004/03/27 12:41:45	2.19
@@ -1,5 +1,5 @@
 #ifndef lint
-static const char	RCSid[] = "$Id: oconv.c,v 2.12 2003/02/22 02:07:26 greg Exp $";
+static const char RCSid[] = "$Id: oconv.c,v 2.19 2004/03/27 12:41:45 schorsch Exp $";
 #endif
 /*
  *  oconv.c - main program for object to octree conversion.
@@ -7,15 +7,14 @@ static const char	RCSid[] = "$Id: oconv.c,v 2.12 2003/
  *     7/29/85
  */
 
+#include  "platform.h"
 #include  "standard.h"
-
 #include  "octree.h"
-
 #include  "object.h"
-
 #include  "otypes.h"
-
 #include  "paths.h"
+#include  "resolu.h"
+#include  "oconv.h"
 
 #define	 OMARGIN	(10*FTINY)	/* margin around global cube */
 
@@ -25,9 +24,9 @@ char  *progname;			/* argv[0] */
 
 int  nowarn = 0;			/* supress warnings? */
 
-int  objlim = 5;			/* # of objects before split */
+int  objlim = 6;			/* # of objects before split */
 
-int  resolu = 8192;			/* octree resolution limit */
+int  resolu = 16384;			/* octree resolution limit */
 
 CUBE  thescene = {EMPTY, {0.0, 0.0, 0.0}, 0.0};		/* our scene */
 
@@ -38,10 +37,15 @@ double	mincusize;			/* minimum cube size from resolu *
 
 void  (*addobjnotify[])() = {NULL};	/* new object notifier functions */
 
+static void addobject(CUBE  *cu, OBJECT	obj);
+static void add2full(CUBE  *cu, OBJECT	obj, int  inc);
 
-main(argc, argv)		/* convert object files to an octree */
-int  argc;
-char  *argv[];
+
+int
+main(		/* convert object files to an octree */
+	int  argc,
+	char  *argv[]
+)
 {
 	FVECT  bbmin, bbmax;
 	char  *infile = NULL;
@@ -52,7 +56,7 @@ char  *argv[];
 
 	progname = argv[0] = fixargv0(argv[0]);
 
-	initotypes();
+	ot_initotypes();
 
 	for (i = 1; i < argc && argv[i][0] == '-'; i++)
 		switch (argv[i][1]) {
@@ -85,9 +89,7 @@ char  *argv[];
 			break;
 		}
 breakopt:
-#ifdef MSDOS
-	setmode(fileno(stdout), O_BINARY);
-#endif
+	SET_FILE_BINARY(stdout);
 	if (infile != NULL) {		/* get old octree & objects */
 		if (thescene.cusize > FTINY)
 			error(USER, "only one of '-b' or '-i'");
@@ -154,27 +156,30 @@ breakopt:
 	writeoct(outflags, &thescene, ofname);	/* write structures to stdout */
 
 	quit(0);
+	return 0; /* pro forma return */
 }
 
 
 void
-quit(code)				/* exit program */
-int  code;
+quit(				/* exit program */
+	int  code
+)
 {
 	exit(code);
 }
 
 
 void
-cputs()					/* interactive error */
+cputs(void)					/* interactive error */
 {
 	/* referenced, but not used */
 }
 
 
 void
-wputs(s)				/* warning message */
-char  *s;
+wputs(				/* warning message */
+	char  *s
+)
 {
 	if (!nowarn)
 		eputs(s);
@@ -182,8 +187,9 @@ char  *s;
 
 
 void
-eputs(s)				/* put string to stderr */
-register char  *s;
+eputs(				/* put string to stderr */
+	register char  *s
+)
 {
 	static int  inln = 0;
 
@@ -196,6 +202,11 @@ register char  *s;
 		inln = 0;
 }
 
+				/* conflicting def's in param.h */
+#undef  tstbit
+#undef  setbit
+#undef  clrbit
+#undef  tglbit
 
 #define	 bitop(f,i,op)		(f[((i)>>3)] op (1<<((i)&7)))
 #define	 tstbit(f,i)		bitop(f,i,&)
@@ -204,24 +215,22 @@ register char  *s;
 #define	 tglbit(f,i)		bitop(f,i,^=)
 
 
-addobject(cu, obj)			/* add an object to a cube */
-register CUBE  *cu;
-OBJECT	obj;
+static void
+addobject(			/* add an object to a cube */
+	register CUBE  *cu,
+	OBJECT	obj
+)
 {
-	CUBE  cukid;
-	OCTREE	ot;
-	OBJECT	oset[MAXSET+1];
-	unsigned char  inflg[(MAXSET+7)/8], volflg[(MAXSET+7)/8];
-	int  in;
-	register int  i, j;
+	int  inc;
 
-	in = (*ofun[objptr(obj)->otype].funp)(objptr(obj), cu);
+	inc = (*ofun[objptr(obj)->otype].funp)(objptr(obj), cu);
 
-	if (in == O_MISS)
+	if (inc == O_MISS)
 		return;				/* no intersection */
 
 	if (istree(cu->cutree)) {
-						/* do children */
+		CUBE  cukid;			/* do children */
+		int  i, j;
 		cukid.cusize = cu->cusize * 0.5;
 		for (i = 0; i < 8; i++) {
 			cukid.cutree = octkid(cu->cutree, i);
@@ -236,16 +245,33 @@ OBJECT	obj;
 		return;
 	}
 	if (isempty(cu->cutree)) {
-						/* singular set */
+		OBJECT  oset[2];		/* singular set */
 		oset[0] = 1; oset[1] = obj;
 		cu->cutree = fullnode(oset);
 		return;
 	}
 					/* add to full node */
+	add2full(cu, obj, inc);
+}
+
+
+static void
+add2full(			/* add object to full node */
+	register CUBE  *cu,
+	OBJECT	obj,
+	int  inc
+)
+{
+	OCTREE	ot;
+	OBJECT	oset[MAXSET+1];
+	CUBE  cukid;
+	unsigned char  inflg[(MAXSET+7)/8], volflg[(MAXSET+7)/8];
+	register int  i, j;
+
 	objset(oset, cu->cutree);
 	cukid.cusize = cu->cusize * 0.5;
 
-	if (in==O_IN || oset[0] < objlim || cukid.cusize < mincusize) {
+	if (inc==O_IN || oset[0] < objlim || cukid.cusize < mincusize) {
 						/* add to set */
 		if (oset[0] >= MAXSET) {
 			sprintf(errmsg, "set overflow in addobject (%s)",