--- ray/src/hd/rhdisp3.c	1997/11/26 20:12:19	3.7
+++ ray/src/hd/rhdisp3.c	2003/02/22 02:07:24	3.12
@@ -1,9 +1,6 @@
-/* Copyright (c) 1997 Silicon Graphics, Inc. */
-
 #ifndef lint
-static char SCCSid[] = "$SunId$ SGI";
+static const char	RCSid[] = "$Id: rhdisp3.c,v 3.12 2003/02/22 02:07:24 greg Exp $";
 #endif
-
 /*
  * Holodeck beam support for display process
  */
@@ -19,7 +16,7 @@ struct cellist {
 
 
 int
-npixels(vp, hr, vr, hp, bi)	/* compute appropriate number to evaluate */
+npixels(vp, hr, vr, hp, bi)	/* compute appropriate nrays to evaluate */
 register VIEW	*vp;
 int	hr, vr;
 HOLO	*hp;
@@ -27,14 +24,20 @@ int	bi;
 {
 	VIEW	vrev;
 	GCOORD	gc[2];
-	FVECT	cp[4], ip[4];
-	double	af, ab;
+	FVECT	cp[4], ip[4], pf, pb;
+	double	af, ab, sf2, sb2, dfb2, df2, db2, penalty;
 	register int	i;
+					/* special case */
+	if (hr <= 0 | vr <= 0)
+		return(0);
 					/* compute cell corners in image */
 	if (!hdbcoord(gc, hp, bi))
 		error(CONSISTENCY, "bad beam index in npixels");
 	hdcell(cp, hp, gc+1);		/* find cell on front image */
-	for (i = 0; i < 4; i++) {
+	for (i = 3; i--; )		/* compute front center */
+		pf[i] = 0.5*(cp[0][i] + cp[2][i]);
+	sf2 = 0.25*dist2(cp[0], cp[2]);	/* compute half diagonal length */
+	for (i = 0; i < 4; i++) {	/* compute visible quad */
 		viewloc(ip[i], vp, cp[i]);
 		if (ip[i][2] < 0.) {
 			af = 0;
@@ -48,8 +51,7 @@ int	bi;
 		(ip[2][0]-ip[0][0])*(ip[1][1]-ip[0][1]);
 	af += (ip[2][0]-ip[3][0])*(ip[1][1]-ip[3][1]) -
 		(ip[1][0]-ip[3][0])*(ip[2][1]-ip[3][1]);
-	if (af >= 0) af *= 0.5;
-	else af *= -0.5;
+	af *= af >= 0 ? 0.5 : -0.5;
 getback:
 	copystruct(&vrev, vp);		/* compute reverse view */
 	for (i = 0; i < 3; i++) {
@@ -59,10 +61,15 @@ getback:
 		vrev.vvec[i] = -vp->vvec[i];
 	}
 	hdcell(cp, hp, gc);		/* find cell on back image */
-	for (i = 0; i < 4; i++) {
+	for (i = 3; i--; )		/* compute rear center */
+		pb[i] = 0.5*(cp[0][i] + cp[2][i]);
+	sb2 = 0.25*dist2(cp[0], cp[2]);	/* compute half diagonal length */
+	for (i = 0; i < 4; i++) {	/* compute visible quad */
 		viewloc(ip[i], &vrev, cp[i]);
-		if (ip[i][2] < 0.)
-			return((int)(af + 0.5));
+		if (ip[i][2] < 0.) {
+			ab = 0;
+			goto finish;
+		}
 		ip[i][0] *= (double)hr;	/* scale by resolution */
 		ip[i][1] *= (double)vr;
 	}
@@ -71,12 +78,20 @@ getback:
 		(ip[2][0]-ip[0][0])*(ip[1][1]-ip[0][1]);
 	ab += (ip[2][0]-ip[3][0])*(ip[1][1]-ip[3][1]) -
 		(ip[1][0]-ip[3][0])*(ip[2][1]-ip[3][1]);
-	if (ab >= 0) ab *= 0.5;
-	else ab *= -0.5;
-					/* round off smaller area */
-	if (af <= ab)
-		return((int)(af + 0.5));
-	return((int)(ab + 0.5));
+	ab *= ab >= 0 ? 0.5 : -0.5;
+finish:		/* compute penalty based on dist. sightline - viewpoint */
+	df2 = dist2(vp->vp, pf);
+	db2 = dist2(vp->vp, pb);
+	dfb2 = dist2(pf, pb);
+	penalty = dfb2 + df2 - db2;
+	penalty = df2 - 0.25*penalty*penalty/dfb2;
+	if (df2 > db2)	penalty /= df2 <= dfb2 ? sb2 : sb2*df2/dfb2;
+	else		penalty /= db2 <= dfb2 ? sf2 : sf2*db2/dfb2;
+	if (penalty < 1.) penalty = 1.;
+					/* round off smaller non-zero area */
+	if (ab <= FTINY || (af > FTINY && af <= ab))
+		return((int)(af/penalty + 0.5));
+	return((int)(ab/penalty + 0.5));
 }
 
 
@@ -84,19 +99,20 @@ getback:
  * The ray directions that define the pyramid in visit_cells() needn't
  * be normalized, but they must be given in clockwise order as seen
  * from the pyramid's apex (origin).
+ * If no cell centers fall within the domain, the closest cell is visited.
  */
 int
 visit_cells(orig, pyrd, hp, vf, dp)	/* visit cells within a pyramid */
 FVECT	orig, pyrd[4];		/* pyramid ray directions in clockwise order */
-HOLO	*hp;
+register HOLO	*hp;
 int	(*vf)();
 char	*dp;
 {
-	int	n = 0;
+	int	ncalls = 0, n = 0;
 	int	inflags = 0;
 	FVECT	gp, pn[4], lo, ld;
 	double	po[4], lbeg, lend, d, t;
-	GCOORD	gc;
+	GCOORD	gc, gc2[2];
 	register int	i;
 					/* figure out whose side we're on */
 	hdgrid(gp, hp, orig);
@@ -114,17 +130,17 @@ char	*dp;
 		if (!(inflags & 1<<gc.w))	/* origin on wrong side */
 			continue;
 					/* scanline algorithm */
-		for (gc.i[1] = hp->grid[((gc.w>>1)+2)%3]; gc.i[1]--; ) {
+		for (gc.i[1] = hp->grid[hdwg1[gc.w]]; gc.i[1]--; ) {
 						/* compute scanline */
 			gp[gc.w>>1] = gc.w&1 ? hp->grid[gc.w>>1] : 0;
-			gp[((gc.w>>1)+1)%3] = 0;
-			gp[((gc.w>>1)+2)%3] = gc.i[1] + 0.5;
+			gp[hdwg0[gc.w]] = 0;
+			gp[hdwg1[gc.w]] = gc.i[1] + 0.5;
 			hdworld(lo, hp, gp);
-			gp[((gc.w>>1)+1)%3] = 1;
+			gp[hdwg0[gc.w]] = 1;
 			hdworld(ld, hp, gp);
 			ld[0] -= lo[0]; ld[1] -= lo[1]; ld[2] -= lo[2];
 						/* find scanline limits */
-			lbeg = 0; lend = hp->grid[((gc.w>>1)+1)%3];
+			lbeg = 0; lend = hp->grid[hdwg0[gc.w]];
 			for (i = 0; i < 4; i++) {
 				t = DOT(pn[i], lo) - po[i];
 				d = -DOT(pn[i], ld);
@@ -142,11 +158,26 @@ char	*dp;
 			if (lbeg >= lend)
 				continue;
 			i = lend + .5;		/* visit cells on this scan */
-			for (gc.i[0] = lbeg + .5; gc.i[0] < i; gc.i[0]++)
+			for (gc.i[0] = lbeg + .5; gc.i[0] < i; gc.i[0]++) {
 				n += (*vf)(&gc, dp);
+				ncalls++;
+			}
 		}
 	}
-	return(n);
+	if (ncalls)			/* got one at least */
+		return(n);
+					/* else find closest cell */
+	VSUM(ld, pyrd[0], pyrd[1], 1.);
+	VSUM(ld, ld, pyrd[2], 1.);
+	VSUM(ld, ld, pyrd[3], 1.);
+#if 0
+	if (normalize(ld) == 0.0)	/* technically not necessary */
+		return(0);
+#endif
+	d = hdinter(gc2, NULL, &t, hp, orig, ld);
+	if (d >= FHUGE || t <= 0.)
+		return(0);
+	return((*vf)(gc2+1, dp));	/* visit it */
 }
 
 
@@ -250,9 +281,9 @@ VIEW	*vp;
 	if (cl.cl == NULL)
 		goto memerr;
 	cl.n = 0;			/* add cells within pyramid */
-	visit_cells(org, dir, hp, addcell, &cl);
+	visit_cells(org, dir, hp, addcell, (char *)&cl);
 	if (!cl.n) {
-		free((char *)cl.cl);
+		free((void *)cl.cl);
 		return(NULL);
 	}
 	*np = cl.n * orient;
@@ -283,8 +314,8 @@ int	(*f)();
 					/* do each wall on each section */
 	for (hd = 0; hdlist[hd] != NULL; hd++)
 		for (w = 0; w < 6; w++) {
-			g0 = ((w>>1)+1)%3;
-			g1 = ((w>>1)+2)%3;
+			g0 = hdwg0[w];
+			g1 = hdwg1[w];
 			d = 1.0/hdlist[hd]->grid[g0];
 			mov[0] = d * hdlist[hd]->xv[g0][0];
 			mov[1] = d * hdlist[hd]->xv[g0][1];