ViewVC Help
View File | Revision Log | Show Annotations | Download File | Root Listing
root/radiance/ray/src/cv/bsdfmesh.c
(Generate patch)

Comparing ray/src/cv/bsdfmesh.c (file contents):
Revision 2.16 by greg, Wed Feb 19 05:16:06 2014 UTC vs.
Revision 2.17 by greg, Wed Mar 5 22:47:16 2014 UTC

# Line 216 | Line 216 | min_cost(double amt2move, const double *avail, const P
216          return(total_cost);
217   }
218  
219 < /* Compare entries by moving price */
219 > typedef struct {
220 >        short   s, d;           /* source and destination */
221 >        float   dc;             /* discount to push inventory */
222 > } ROWSENT;              /* row sort entry */
223 >
224 > /* Compare entries by discounted moving price */
225   static int
226   rmovcmp(void *b, const void *p1, const void *p2)
227   {
228          PRICEMAT        *pm = (PRICEMAT *)b;
229 <        const short     *ij1 = (const short *)p1;
230 <        const short     *ij2 = (const short *)p2;
231 <        float           price_diff;
229 >        const ROWSENT   *re1 = (const ROWSENT *)p1;
230 >        const ROWSENT   *re2 = (const ROWSENT *)p2;
231 >        double          price_diff;
232  
233 <        if (ij1[1] < 0) return(ij2[1] >= 0);
234 <        if (ij2[1] < 0) return(-1);
235 <        price_diff = pricerow(pm,ij1[0])[ij1[1]] - pricerow(pm,ij2[0])[ij2[1]];
233 >        if (re1->d < 0) return(re2->d >= 0);
234 >        if (re2->d < 0) return(-1);
235 >        price_diff = re1->dc*pricerow(pm,re1->s)[re1->d] -
236 >                        re2->dc*pricerow(pm,re2->s)[re2->d];
237          if (price_diff > 0) return(1);
238          if (price_diff < 0) return(-1);
239          return(0);
# Line 241 | Line 247 | migration_step(MIGRATION *mig, double *src_rem, double
247          const double    maxamt = 1./(double)pm->ncols;
248          const double    minamt = maxamt*1e-4;
249          double          *src_cost;
250 <        short           (*rord)[2];
250 >        ROWSENT         *rord;
251          struct {
252                  int     s, d;   /* source and destination */
253 <                double  price;  /* price estimate per amount moved */
253 >                double  price;  /* cost per amount moved */
254                  double  amt;    /* amount we can move */
255          } cur, best;
256          int             r2check, i, ri;
# Line 253 | Line 259 | migration_step(MIGRATION *mig, double *src_rem, double
259           * destination price implies that another source is closer, so
260           * we can hold off considering more expensive options until
261           * some other (hopefully better) moves have been made.
262 +         * A discount based on source remaining is supposed to prioritize
263 +         * movement from large lobes, but it doesn't seem to do much,
264 +         * so we have it set to 1.0 at the moment.
265           */
266 + #define discount(qr)    1.0
267                                                  /* most promising row order */
268 <        rord = (short (*)[2])malloc(sizeof(short)*2*pm->nrows);
268 >        rord = (ROWSENT *)malloc(sizeof(ROWSENT)*pm->nrows);
269          if (rord == NULL)
270                  goto memerr;
271          for (ri = pm->nrows; ri--; ) {
272 <            rord[ri][0] = ri;
273 <            rord[ri][1] = -1;
272 >            rord[ri].s = ri;
273 >            rord[ri].d = -1;
274 >            rord[ri].dc = 1.f;
275              if (src_rem[ri] <= minamt)          /* enough source material? */
276                      continue;
277              for (i = 0; i < pm->ncols; i++)
278 <                if (dst_rem[ rord[ri][1] = psortrow(pm,ri)[i] ] > minamt)
278 >                if (dst_rem[ rord[ri].d = psortrow(pm,ri)[i] ] > minamt)
279                          break;
280              if (i >= pm->ncols) {               /* moved all we can? */
281                  free(rord);
282                  return(.0);
283              }
284 +            rord[ri].dc = discount(src_rem[ri]);
285          }
286          if (pm->nrows > max2check)              /* sort if too many sources */
287 <                qsort_r(rord, pm->nrows, sizeof(short)*2, pm, &rmovcmp);
287 >                qsort_r(rord, pm->nrows, sizeof(ROWSENT), pm, &rmovcmp);
288                                                  /* allocate cost array */
289          src_cost = (double *)malloc(sizeof(double)*pm->nrows);
290          if (src_cost == NULL)
# Line 285 | Line 297 | migration_step(MIGRATION *mig, double *src_rem, double
297                  r2check = max2check;            /* put a limit on search */
298          for (ri = 0; ri < r2check; ri++) {      /* check each source row */
299              double      cost_others = 0;
300 <            cur.s = rord[ri][0];
301 <            if ((cur.d = rord[ri][1]) < 0 ||
302 <                        (cur.price = pricerow(pm,cur.s)[cur.d]) >= best.price) {
300 >            cur.s = rord[ri].s;
301 >            if ((cur.d = rord[ri].d) < 0 ||
302 >                        rord[ri].dc*pricerow(pm,cur.s)[cur.d] >= best.price) {
303                  if (pm->nrows > max2check) break;       /* sorted end */
304                  continue;                       /* else skip this one */
305              }
# Line 301 | Line 313 | migration_step(MIGRATION *mig, double *src_rem, double
313                      cost_others += min_cost(src_rem[i], dst_rem, pm, i)
314                                          - src_cost[i];
315              dst_rem[cur.d] += cur.amt;          /* undo trial move */
316 <            cur.price += cost_others/cur.amt;   /* adjust effective price */
316 >                                                /* discount effective price */
317 >            cur.price = ( pricerow(pm,cur.s)[cur.d] + cost_others/cur.amt ) *
318 >                                        rord[ri].dc;
319              if (cur.price < best.price)         /* are we better than best? */
320                  best = cur;
321          }
# Line 317 | Line 331 | migration_step(MIGRATION *mig, double *src_rem, double
331   memerr:
332          fprintf(stderr, "%s: Out of memory in migration_step()\n", progname);
333          exit(1);
334 + #undef discount
335   }
336  
337   /* Compute and insert migration along directed edge (may fork child) */

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines