--- ray/src/common/unix_process.c 2003/11/11 16:24:06 3.4 +++ ray/src/common/unix_process.c 2004/09/19 08:42:22 3.6 @@ -1,5 +1,5 @@ #ifndef lint -static const char RCSid[] = "$Id: unix_process.c,v 3.4 2003/11/11 16:24:06 greg Exp $"; +static const char RCSid[] = "$Id: unix_process.c,v 3.6 2004/09/19 08:42:22 greg Exp $"; #endif /* * Routines to communicate with separate process via dual pipes @@ -12,6 +12,7 @@ static const char RCSid[] = "$Id: unix_process.c,v 3.4 #include #include +#include #include "rtprocess.h" @@ -54,6 +55,13 @@ char *av[] close(p1[1]); pd->r = p1[0]; pd->w = p0[1]; + /* + * Close write stream on exec to avoid multiprocessing deadlock. + * No use in read stream without it, so set flag there as well. + * GW: This bug took me two days to figure out!! + */ + fcntl(pd->r, F_SETFD, FD_CLOEXEC); + fcntl(pd->w, F_SETFD, FD_CLOEXEC); pd->running = 1; return(PIPE_BUF); } @@ -67,12 +75,13 @@ SUBPROC *pd { int pid, status; + if (!pd->running) + return(0); close(pd->r); close(pd->w); pd->running = 0; - while ((pid = wait(&status)) != -1) - if (pid == pd->pid) - return(status>>8 & 0xff); + if (waitpid(pd->pid, &status, 0) == pd->pid) + return(status>>8 & 0xff); return(-1); /* ? unknown status */ }