--- ray/src/common/image.c	2005/02/07 20:13:55	2.30
+++ ray/src/common/image.c	2008/12/12 22:05:38	2.35
@@ -1,5 +1,5 @@
 #ifndef lint
-static const char	RCSid[] = "$Id: image.c,v 2.30 2005/02/07 20:13:55 greg Exp $";
+static const char	RCSid[] = "$Id: image.c,v 2.35 2008/12/12 22:05:38 greg Exp $";
 #endif
 /*
  *  image.c - routines for image generation.
@@ -9,6 +9,7 @@ static const char	RCSid[] = "$Id: image.c,v 2.30 2005/
 
 #include "copyright.h"
 
+#include  <ctype.h>
 #include  "rtio.h"
 #include  "rtmath.h"
 #include  "paths.h"
@@ -25,8 +26,9 @@ static gethfunc gethview;
 
 
 char *
-setview(v)		/* set hvec and vvec, return message on error */
-register VIEW  *v;
+setview(		/* set hvec and vvec, return message on error */
+VIEW  *v
+)
 {
 	static char  ill_horiz[] = "illegal horizontal view size";
 	static char  ill_vert[] = "illegal vertical view size";
@@ -34,6 +36,8 @@ register VIEW  *v;
 	if (v->vaft < -FTINY || (v->vaft > FTINY && v->vaft <= v->vfore))
 		return("illegal fore/aft clipping plane");
 
+	if (v->vdist <= FTINY)
+		return("illegal view distance");
 	v->vdist *= normalize(v->vdir);		/* normalize direction */
 	if (v->vdist == 0.0)
 		return("zero view direction");
@@ -90,10 +94,20 @@ register VIEW  *v;
 		v->hn2 = 2.0 * sin(v->horiz*(PI/180.0/2.0));
 		v->vn2 = 2.0 * sin(v->vert*(PI/180.0/2.0));
 		break;
+	case VT_PLS:				/* planispheric fisheye */
+		if (v->horiz >= 360.0-FTINY)
+			return(ill_horiz);
+		if (v->vert >= 360.0-FTINY)
+			return(ill_vert);
+		v->hn2 = 2.*sin(v->horiz*(PI/180.0/2.0)) /
+				(1.0 + cos(v->horiz*(PI/180.0/2.0)));
+		v->vn2 = 2.*sin(v->vert*(PI/180.0/2.0)) /
+				(1.0 + cos(v->vert*(PI/180.0/2.0)));
+		break;
 	default:
 		return("unknown view type");
 	}
-	if (v->type != VT_ANG) {
+	if (v->type != VT_ANG && v->type != VT_PLS) {
 		if (v->type != VT_CYL) {
 			v->hvec[0] *= v->hn2;
 			v->hvec[1] *= v->hn2;
@@ -111,10 +125,12 @@ register VIEW  *v;
 
 
 void
-normaspect(va, ap, xp, yp)		/* fix pixel aspect or resolution */
-double  va;			/* view aspect ratio */
-double  *ap;			/* pixel aspect in (or out if 0) */
-int  *xp, *yp;			/* x and y resolution in (or out if *ap!=0) */
+normaspect(				/* fix pixel aspect or resolution */
+double  va,			/* view aspect ratio */
+double  *ap,			/* pixel aspect in (or out if 0) */
+int  *xp,
+int  *yp			/* x and y resolution in (or out if *ap!=0) */
+)
 {
 	if (*ap <= FTINY)
 		*ap = va * *xp / *yp;		/* compute pixel aspect */
@@ -126,10 +142,13 @@ int  *xp, *yp;			/* x and y resolution in (or out if *
 
 
 double
-viewray(orig, direc, v, x, y)		/* compute ray origin and direction */
-FVECT  orig, direc;
-register VIEW  *v;
-double  x, y;
+viewray(				/* compute ray origin and direction */
+FVECT  orig,
+FVECT  direc,
+VIEW  *v,
+double  x,
+double  y
+)
 {
 	double	d, z;
 	
@@ -180,14 +199,14 @@ double  x, y;
 		d = normalize(direc);
 		return(v->vaft > FTINY ? (v->vaft - v->vfore)*d : 0.0);
 	case VT_ANG:			/* angular fisheye */
-		x *= v->horiz/180.0;
-		y *= v->vert/180.0;
+		x *= (1.0/180.0)*v->horiz;
+		y *= (1.0/180.0)*v->vert;
 		d = x*x + y*y;
 		if (d > 1.0)
 			return(-1.0);
 		d = sqrt(d);
 		z = cos(PI*d);
-		d = d <= FTINY ? PI : sqrt(1 - z*z)/d;
+		d = d <= FTINY ? PI : sqrt(1.0 - z*z)/d;
 		x *= d;
 		y *= d;
 		direc[0] = z*v->vdir[0] + x*v->hvec[0] + y*v->vvec[0];
@@ -197,23 +216,37 @@ double  x, y;
 		orig[1] = v->vp[1] + v->vfore*direc[1];
 		orig[2] = v->vp[2] + v->vfore*direc[2];
 		return(v->vaft > FTINY ? v->vaft - v->vfore : 0.0);
+	case VT_PLS:			/* planispheric fisheye */
+		x *= sqrt(v->hn2);
+		y *= sqrt(v->vn2);
+		d = x*x + y*y;
+		z = (1. - d)/(1. + d);
+		d = d <= FTINY*FTINY ? PI : sqrt((1.0 - z*z)/d);
+		x *= d;
+		y *= d;
+		direc[0] = z*v->vdir[0] + x*v->hvec[0] + y*v->vvec[0];
+		direc[1] = z*v->vdir[1] + x*v->hvec[1] + y*v->vvec[1];
+		direc[2] = z*v->vdir[2] + x*v->hvec[2] + y*v->vvec[2];
+		orig[0] = v->vp[0] + v->vfore*direc[0];
+		orig[1] = v->vp[1] + v->vfore*direc[1];
+		orig[2] = v->vp[2] + v->vfore*direc[2];
+		return(v->vaft > FTINY ? v->vaft - v->vfore : 0.0);
 	}
 	return(-1.0);
 }
 
 
 void
-viewloc(ip, v, p)		/* find image location for point */
-FVECT  ip;
-register VIEW  *v;
-FVECT  p;
+viewloc(			/* find image location for point */
+FVECT  ip,
+VIEW  *v,
+FVECT  p
+)
 {
 	double  d, d2;
 	FVECT  disp;
 
-	disp[0] = p[0] - v->vp[0];
-	disp[1] = p[1] - v->vp[1];
-	disp[2] = p[2] - v->vp[2];
+	VSUB(disp, p, v->vp);
 
 	switch (v->type) {
 	case VT_PAR:			/* parallel view */
@@ -262,10 +295,23 @@ FVECT  p;
 			ip[0] += 180.0/v->horiz;
 			return;
 		}
-		d = acos(d)/PI / sqrt(1.0 - d*d);
-		ip[0] += DOT(disp,v->hvec)*d*180.0/v->horiz;
-		ip[1] += DOT(disp,v->vvec)*d*180.0/v->vert;
+		d = (180.0/PI)*acos(d) / sqrt(1.0 - d*d);
+		ip[0] += DOT(disp,v->hvec)*d/v->horiz;
+		ip[1] += DOT(disp,v->vvec)*d/v->vert;
 		return;
+	case VT_PLS:			/* planispheric fisheye */
+		ip[0] = 0.5 - v->hoff;
+		ip[1] = 0.5 - v->voff;
+		ip[2] = normalize(disp) - v->vfore;
+		d = DOT(disp,v->vdir);
+		if (d >= 1.0-FTINY)
+			return;
+		if (d <= -(1.0-FTINY))
+			return;		/* really an error */
+		d = sqrt(1.0 - d*d) / (1.0 + d);
+		ip[0] += DOT(disp,v->hvec)*d/sqrt(v->hn2);
+		ip[1] += DOT(disp,v->vvec)*d/sqrt(v->vn2);
+		return;
 	}
 	ip[0] = DOT(disp,v->hvec)/v->hn2 + 0.5 - v->hoff;
 	ip[1] = DOT(disp,v->vvec)/v->vn2 + 0.5 - v->voff;
@@ -273,10 +319,12 @@ FVECT  p;
 
 
 void
-pix2loc(loc, rp, px, py)	/* compute image location from pixel pos. */
-RREAL  loc[2];
-register RESOLU  *rp;
-int  px, py;
+pix2loc(		/* compute image location from pixel pos. */
+RREAL  loc[2],
+RESOLU  *rp,
+int  px,
+int  py
+)
 {
 	register int  x, y;
 
@@ -297,10 +345,12 @@ int  px, py;
 
 
 void
-loc2pix(pp, rp, lx, ly)		/* compute pixel pos. from image location */
-int  pp[2];
-register RESOLU  *rp;
-double  lx, ly;
+loc2pix(			/* compute pixel pos. from image location */
+int  pp[2],
+RESOLU  *rp,
+double  lx,
+double  ly
+)
 {
 	register int  x, y;
 
@@ -321,10 +371,11 @@ double  lx, ly;
 
 
 int
-getviewopt(v, ac, av)			/* process view argument */
-register VIEW  *v;
-int  ac;
-register char  *av[];
+getviewopt(				/* process view argument */
+VIEW  *v,
+int  ac,
+char  *av[]
+)
 {
 #define check(c,l)	if ((av[0][c]&&av[0][c]!=' ') || \
 			badarg(ac-1,av+1,l)) return(-1)
@@ -389,27 +440,27 @@ register char  *av[];
 
 
 int
-sscanview(vp, s)			/* get view parameters from string */
-VIEW  *vp;
-register char  *s;
+sscanview(				/* get view parameters from string */
+VIEW  *vp,
+char  *s
+)
 {
 	int  ac;
 	char  *av[4];
 	int  na;
 	int  nvopts = 0;
 
-	while (*s == ' ')
-		s++;
-	if (*s != '-')
-		s = sskip2(s,1);
+	while (isspace(*s))
+		if (!*s++)
+			return(0);
 	while (*s) {
 		ac = 0;
 		do {
 			if (ac || *s == '-')
 				av[ac++] = s;
-			while (*s && *s != ' ')
+			while (*s && !isspace(*s))
 				s++;
-			while (*s == ' ')
+			while (isspace(*s))
 				s++;
 		} while (*s && ac < 4);
 		if ((na = getviewopt(vp, ac, av)) >= 0) {
@@ -424,9 +475,10 @@ register char  *s;
 
 
 void
-fprintview(vp, fp)			/* write out view parameters */
-register VIEW  *vp;
-FILE  *fp;
+fprintview(				/* write out view parameters */
+VIEW  *vp,
+FILE  *fp
+)
 {
 	fprintf(fp, " -vt%c", vp->type);
 	fprintf(fp, " -vp %.6g %.6g %.6g", vp->vp[0], vp->vp[1], vp->vp[2]);
@@ -441,12 +493,14 @@ FILE  *fp;
 
 
 char *
-viewopt(vp)				/* translate to minimal view string */
-register VIEW  *vp;
+viewopt(				/* translate to minimal view string */
+VIEW  *vp
+)
 {
 	static char  vwstr[128];
 	register char  *cp = vwstr;
 
+	*cp = '\0';
 	if (vp->type != stdview.type) {
 		sprintf(cp, " -vt%c", vp->type);
 		cp += strlen(cp);
@@ -497,8 +551,9 @@ register VIEW  *vp;
 
 
 int
-isview(s)				/* is this a view string? */
-char  *s;
+isview(					/* is this a view string? */
+char  *s
+)
 {
 	static char  *altname[]={NULL,VIEWSTR,"rpict","rview","rvu","rpiece","pinterp",NULL};
 	extern char  *progname;
@@ -544,10 +599,11 @@ gethview(				/* get view from header */
 
 
 int
-viewfile(fname, vp, rp)			/* get view from file */
-char  *fname;
-VIEW  *vp;
-RESOLU  *rp;
+viewfile(				/* get view from file */
+char  *fname,
+VIEW  *vp,
+RESOLU  *rp
+)
 {
 	struct myview	mvs;
 	FILE  *fp;