--- ray/src/common/calexpr.c	2003/06/02 18:13:54	2.21
+++ ray/src/common/calexpr.c	2005/05/17 17:51:51	2.30
@@ -1,5 +1,5 @@
 #ifndef lint
-static const char	RCSid[] = "$Id: calexpr.c,v 2.21 2003/06/02 18:13:54 greg Exp $";
+static const char	RCSid[] = "$Id: calexpr.c,v 2.30 2005/05/17 17:51:51 greg Exp $";
 #endif
 /*
  *  Compute data values using expression parser
@@ -20,15 +20,15 @@ static const char	RCSid[] = "$Id: calexpr.c,v 2.21 200
 #include "copyright.h"
 
 #include  <stdio.h>
-
+#include  <string.h>
 #include  <ctype.h>
-
 #include  <errno.h>
-
 #include  <math.h>
-
 #include  <stdlib.h>
 
+#include  "rtmisc.h"
+#include  "rtio.h"
+#include  "rterror.h"
 #include  "calcomp.h"
 
 #define	 MAXLINE	256		/* maximum line length */
@@ -37,17 +37,20 @@ static const char	RCSid[] = "$Id: calexpr.c,v 2.21 200
 
 #define	 isdecimal(c)	(isdigit(c) || (c) == '.')
 
-static double  euminus(), eargument(), enumber();
-static double  echannel();
-static double  eadd(), esubtr(), emult(), edivi(), epow();
-static double  ebotch();
+static double  euminus(EPNODE *), eargument(EPNODE *), enumber(EPNODE *);
+static double  echannel(EPNODE *);
+static double  eadd(EPNODE *), esubtr(EPNODE *),
+               emult(EPNODE *), edivi(EPNODE *),
+               epow(EPNODE *);
+static double  ebotch(EPNODE *);
 
 unsigned int  esupport =		/* what to support */
 		E_VARIABLE | E_FUNCTION ;
 
+int  eofc = 0;				/* optional end-of-file character */
 int  nextc;				/* lookahead character */
 
-double	(*eoper[])() = {		/* expression operations */
+double	(*eoper[])(EPNODE *) = {	/* expression operations */
 	ebotch,
 	evariable,
 	enumber,
@@ -82,8 +85,9 @@ static int  linepos;			/* position in buffer */
 
 
 EPNODE *
-eparse(expr)			/* parse an expression string */
-char  *expr;
+eparse(			/* parse an expression string */
+    char  *expr
+)
 {
     EPNODE  *ep;
 
@@ -97,8 +101,9 @@ char  *expr;
 
 
 double
-eval(expr)			/* evaluate an expression string */
-char  *expr;
+eval(			/* evaluate an expression string */
+    char  *expr
+)
 {
     register EPNODE  *ep;
     double  rval;
@@ -111,8 +116,10 @@ char  *expr;
 
 
 int
-epcmp(ep1, ep2)			/* compare two expressions for equivalence */
-register EPNODE  *ep1, *ep2;
+epcmp(			/* compare two expressions for equivalence */
+    register EPNODE  *ep1,
+    register EPNODE  *ep2
+)
 {
 	double  d;
 
@@ -128,7 +135,7 @@ register EPNODE  *ep1, *ep2;
 		if (ep2->v.num == 0)
 			return(ep1->v.num != 0);
 		d = ep1->v.num / ep2->v.num;
-		return(d > 1.000000000001 | d < 0.999999999999);
+		return((d > 1.000000000001) | (d < 0.999999999999));
 
 	case CHAN:
 	case ARG:
@@ -159,8 +166,9 @@ register EPNODE  *ep1, *ep2;
 
 
 void
-epfree(epar)			/* free a parse tree */
-register EPNODE	 *epar;
+epfree(			/* free a parse tree */
+    register EPNODE	 *epar
+)
 {
     register EPNODE  *ep;
 
@@ -194,22 +202,25 @@ register EPNODE	 *epar;
 
 				/* the following used to be a switch */
 static double
-eargument(ep)
-EPNODE	*ep;
+eargument(
+    EPNODE	*ep
+)
 {
     return(argument(ep->v.chan));
 }
 
 static double
-enumber(ep)
-EPNODE	*ep;
+enumber(
+    EPNODE	*ep
+)
 {
     return(ep->v.num);
 }
 
 static double
-euminus(ep)
-EPNODE	*ep;
+euminus(
+    EPNODE	*ep
+)
 {
     register EPNODE  *ep1 = ep->v.kid;
 
@@ -217,15 +228,17 @@ EPNODE	*ep;
 }
 
 static double
-echannel(ep)
-EPNODE	*ep;
+echannel(
+    EPNODE	*ep
+)
 {
     return(chanvalue(ep->v.chan));
 }
 
 static double
-eadd(ep)
-EPNODE	*ep;
+eadd(
+    EPNODE	*ep
+)
 {
     register EPNODE  *ep1 = ep->v.kid;
 
@@ -233,8 +246,9 @@ EPNODE	*ep;
 }
 
 static double
-esubtr(ep)
-EPNODE	*ep;
+esubtr(
+    EPNODE	*ep
+)
 {
     register EPNODE  *ep1 = ep->v.kid;
 
@@ -242,8 +256,9 @@ EPNODE	*ep;
 }
 
 static double
-emult(ep)
-EPNODE	*ep;
+emult(
+    EPNODE	*ep
+)
 {
     register EPNODE  *ep1 = ep->v.kid;
 
@@ -251,8 +266,9 @@ EPNODE	*ep;
 }
 
 static double
-edivi(ep)
-EPNODE	*ep;
+edivi(
+    EPNODE	*ep
+)
 {
     register EPNODE  *ep1 = ep->v.kid;
     double  d;
@@ -267,8 +283,9 @@ EPNODE	*ep;
 }
 
 static double
-epow(ep)
-EPNODE	*ep;
+epow(
+    EPNODE	*ep
+)
 {
     register EPNODE  *ep1 = ep->v.kid;
     double  d;
@@ -290,18 +307,21 @@ EPNODE	*ep;
 }
 
 static double
-ebotch(ep)
-EPNODE	*ep;
+ebotch(
+    EPNODE	*ep
+)
 {
     eputs("Bad expression!\n");
     quit(1);
+	return 0.0; /* pro forma return */
 }
 
 
 EPNODE *
-ekid(ep, n)			/* return pointer to a node's nth kid */
-register EPNODE	 *ep;
-register int  n;
+ekid(			/* return pointer to a node's nth kid */
+    register EPNODE	 *ep,
+    register int  n
+)
 {
 
     for (ep = ep->v.kid; ep != NULL; ep = ep->sibling)
@@ -313,8 +333,9 @@ register int  n;
 
 
 int
-nekids(ep)			/* return # of kids for node ep */
-register EPNODE	 *ep;
+nekids(			/* return # of kids for node ep */
+    register EPNODE	 *ep
+)
 {
     register int  n = 0;
 
@@ -326,10 +347,11 @@ register EPNODE	 *ep;
 
 
 void
-initfile(fp, fn, ln)		/* prepare input file */
-FILE  *fp;
-char  *fn;
-int  ln;
+initfile(		/* prepare input file */
+    FILE  *fp,
+    char  *fn,
+    int  ln
+)
 {
     static char	 inpbuf[MAXLINE];
 
@@ -344,10 +366,11 @@ int  ln;
 
 
 void
-initstr(s, fn, ln)		/* prepare input string */
-char  *s;
-char  *fn;
-int  ln;
+initstr(		/* prepare input string */
+    char  *s,
+    char  *fn,
+    int  ln
+)
 {
     infp = NULL;
     infile = fn;
@@ -359,11 +382,12 @@ int  ln;
 
 
 void
-getscanpos(fnp, lnp, spp, fpp)	/* return current scan position */
-char  **fnp;
-int  *lnp;
-char  **spp;
-FILE  **fpp;
+getscanpos(	/* return current scan position */
+    char  **fnp,
+    int  *lnp,
+    char  **spp,
+    FILE  **fpp
+)
 {
     if (fnp != NULL) *fnp = infile;
     if (lnp != NULL) *lnp = lineno;
@@ -373,7 +397,7 @@ FILE  **fpp;
 
 
 int
-scan()				/* scan next character, return literal next */
+scan(void)		/* scan next character, return literal next */
 {
     register int  lnext = 0;
 
@@ -390,6 +414,10 @@ scan()				/* scan next character, return literal next 
 	    nextc = linbuf[linepos++];
 	if (!lnext)
 		lnext = nextc;
+	if (nextc == eofc) {
+		nextc = EOF;
+		break;
+	}
 	if (nextc == '{') {
 	    scan();
 	    while (nextc != '}')
@@ -405,8 +433,9 @@ scan()				/* scan next character, return literal next 
 
 
 char *
-long2ascii(l)			      /* convert long to ascii */
-long  l;
+long2ascii(			      /* convert long to ascii */
+    long  l
+)
 {
     static char	 buf[16];
     register char  *cp;
@@ -431,8 +460,9 @@ long  l;
 
 
 void
-syntax(err)			/* report syntax error and quit */
-char  *err;
+syntax(			/* report syntax error and quit */
+    char  *err
+)
 {
     register int  i;
 
@@ -457,9 +487,10 @@ char  *err;
 
 
 void
-addekid(ep, ekid)			/* add a child to ep */
-register EPNODE	 *ep;
-EPNODE	*ekid;
+addekid(			/* add a child to ep */
+    register EPNODE	 *ep,
+    EPNODE	*ekid
+)
 {
     if (ep->v.kid == NULL)
 	ep->v.kid = ekid;
@@ -473,13 +504,13 @@ EPNODE	*ekid;
 
 
 char *
-getname()			/* scan an identifier */
+getname(void)			/* scan an identifier */
 {
-    static char	 str[MAXWORD+1];
+    static char	 str[RMAXWORD+1];
     register int  i, lnext;
 
     lnext = nextc;
-    for (i = 0; i < MAXWORD && isid(lnext); i++, lnext = scan())
+    for (i = 0; i < RMAXWORD && isid(lnext); i++, lnext = scan())
 	str[i] = lnext;
     str[i] = '\0';
     while (isid(lnext))		/* skip rest of name */
@@ -490,7 +521,7 @@ getname()			/* scan an identifier */
 
 
 int
-getinum()			/* scan a positive integer */
+getinum(void)			/* scan a positive integer */
 {
     register int  n, lnext;
 
@@ -505,37 +536,37 @@ getinum()			/* scan a positive integer */
 
 
 double
-getnum()			/* scan a positive float */
+getnum(void)			/* scan a positive float */
 {
     register int  i, lnext;
-    char  str[MAXWORD+1];
+    char  str[RMAXWORD+1];
 
     i = 0;
     lnext = nextc;
-    while (isdigit(lnext) && i < MAXWORD) {
+    while (isdigit(lnext) && i < RMAXWORD) {
 	str[i++] = lnext;
 	lnext = scan();
     }
-    if (lnext == '.' && i < MAXWORD) {
+    if (lnext == '.' && i < RMAXWORD) {
 	str[i++] = lnext;
 	lnext = scan();
 	if (i == 1 && !isdigit(lnext))
 	    syntax("badly formed number");
-	while (isdigit(lnext) && i < MAXWORD) {
+	while (isdigit(lnext) && i < RMAXWORD) {
 	    str[i++] = lnext;
 	    lnext = scan();
 	}
     }
-    if ((lnext == 'e' | lnext == 'E') && i < MAXWORD) {
+    if ((lnext == 'e') | (lnext == 'E') && i < RMAXWORD) {
 	str[i++] = lnext;
 	lnext = scan();
-	if ((lnext == '-' | lnext == '+') && i < MAXWORD) {
+	if ((lnext == '-') | (lnext == '+') && i < RMAXWORD) {
 	    str[i++] = lnext;
 	    lnext = scan();
 	}
 	if (!isdigit(lnext))
 	    syntax("missing exponent");
-	while (isdigit(lnext) && i < MAXWORD) {
+	while (isdigit(lnext) && i < RMAXWORD) {
 	    str[i++] = lnext;
 	    lnext = scan();
 	}
@@ -547,7 +578,7 @@ getnum()			/* scan a positive float */
 
 
 EPNODE *
-getE1()				/* E1 -> E1 ADDOP E2 */
+getE1(void)				/* E1 -> E1 ADDOP E2 */
 				/*	 E2 */
 {
     register EPNODE  *ep1, *ep2;
@@ -569,7 +600,7 @@ getE1()				/* E1 -> E1 ADDOP E2 */
 
 
 EPNODE *
-getE2()				/* E2 -> E2 MULOP E3 */
+getE2(void)				/* E2 -> E2 MULOP E3 */
 				/*	 E3 */
 {
     register EPNODE  *ep1, *ep2;
@@ -591,7 +622,7 @@ getE2()				/* E2 -> E2 MULOP E3 */
 
 
 EPNODE *
-getE3()				/* E3 -> E4 ^ E3 */
+getE3(void)				/* E3 -> E4 ^ E3 */
 				/*	 E4 */
 {
     register EPNODE  *ep1, *ep2;
@@ -613,7 +644,7 @@ getE3()				/* E3 -> E4 ^ E3 */
 
 
 EPNODE *
-getE4()				/* E4 -> ADDOP E5 */
+getE4(void)				/* E4 -> ADDOP E5 */
 				/*	 E5 */
 {
     register EPNODE  *ep1, *ep2;
@@ -641,85 +672,87 @@ getE4()				/* E4 -> ADDOP E5 */
 
 
 EPNODE *
-getE5()				/* E5 -> (E1) */
+getE5(void)			/* E5 -> (E1) */
 				/*	 VAR */
 				/*	 NUM */
 				/*	 $N */
 				/*	 FUNC(E1,..) */
 				/*	 ARG */
 {
-    int	 i;
-    char  *nam;
-    register EPNODE  *ep1, *ep2;
+	int	 i;
+	char  *nam;
+	register EPNODE  *ep1, *ep2;
 
-    if (nextc == '(') {
-	scan();
-	ep1 = getE1();
-	if (nextc != ')')
-	    syntax("')' expected");
-	scan();
-	return(ep1);
-    }
+	if (nextc == '(') {
+		scan();
+		ep1 = getE1();
+		if (nextc != ')')
+			syntax("')' expected");
+		scan();
+		return(ep1);
+	}
 
-    if (esupport&E_INCHAN && nextc == '$') {
-	scan();
-	ep1 = newnode();
-	ep1->type = CHAN;
-	ep1->v.chan = getinum();
-	return(ep1);
-    }
+	if (esupport&E_INCHAN && nextc == '$') {
+		scan();
+		ep1 = newnode();
+		ep1->type = CHAN;
+		ep1->v.chan = getinum();
+		return(ep1);
+	}
 
-  if (esupport&(E_VARIABLE|E_FUNCTION) &&
-		(isalpha(nextc) || nextc == CNTXMARK)) {
-      nam = getname();
-      ep1 = NULL;
-      if ((esupport&(E_VARIABLE|E_FUNCTION)) == (E_VARIABLE|E_FUNCTION)
-			&& curfunc != NULL)
-	    for (i = 1, ep2 = curfunc->v.kid->sibling;
-				ep2 != NULL; i++, ep2 = ep2->sibling)
-		if (!strcmp(ep2->v.name, nam)) {
-		    ep1 = newnode();
-		    ep1->type = ARG;
-		    ep1->v.chan = i;
-		    break;
+	if (esupport&(E_VARIABLE|E_FUNCTION) &&
+			(isalpha(nextc) || nextc == CNTXMARK)) {
+		nam = getname();
+		ep1 = NULL;
+		if ((esupport&(E_VARIABLE|E_FUNCTION)) == (E_VARIABLE|E_FUNCTION)
+				&& curfunc != NULL)
+			for (i = 1, ep2 = curfunc->v.kid->sibling;
+					ep2 != NULL; i++, ep2 = ep2->sibling)
+				if (!strcmp(ep2->v.name, nam)) {
+					ep1 = newnode();
+					ep1->type = ARG;
+					ep1->v.chan = i;
+					break;
+				}
+		if (ep1 == NULL) {
+			ep1 = newnode();
+			ep1->type = VAR;
+			ep1->v.ln = varinsert(nam);
 		}
-	if (ep1 == NULL) {
-	    ep1 = newnode();
-	    ep1->type = VAR;
-	    ep1->v.ln = varinsert(nam);
+		if (esupport&E_FUNCTION && nextc == '(') {
+			ep2 = newnode();
+			ep2->type = FUNC;
+			addekid(ep2, ep1);
+			ep1 = ep2;
+			do {
+				scan();
+				addekid(ep1, getE1());
+			} while (nextc == ',');
+			if (nextc != ')')
+				syntax("')' expected");
+			scan();
+		} else if (!(esupport&E_VARIABLE))
+			syntax("'(' expected");
+		if (esupport&E_RCONST && isconstvar(ep1))
+			ep1 = rconst(ep1);
+		return(ep1);
 	}
-	if (esupport&E_FUNCTION && nextc == '(') {
-	    ep2 = newnode();
-	    ep2->type = FUNC;
-	    addekid(ep2, ep1);
-	    ep1 = ep2;
-	    do {
-		scan();
-		addekid(ep1, getE1());
-	    } while (nextc == ',');
-	    if (nextc != ')')
-		syntax("')' expected");
-	    scan();
-	} else if (!(esupport&E_VARIABLE))
-	    syntax("'(' expected");
-	if (esupport&E_RCONST && isconstvar(ep1))
-	    ep1 = rconst(ep1);
-	return(ep1);
-    }
 
-    if (isdecimal(nextc)) {
-	ep1 = newnode();
-	ep1->type = NUM;
-	ep1->v.num = getnum();
-	return(ep1);
-    }
-    syntax("unexpected character");
+	if (isdecimal(nextc)) {
+		ep1 = newnode();
+		ep1->type = NUM;
+		ep1->v.num = getnum();
+		return(ep1);
+	}
+	syntax("unexpected character");
+	return NULL; /* pro forma return */
 }
 
 
 EPNODE *
-rconst(epar)			/* reduce a constant expression */
-register EPNODE	 *epar;
+rconst(			/* reduce a constant expression */
+    register EPNODE	 *epar
+)
 {
     register EPNODE  *ep;
 
@@ -736,8 +769,9 @@ register EPNODE	 *epar;
 
 
 int
-isconstvar(ep)			/* is ep linked to a constant expression? */
-register EPNODE	 *ep;
+isconstvar(			/* is ep linked to a constant expression? */
+    register EPNODE	 *ep
+)
 {
     register EPNODE  *ep1;
 
@@ -761,19 +795,21 @@ register EPNODE	 *ep;
 
 
 int
-isconstfun(ep)			/* is ep linked to a constant function? */
-register EPNODE	 *ep;
+isconstfun(			/* is ep linked to a constant function? */
+    register EPNODE	 *ep
+)
 {
     register EPNODE  *dp;
     register LIBR  *lp;
 
     if (ep->type != VAR)
 	return(0);
-    if ((dp = ep->v.ln->def) != NULL)
+    if ((dp = ep->v.ln->def) != NULL) {
 	if (dp->v.kid->type == FUNC)
 	    return(dp->type == ':');
 	else
 	    return(0);		/* don't identify masked library functions */
+    }
     if ((lp = ep->v.ln->lib) != NULL)
 	return(lp->atyp == ':');
     return(0);